[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

2023-01-06 Thread Hansang Bae via Phabricator via cfe-commits
hbae added a comment. In D139287#4031473 , @jhuber6 wrote: > In D139287#4031469 , @hbae wrote: > >> Looks like GCC 7.5 cannot build LLVM after this change. Could you please >> take a look? >> >> In file

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

2023-01-06 Thread Hansang Bae via Phabricator via cfe-commits
hbae added a comment. Looks like GCC 7.5 cannot build LLVM after this change. Could you please take a look? In file included from /localdisk/hbae/LLVM/llvm-base/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:11:0:

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

2021-04-06 Thread Hansang Bae via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3da61ddae7fe: [OpenMP] Define omp_is_initial_device() variants in omp.h (authored by hbae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99447/new/

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

2021-04-05 Thread Hansang Bae via Phabricator via cfe-commits
hbae updated this revision to Diff 335347. hbae added a comment. Added inline after static to avoid unused function warning. Added a RUN line to the test to catch unused function warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99447/new/

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

2021-04-02 Thread Hansang Bae via Phabricator via cfe-commits
hbae added inline comments. Comment at: openmp/runtime/src/include/omp.h.var:479 +# endif + # undef __KAI_KMPC_CONVENTION jdoerfert wrote: > Do we want them to be static? I would have expected odr linkage instead. > > > Current clang fails to link two

[PATCH] D99447: [OpenMP] Define omp_is_initial_device() variants in omp.h

2021-04-02 Thread Hansang Bae via Phabricator via cfe-commits
hbae updated this revision to Diff 335034. hbae added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removed omp_is_initial_device() from clang built-ins. Added a new test under openmp/libomptarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D63010: [OpenMP] Add task alloc function

2019-06-14 Thread Hansang Bae via Phabricator via cfe-commits
hbae accepted this revision. hbae added a comment. LGTM. Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org