[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

HaohaiWen added a comment. In D154295#4477203 , @hans wrote: > In D154295#4477165 , @HaohaiWen > wrote: > >>> It would be nice to have some documentation for this feature though. >> >> This feature is same as

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

HaohaiWen added a comment. Thanks everyone. > It would be nice to have some documentation for this feature though. This feature is same as Linux -gsplit-dwarf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154295/new/

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf97b61ed27aa: [Driver][MSVC] Support DWARF fission when using LTO on Windows (authored by HaohaiWen). Repository: rG LLVM Github Monorepo

[PATCH] D154295: [Driver][MSVC] Support DWARF fission when using LTO on Windows

HaohaiWen created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D154070

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen added a comment. In D154176#4466190 , @mstorsjo wrote: > In D154176#4466186 , @mstorsjo > wrote: > >> Ok, thanks for clarifying. However I still don’t understand the “why” aspect >> here. You’re

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen updated this revision to Diff 536518. HaohaiWen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen added a comment. In D154176#4465223 , @mstorsjo wrote: > Is this a NFC change, as a preparation for a separate change? In that case, > please add an NFC tag to the subject - if not, please explain (and test) the > expected behaviour change.

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen updated this revision to Diff 536502. HaohaiWen added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a631a8fedc2: [lld/COFF] Add /dwodir to enable DWARF fission with LTO (authored by HaohaiWen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

HaohaiWen added a comment. In D154070#4461674 , @MaskRay wrote: > I'll be away for a few days and back on July 5. Clicked "Accept" if you keep > just the lld/COFF part for this patch and create another patch for > clang/lib/Driver. > > I guess

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen created this revision. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Check linker earlier so that lld specific flags can be append before inputs. Just like position of other flags.

[PATCH] D154070: [Driver][lld/COFF] Support DWARF fission when using LTO on Windows

HaohaiWen updated this revision to Diff 536084. HaohaiWen added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Remove driver changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/

[PATCH] D154070: [Driver][lld/COFF] Support DWARF fission when using LTO on Windows

HaohaiWen created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch added /dwodir to lld/COFF which

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added a comment. Reland 82dff24bde112984314568e7d581379fd0ea48e6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 534417. HaohaiWen added a comment. Add -- to clang_cl input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 534413. HaohaiWen edited the summary of this revision. HaohaiWen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen reopened this revision. HaohaiWen added a comment. This revision is now accepted and ready to land. The path of this test you were running (/Users/thakis/src/llvm-project/clang/test/Driver/split-debug.c) started with /User which was interpreted as OPT_U option. Therefore split-debug.c

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen closed this revision. HaohaiWen added a comment. Thanks. This patch has been landed. https://github.com/llvm/llvm-project/commit/3eee5aa528abd67bb6d057e25ce1980d0d38c445 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added a comment. @MaskRay, any other comments? I'd like to land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533967. HaohaiWen added a comment. Restore DWARFContext.cpp since D153602 has fixed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533623. HaohaiWen added a comment. Remove CoreOption for dumpdir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added inline comments. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdir : Separate<["-"], "dumpdir">, Flags<[CC1Option]>, +def dumpdir : Separate<["-"],

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533182. HaohaiWen marked 10 inline comments as done. HaohaiWen added a comment. Address maskray's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Any other comments? If not , I'll land this patch tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked 7 inline comments as done. HaohaiWen added inline comments. Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:124 +bool isDwoSection(const MCSection ) { + return Sec.getName().endswith(".dwo"); MaskRay wrote: > static It's already in anonymous

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 532507. HaohaiWen added a comment. Use --target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa() && Section.relocations().empty()) + continue; skan wrote: > Should we merge

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 532060. HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Address skan's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 531219. HaohaiWen added a comment. Fix sections binding check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 530825. HaohaiWen added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1, MaskRay, aheejin. Herald added a reviewer: jdoerfert. Herald added projects:

[PATCH] D123609: [Clang] Remove support for legacy pass manager

HaohaiWen added a comment. Hi @nikic, We recently noticed legacy PM was removed from many places. Does community plan to remove legacy PM completely? Do you know when will CG switch to new PM? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION