[PATCH] D97340: [HIP] Support Spack packages

haampie added a comment. Herald added a subscriber: foad. Hi Yaxunl, > The patch should not cause circular dependency on HIP or device library. I'm not saying this patch introduces a circular dependency, I'm saying you are trying to solve an already existing circular dependency (clang needs dev

[PATCH] D97340: [HIP] Support Spack packages

haampie reopened this revision. haampie added a comment. This revision is now accepted and ready to land. I've created a pull request to spack here: https://github.com/spack/spack/pull/23859, hopefully that's enough to revert this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D97340: [HIP] Support Spack packages

haampie added a comment. Herald added a subscriber: ormris. Hi @tra and @yaxunl, I'm commenting as a reviewer of the spack pull request for the rocm 4.2.0 ecosystem. First of all: thanks for caring about spack installations, that's highly appreciated. However, this patch does not seem the right

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. I don't have commit access, would be great if you could do that for me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. Should this be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie updated this revision to Diff 319871. haampie added a comment. Herald added a subscriber: arphaman. I dropped the awk bits, since there's no portable way to do it there, and replaced all `perl -w` with `perl` and `use warnings`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9511

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. @JDevlieghere, would you care to review? This is another instance of moving away from system binaries to whatever the user / package manager wants the build to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie created this revision. haampie added a reviewer: JDevlieghere. Herald added a reviewer: bollu. haampie requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-comm

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. Also note that the changes are not likely to be backported to 11 even: https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/ https://reviews.llv

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. D86134 should not be added, it was reverted afterwards. What eventually landed was D85820 , which adds a better fix for what D86134 was supposed to solve. Repository:

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added inline comments. Comment at: llvm/lib/Support/CMakeLists.txt:217 + endif() + if(CMAKE_SHARED_LIBRARY_PREFIX AND CMAKE_SHARED_LIBRARY_SUFFIX AND + zlib_library MATCHES "^${CMAKE_SHARED_LIBRARY_PREFIX}.*${CMAKE_SHARED_LIBRARY_SUFFIX}$") This w

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added a comment. Great, one benefit of this is that zlib can now be detected in non-system libs. Maybe we should handle ncurses / TERMINFO in a similar manner? It currently has similar logic as finding zlib had Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://