[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

linjamaki added a comment. In D130766#3687240 , @Anastasia wrote: > CC to @linjamaki in case there is anything else/different needed for HIP. LGMT. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130766/new/ https://reviews.llvm.org/D130766

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

linjamaki added a comment. From my point of view this patch LGTM. Comment at: clang/include/clang/Driver/Options.td:4164-4169 +def fintegrated_objemitter : Flag<["-"], "fintegrated-objemitter">, + Flags<[CoreOption, NoXarchOption]>, Group, +

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki abandoned this revision. linjamaki added a comment. Sounds good to me. I’ll make a new patch when there is a need for it and close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

linjamaki added inline comments. Comment at: llvm/docs/SPIRVUsage.rst:55 + == + ** Generic SPIR-V target without any vendor-specific settings. +

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki added a comment. Thanks for the review, @yaxunl. Could you push this to the LLVM? And to the LLVM 14 release branch too, if possible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

linjamaki created this revision. Herald added a subscriber: yaxunl. linjamaki edited the summary of this revision. Herald added a subscriber: Anastasia. linjamaki published this revision for review. linjamaki added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a

[PATCH] D117137: [Driver] Add CUDA support for --offload param

linjamaki added a comment. In D117137#3269365 , @yaxunl wrote: > Does that mean only "spirv{64}-unknown-unknown" is acceptable, or > "spirv{64}-amd-unknown-unknown" is also acceptable? Having a vendor component in the triple seems to be acceptable for

[PATCH] D117137: [Driver] Add CUDA support for --offload param

linjamaki added a comment. SPIR-V target requires that the OS and the environment type is unknown (see TargetInfo::AllocateTarget and BaseSPIRTargetInfo). The clang would fail to create a SPIR-V target if there is an OS or environment component in the target string known by the Triple. This

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki added a comment. This patch should be ready to land. @tra, could you please commit it to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 395649. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Thanks, @yaxunl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Assuming that this patch is ready to land. @tra or @yaxunl, could you please commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

linjamaki added a comment. If I understand correctly, the default optimization level is `-O2` for the OpenCL and OpenCL++ language mode (according to CompilerInvocation.cpp:getOptimizationLevel()). Since higher than `-O0` may not work with the translator, should the SPIR-V tool chain override

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 394789. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Thanks, @tra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. This patch should be ready to land. @tra, could you please commit this to the LLVM for us. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 394208. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Thanks, @yaxunl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108367: [NFC] computeSPIRKernelABIInfo(): use SPIRABInfo

linjamaki abandoned this revision. linjamaki added a comment. D109818 includes the change in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108367/new/ https://reviews.llvm.org/D108367

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Assuming this patch is ready to land. @yaxunl, Could you please commit this patch to the LLVM for us. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 393465. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. Thanks, @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Thanks for the feedback. The `--offload` is meant to support multiple targets but right now it is restricted to one at most. The limitation comes from the HIPActionBuilder and CudaActionBuilderBase which currently expects a single target triple and toolchain for all

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 392675. linjamaki added a comment. - Add comments to clarify the limitation of the `--offload` option to one target. - Add test for multiple `--offload` option instances. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 392665. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 392664. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. Cherry-picking should work now, @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 ___ cfe-commits mailing list

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 392662. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. The patch is ready to land. @Anastasia, @bader, could you commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Thanks, @Anastasia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. @tra, gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. @Anastasia, Could you please commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389702. linjamaki added a comment. Disable debug info generation for device code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. In D110618#3148501 , @Anastasia wrote: > Could you please clarify the interface to SPIRV-LLVM-Translator tool, > specifically: > > - Does clang lookup the path to the translator or assume any default path? HIPSPV primarily

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki marked 4 inline comments as done. linjamaki added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389118. linjamaki added a comment. Retry push changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 389114. linjamaki marked 2 inline comments as done. linjamaki added a comment. Update a driver test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389112. linjamaki added a comment. Combine options with append(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files:

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki added a comment. Thanks for the help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki marked 2 inline comments as done. linjamaki added inline comments. Comment at: clang/include/clang/Basic/Cuda.h:109 + // Generic processor model is for testing only. + return A >= CudaArch::GFX600 && A <= CudaArch::GFX1035; } yaxunl wrote: > can we

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 388146. linjamaki added a comment. - Adjust `--offload` description: reflect the current state. - Adjust enum range check in IsAMDGpuArch(). - Make `--offload` and `--offload-arch` options mutually exclusive. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki added a comment. Hi @Anastasia and @bader, This patch should be ready to land, I think. Could you please push it to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 387511. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki updated this revision to Diff 387510. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685 Files: clang/include/clang/Driver/Options.td

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 387509. linjamaki added a comment. Herald added a subscriber: asavonic. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 387508. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 387507. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 387506. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added inline comments. Comment at: clang/lib/Basic/Targets/SPIR.h:233 +if (Opts.HIP && Opts.CUDAIsDevice) + // Enable address space mapping from HIP to SPIR-V. + // See comment on the SPIRDefIsGenMap table. Anastasia wrote: > linjamaki

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 387500. linjamaki added a comment. Rebase, add asserts and move address space map reset for HIP from SPIRVTargetInfo to BaseSPIRTargetInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 387499. linjamaki marked an inline comment as done. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 Files:

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a comment. Is this patch ready to land on the LLVM? We do not have commit rights, so can you please commit this patch for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki updated this revision to Diff 383019. linjamaki added a comment. Rebase on updated llvm-spirv tool (D112404 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.llvm.org/D112410

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki marked an inline comment as done. linjamaki added a comment. Thanks for the review. Comment at: clang/lib/Driver/ToolChains/SPIRV.cpp:18 + +void SPIRV::constructTranslateCommand(Compilation , const Tool , + const JobAction ,

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 383001. linjamaki added a comment. Rename SPIRV::Translator's tool names as suggested by bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/ https://reviews.llvm.org/D112404 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 382932. linjamaki added a comment. Update for changes in D112404 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files:

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki updated this revision to Diff 382931. linjamaki marked an inline comment as done. linjamaki added a comment. Remove `--spirv-ext` and `--spirv-max-version`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112404/new/

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki added a comment. > Do I read it correctly that you would have no objections for others to rework > this patch if needed? :) Yes, anyone can work on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki marked an inline comment as done. linjamaki added inline comments. Comment at: clang/include/clang/Driver/Options.td:1534 +HelpText<"Specify maximum SPIR-V version which can be emitted">; +def spirv_ext_EQ : CommaJoined<["--"], "spirv-ext">, +HelpText<"Specify

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 382244. linjamaki added a comment. Improve `--offload` option description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Gentle ping. Is anything needed to be addressed to get this patch accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki added a comment. Thanks for the review. Updated the patch with the style suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 ___ cfe-commits

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 382228. linjamaki added a comment. Rephrase expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp

[PATCH] D112410: [SPIR-V] Add a tool chain for SPIR-V (incomplete)

linjamaki created this revision. Herald added a subscriber: ThomasRaoux. linjamaki published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a tool chain (TC) for SPIR-V for demonstration purposes. The TC is not complete but it is

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki updated this revision to Diff 381858. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111047/new/ https://reviews.llvm.org/D111047 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki updated this revision to Diff 381857. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685 Files: clang/include/clang/Driver/Options.td

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 381855. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 381854. linjamaki added a comment. Rebase and use SPIRV::constructTranslateCommand() to contruct the LLVM-SPIR-V translation command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 381852. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 381851. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 381850. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/Targets/SPIR.h

[PATCH] D112404: [SPIR-V] Add translator tool

linjamaki created this revision. Herald added subscribers: ThomasRaoux, dang, mgorny. linjamaki requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a tool for constructing commands for translating LLVM IR to SPIR-V. Used by HIPSPV tool

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki updated this revision to Diff 381847. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/ https://reviews.llvm.org/D109144 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a subscriber: yaxunl. linjamaki added a comment. > Thanks for the clarifications. So it seems that you are not expecting that > the device target triple is being explicitly passed anywhere then and that > means you pass the device triple implicitly? We are meaning to use the

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a comment. > Can you explain what does this mean It was trying to clarify a potential misunderstanding of how programs are compiled when HIPSPV is targeted: For HIPSPV, the SPIR-V code generation is done by the clang driver. When we compile HIP programs for HIPCL or the HIPLZ

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki added a comment. > What I have in mind is to continue using SPIR target for now (until SPIR-V > back-end is added). > For instance, SYCL compiler emits code for SPIR target and code format is > configured via flag. > > `-emit-llvm` changes output file format for regular C++

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki added a comment. In D110685#3044993 , @Anastasia wrote: > Ok, is the idea to deprecate this flag once we switch to `llc` by default > then? The idea is to remove the flags if no one else needs them when the HIPSPV tool chain switches over to

[PATCH] D111047: CUDA/HIP: Allow __int128 on the host side

linjamaki created this revision. Herald added a subscriber: yaxunl. linjamaki edited the summary of this revision. linjamaki added a reviewer: rsmith. linjamaki added subscribers: bader, Anastasia. linjamaki published this revision for review. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki created this revision. Herald added subscribers: dang, yaxunl. linjamaki updated this revision to Diff 376838. linjamaki added a comment. linjamaki edited the summary of this revision. linjamaki added a reviewer: Anastasia. linjamaki updated this revision to Diff 376848. linjamaki

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 376829. linjamaki added a comment. Repurpose 'Generic' CudaArch, Use getAllArgValues() for reading --offload values and fix a enum range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 376822. linjamaki added a comment. Update option description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files:

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. In D110622#3030792 , @tra wrote: >> A Cuda GPU architecture ‘generic’ is added. The name is picked from the LLVM >> SPIR-V Backend. In the HIPSPV code path the architecture name is inserted to >> the bundle entry ID as target

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. In D110618#3032899 , @Anastasia wrote: > Considering that SPIR-V translation step is also required for other languages > would it make sense to add `llvm-spirv` as a common tool like for example > C/C++ linkers and create a

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki created this revision. Herald added subscribers: Naghasan, dexonsmith, dang, Anastasia, yaxunl, jholewinski. linjamaki updated this revision to Diff 375783. linjamaki added a comment. linjamaki updated this revision to Diff 375786. linjamaki added reviewers: yaxunl, bader. linjamaki

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki created this revision. Herald added subscribers: dang, kerbowa, yaxunl, mgorny, nhaehnle, jvesely. linjamaki updated this revision to Diff 375526. linjamaki added a comment. linjamaki published this revision for review. Herald added a project: clang. Herald added a subscriber:

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki created this revision. Herald added subscribers: yaxunl, mgorny. linjamaki edited the summary of this revision. linjamaki updated this revision to Diff 375488. linjamaki added a comment. linjamaki edited the summary of this revision. linjamaki added a reviewer: yaxunl. linjamaki

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 375233. linjamaki added a comment. Put HIPSPV logic into new SPIRV{ABI,TargetCodeGen}Info subclassed from CommonSPIR{ABI,TargetCodeGen}Info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 375221. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files: clang/lib/Basic/Targets/SPIR.h

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 375219. linjamaki added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/

[PATCH] D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info

linjamaki updated this revision to Diff 375216. linjamaki added a comment. Rename SPIRABIInfo -> CommonSPIRABIInfo and SPIRTargetCodeGenInfo -> CommonSPIRTargetCodeGenInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109144/new/

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10224 +// pointers for HIPSPV. When the language mode is HIP, the SPIRTargetInfo +// maps cuda_device to SPIR-V's CrossWorkGroup address space. +llvm::Type *LTy = CGT.ConvertType(Ty);

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10221 +ABIArgInfo SPIRABIInfo::classifyKernelArgumentType(QualType Ty) const { + if (getContext().getLangOpts().HIP && getTarget().getTriple().isSPIRV()) { +// Coerce pointer arguments with

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki created this revision. Herald added subscribers: Anastasia, yaxunl. linjamaki updated this revision to Diff 372671. linjamaki added a comment. Herald added subscribers: dexonsmith, hiraditya. linjamaki updated this revision to Diff 373494. linjamaki edited the summary of this revision.

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki updated this revision to Diff 373497. linjamaki edited the summary of this revision. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 Files:

  1   2   >