Getting Started docs need updating with libcxxabi

2017-07-15 Thread Howard Hinnant via cfe-commits
http://clang.llvm.org/get_started.html Missing instructions to checkout llvm/projects/libcxxabi (now needed). Howard signature.asc Description: Message signed with OpenPGP ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [libcxx] r290806 - chrono: address post commit comments from Howard

2017-01-01 Thread Howard Hinnant via cfe-commits
Very close! Comment below: On Jan 1, 2017, at 5:04 PM, Saleem Abdulrasool via cfe-commits wrote: > > Author: compnerd > Date: Sun Jan 1 16:04:38 2017 > New Revision: 290806 > > URL: http://llvm.org/viewvc/llvm-project?rev=290806&view=rev > Log: > chrono: address post commit comments from How

Re: [libcxx] r290803 - chrono: implement a Windows version of system_clock::now

2017-01-01 Thread Howard Hinnant via cfe-commits
On Jan 1, 2017, at 3:20 PM, Saleem Abdulrasool via cfe-commits wrote: > > Author: compnerd > Date: Sun Jan 1 14:20:41 2017 > New Revision: 290803 > > URL: http://llvm.org/viewvc/llvm-project?rev=290803&view=rev > Log: > chrono: implement a Windows version of system_clock::now > > system_clock

Re: [PATCH] D21396: [libcxxabi] Reorder base class initializers in libc++abi tests to prevent -Wreorder

2016-06-15 Thread Howard Hinnant via cfe-commits
howard.hinnant added a comment. Look good to me. http://reviews.llvm.org/D21396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-06-14 Thread Howard Hinnant via cfe-commits
howard.hinnant added a comment. Can't call `std::abs` as it isn't `constexpr`. You'll have to roll your own. http://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

2016-06-14 Thread Howard Hinnant via cfe-commits
howard.hinnant added a comment. I created a top-level `gcd` which did nothing but make everything unsigned and do the abs once, and then called a `__gcd` specialized for unsigned and only one kind of unsigned, and got measurably faster results (about 10%). template constexpr std::enable_i

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

2016-04-29 Thread Howard Hinnant via cfe-commits
howard.hinnant added a comment. A quiet nan is the right tool. A signaling nan is nothing more than a 40-year-old design flaw. A quiet nan is "sticky" in that if you try to compute with it, the result is quiet nan. But you can assign a valid number to something containing a quiet nan. So if

Re: [PATCH] D19623: [libc++] Initialize local doubles to 0.0.

2016-04-27 Thread Howard Hinnant via cfe-commits
howard.hinnant added a subscriber: howard.hinnant. howard.hinnant added a comment. When in doubt, I find initializing to nan a safe thing to do. Either the code is correct, or the nan will find the bug. http://reviews.llvm.org/D19623 ___ cfe-commi

Re: [PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

2016-02-09 Thread Howard Hinnant via cfe-commits
On Feb 9, 2016, at 7:46 PM, Duncan P. N. Exon Smith wrote: > > >> On 2016-Feb-09, at 16:40, Howard Hinnant wrote: >> >> On Feb 9, 2016, at 7:17 PM, Duncan P. N. Exon Smith via cfe-commits >> wrote: >>> >>> Any other ideas for improving the failure mode? >> >> Here’s a suggestion: >> >> h

Re: [PATCH] D17053: [libcxx]: vector: Use < instead of != to improve failure mode

2016-02-09 Thread Howard Hinnant via cfe-commits
On Feb 9, 2016, at 7:17 PM, Duncan P. N. Exon Smith via cfe-commits wrote: > > Any other ideas for improving the failure mode? Here’s a suggestion: https://github.com/llvm-mirror/libcxx/blob/master/include/vector#L1658 Make this easy to activate. Howard _

Re: [libcxx] r196411 - Give all members of exception types default visibility. Lack of this is causing some illegal code relocations rare and hard to reproduce cases.

2016-01-08 Thread Howard Hinnant via cfe-commits
On Jan 8, 2016, at 7:50 PM, Duncan P. N. Exon Smith wrote: > > [re-send to lists.llvm.org] > [necromancy] > > This is causing some strangeness for users of libc++ headers that > ship dylibs and build with -fno-rtti and -fvisibility=hidden. > > Strangely, -fno-rtti does *not* imply -fno-excepti

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

2015-12-16 Thread Howard Hinnant via cfe-commits
That would destroy the timing information, but no one seems to be paying attention to that anyway. I recommend just picking smaller buffer sizes. But 11 is too small. Small enough to pass on your embedded platform, but not in the range of a typical alignof(max_align_t). Howard On Dec 16, 20

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

2015-12-15 Thread Howard Hinnant via cfe-commits
On Dec 15, 2015, at 5:30 PM, Jonathan Roelofs wrote: > > > Could these large padding things be related to the fact that the test is used > as a performance check for the implementation? That being said, I have no > idea who is paying attention to the numbers that come out of this test (if > a

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

2015-12-10 Thread Howard Hinnant via cfe-commits
Fwiw, if you ever here me gripe about the C++ committee’s poor record of messing around in the C headers with detrimental effects, this is what I’m referring to. Yes, the C++ signatures are superior. No, this wasn’t a good thing to do. The C++ committee should not try to change or delete stuf