This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342388: [Clang-Tidy: modernize] Fix for
modernize-redundant-void-arg: complains about… (authored by IdrissRio,
committed by ).
Changed prior to commit:
IdrissRio added a comment.
In https://reviews.llvm.org/D52135#1236690, @JonasToth wrote:
> LG from my side.
> I guess you found this in a real code base, if so could you please verify
> its fixed now.
Actually I'm searching for the bug in bugzilla and I try to fix them.
> If @aaron.ballman,
IdrissRio updated this revision to Diff 165741.
IdrissRio added a comment.
Thank you @JonasToth. As you suggest I have added the test for the
templatic function.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52135
Files:
clang-tidy/modernize/RedundantVoidArgCheck.cpp
IdrissRio updated this revision to Diff 165683.
IdrissRio edited the summary of this revision.
IdrissRio added a comment.
Thank you @JonasToth.
I have update the patch and i have added two cases. The first an
instantiation of a non-templated function. The second is the instantiation
of a
IdrissRio added a comment.
In https://reviews.llvm.org/D52135#1235950, @lebedev.ri wrote:
>
> It will now completely skip all the explicitly instantiated functions, no?
In my opinion, for this kind of check, we don't have the necessity to take in
consideration the function instantiation.
IdrissRio created this revision.
IdrissRio added reviewers: aaron.ballman, hokein, alexfh.
Herald added a subscriber: cfe-commits.
[Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about
variable cast to void
Repository:
rCTE Clang Tools Extra
IdrissRio updated this revision to Diff 160039.
IdrissRio added a comment.
Yes it works also for the non macro. It is actually more general.
This update have passed all the tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49800
Files:
IdrissRio updated this revision to Diff 159179.
IdrissRio added a comment.
Thank you @alexfh. You where right. This update is more general.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49800
Files:
clang-tidy/modernize/RedundantVoidArgCheck.cpp
IdrissRio created this revision.
IdrissRio added reviewers: aaron.ballman, hokein, alexfh.
Herald added a subscriber: cfe-commits.
Hello, i would like to suggest a fix for one of the checks in clang-tidy. The
bug was reported in https://bugs.llvm.org/show_bug.cgi?id=28406 where you can
find
This revision was automatically updated to reflect the committed changes.
IdrissRio marked an inline comment as done.
Closed by commit rCTE337286: [clang-tidy: modernize] Fix
modernize-use-equals-default with {} brackets list… (authored by IdrissRio,
committed by ).
Changed prior to commit:
IdrissRio updated this revision to Diff 155715.
IdrissRio added a comment.
Fixed the formatting error with clang-format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49356
Files:
clang-tidy/modernize/UseEqualsDefaultCheck.cpp
IdrissRio created this revision.
IdrissRio added reviewers: aaron.ballman, hokein, alexfh.
Herald added a subscriber: cfe-commits.
Hello, i would like to suggest a fix for one of the checks in clang-tidy. The
bug was reported in https://bugs.llvm.org/show_bug.cgi?id=38039 where you can
find
12 matches
Mail list logo