[PATCH] D49794: [libclang] Allow skipping warnings from all included files

yvvan created this revision. yvvan added reviewers: ilya-biryukov, bkramer, akyrtzi, malaperle. Updated clone for https://reviews.llvm.org/D48116 by Nikolai, now also adds the clang driver flag and the test for it. If clang has plugins they are also affected by this filtering. Depending on the

[PATCH] D49010: YAML output for index-while-building

yvvan added a comment. @ilya-biryukov I would name this revision "for test purpose". It works at some extent with the current clangd version and can be used by someone else. But since we had a discussion about YAML being a temporary solution I never planned to commit this revision. So yes, I

[PATCH] D49010: YAML output for index-while-building

yvvan updated this revision to Diff 155331. https://reviews.llvm.org/D49010 Files: include/clang/Index/IndexRecordReader.h include/clang/Index/IndexRecordWriter.h include/indexstore/IndexStoreCXX.h include/indexstore/indexstore.h lib/Index/ClangIndexRecordWriter.cpp

[PATCH] D49063: [libclang] Add support for ObjCObjectType

yvvan added inline comments. Comment at: include/clang-c/Index.h:35 #define CINDEX_VERSION_MAJOR 0 #define CINDEX_VERSION_MINOR 49 Please, increment the minor version (you are adding new functions) Comment at: include/clang-c/Index.h:3644

[PATCH] D49010: YAML output for index-while-building

yvvan created this revision. yvvan added a reviewer: nathawes. Herald added subscribers: ioeric, ilya-biryukov. Should be compatible with the current index format accepted by clangd https://reviews.llvm.org/D49010 Files: include/clang/Index/IndexRecordReader.h

[PATCH] D48314: [Frontend] Cache preamble-related data

yvvan added a comment. @ilya-biryukov Sorry. I didn't have time to post comments here. The usecase that we have is a supportive translation unit for code completion. Probably you use something similar in clangd not to wait for the TU to be reparsed after a change? The gain from this change is

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. But this one misses a way to set this flag for everything except libclang. We can probably change that (Nikolai is in vacation till the end of summer so it's probably my part now) and add some tests outside of Index for it (probably Frontend) Repository: rC Clang

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. The idea was to ignore everything including notes and remarks so that only errors from system headers are still collected. Changing consumer might be a possible way to go as well but it requires changing (or wrapping) all consumers that we need to be affected. The

[PATCH] D48423: [liblang] Remove DOS line endings in libclang.exports

yvvan accepted this revision. yvvan added a comment. This revision is now accepted and ready to land. Thanks! I probably forgot to check line endings for this file before committing which I do for source files and headers... Repository: rC Clang https://reviews.llvm.org/D48423

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. @ilya-biryukov what do you think? Repository: rC Clang https://reviews.llvm.org/D48116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43453: Fix overloaded static functions for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rC335211: [Sema] Fix overloaded static functions for templates (authored by yvvan, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D43453 Files:

[PATCH] D48315: [Frontend] Share global completions cache

yvvan created this revision. yvvan added reviewers: ilya-biryukov, arphaman, erikjv. Append ASTUnit cache with global completions cache. In case of multiple translation units for the same file reduces the memory consumption and save completions cache generation time.

[PATCH] D48314: [Frontend] Cache preamble-related data

yvvan created this revision. yvvan added reviewers: ilya-biryukov, arphaman, erikjv. In case two translation units are created for the same file - reuse preamble data to reduce memory and save time on extra preamble generation. https://reviews.llvm.org/D48314 Files:

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

This revision was automatically updated to reflect the committed changes. Closed by commit rC334593: [libclang] Optionally add code completion results for arrow instead of dot (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D46862?vs=151124=151133#toc

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 151124. yvvan added a comment. Diff with unix line endings https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h test/Index/complete-arrow-dot.cpp tools/c-index-test/c-index-test.c

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 151123. yvvan marked 2 inline comments as done. yvvan added a comment. Address comments about Index.h new functions parameters https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

yvvan added a comment. Cool! That's actually quite a small change with big outcome! Comment at: include/clang/Basic/Diagnostic.h:216 + // Suppress warnings from all included files. + bool SuppressWarningsFromIncludedFiles = false; Probably mention that it

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 150291. yvvan marked 8 inline comments as done. yvvan added a comment. Address review comments https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h test/Index/complete-arrow-dot.cpp

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

This revision was automatically updated to reflect the committed changes. Closed by commit rL334070: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149697. yvvan added a comment. Use fixture in unit-test https://reviews.llvm.org/D47460 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp Index:

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan updated this revision to Diff 149684. yvvan added a comment. fix indentation in unit-test https://reviews.llvm.org/D47460 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/ASTUnitTest.cpp Index:

[PATCH] D47460: [Frontend] Honor UserFilesAreVolatile flag getting file buffer in ASTUnit

yvvan added a comment. In https://reviews.llvm.org/D47460#1118694, @ilya-biryukov wrote: > Is it plausible to add a unit-test for this? i think I can add a unit-test for it since we have the 'getBufferKind' method in MemoryBuffer. https://reviews.llvm.org/D47460

[PATCH] D47460: Treat files as volatile by default

yvvan updated this revision to Diff 149249. yvvan added a comment. This is the proper fix. When we get a buffer for main file we should use the UserFilesAreVolatile flag to specify if memory mapping needs to occur or not. https://reviews.llvm.org/D47460 Files: lib/Frontend/ASTUnit.cpp

[PATCH] D47460: Treat files as volatile by default

yvvan added a comment. Memory mapping locks the file on Windows. That means that in the addressed case it locks main file which we are editing. After that happens many tools struggle to do something with this file, for example git. It's the quickest solution, probably not the best. Better one

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang-c/Index.h:5264 + * FixIts that *must* be applied before inserting the text for the + * corresponding completion item. + * nik wrote: > * Please use proper documentation style, e.g. make use of "\brief",

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 149049. yvvan marked 6 inline comments as done. yvvan added a comment. Address review comments https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h test/Index/complete-arrow-dot.cpp

[PATCH] D47460: Treat files as volatile by default

yvvan added a comment. The precise path which leads here is yet unclear for me (it requires much more time to research) but changing this specific default value to true fixes main file from being memory mapped and therefore being blocked (on Windows) I assume it comes from

[PATCH] D47460: Treat files as volatile by default

yvvan created this revision. yvvan added reviewers: ilya-biryukov, nik, klimek, bkramer. Prevent accidental memory mapping for main file which sometimes happens through FileSystem::getBufferForFile https://reviews.llvm.org/D47460 Files: include/clang/Basic/VirtualFileSystem.h Index:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

This revision was automatically updated to reflect the committed changes. Closed by commit rL333272: Optionally add code completion results for arrow instead of dot (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148559. yvvan added a comment. Update according to c++ part changes https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148553. yvvan added a comment. NIT-s addressed https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h include/clang/Sema/Sema.h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked an inline comment as done. yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4148 + + CompletionSucceded |= DoCompletion(Base, IsArrow, None); + yvvan wrote: > ilya-biryukov wrote: > > NIT: maybe swap the two cases to do the

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 4 inline comments as done. yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4148 + + CompletionSucceded |= DoCompletion(Base, IsArrow, None); + ilya-biryukov wrote: > NIT: maybe swap the two cases to do the non-fixit ones

[PATCH] D46862: [libclang] Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148177. yvvan added a comment. Output range of token being replaced instead of it's text As a side-effect introduce a call to get a Token starting from specified location. https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 148164. yvvan marked 4 inline comments as done. https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h include/clang/Sema/Sema.h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4109 + if (CodeCompleter->includeFixIts()) { +const SourceRange OpRange(OpLoc, OpLoc.getLocWithOffset(IsArrow ? 2 : 1)); +CompletionSucceded = ilya-biryukov wrote: > yvvan wrote: > >

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/CodeCompleteConsumer.cpp:559 +const char *Begin = +SemaRef.SourceMgr.getCharacterData(FixIt.RemoveRange.getBegin()); +const char *End = ilya-biryukov wrote: > Unfortunately, that might

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added a comment. Tests run fine but the solution feels like a workaround. Nevertheless if we are sure that extending the subscript/call operator range does not work properly or breaks too many other things than it's probably fine to have this workaround. https://reviews.llvm.org/D40481

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

This revision was automatically updated to reflect the committed changes. Closed by commit rC332578: [libclang] Allow skipping function bodies in preamble only (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D45815?vs=145648=147253#toc Repository: rC

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rC332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D46050?vs=146999=147077#toc Repository: rL

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

This revision was automatically updated to reflect the committed changes. Closed by commit rL332469: [Frontend] Avoid running plugins during code completion parse (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46862: Optionally add code completion results for arrow instead of dot (libclang)

yvvan updated this revision to Diff 147042. yvvan added a comment. The base revision has changed - some minor changes were also required here. https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools/c-index-test/c-index-test.c

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 147039. yvvan marked 4 inline comments as done. yvvan added a comment. Append PrintingCodeCompleteConsumer and CompilerInvocation options, add CodeCompletion tests. https://reviews.llvm.org/D41537 Files: include/clang/Driver/CC1Options.td

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. I will add more tests... Comment at: test/SemaCXX/member-expr.cpp:193 +Cl0* c; +return c.a; // expected-error {{member reference type 'PR15045::Cl0 *' is a pointer; did you mean to use '->'?}} + } ilya-biryukov wrote: > Is

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4118 + : diag::err_typecheck_member_reference_suggestion; + Diag(OpLoc, DiagID) << ConvertedBaseType << IsArrow + << Base->getSourceRange() << FixIt;

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 146749. yvvan marked 2 inline comments as done. yvvan added a comment. Only C++ part, libclang part has moved to https://reviews.llvm.org/D46862 https://reviews.llvm.org/D41537 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D46862: Optionally add code completion results for arrow instead of dot (libclang)

yvvan created this revision. yvvan added reviewers: ilya-biryukov, klimek, bkramer, arphaman. Follow up for https://reviews.llvm.org/D41537 - libclang part is extracted into this review https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. In https://reviews.llvm.org/D41537#1097763, @ilya-biryukov wrote: > I should've suggested splitting the change into two earlier. Next time I will do that from the beginning :) Comment at: tools/libclang/CIndexCodeCompletion.cpp:309 + /// before that

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping I hope this review won't take forever :) https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 146289. yvvan marked 3 inline comments as done. yvvan added a comment. Only keep small completion fixit-s in CodeCompletionResults. Change libclang calls to overcome that and not use CXCompletionString https://reviews.llvm.org/D41537 Files:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 3 inline comments as done. yvvan added a comment. I have some failing tests... So I will update the diff a bit later (Friday most likely) Comment at: include/clang/Sema/CodeCompleteConsumer.h:564 + + /// \brief For this completion result correction is required.

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 145664. yvvan added a comment. Address comments and provide diff with full context https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang-c/Index.h:5220 +CINDEX_LINKAGE CXString +clang_getCompletionCorrection(CXCompletionString completion_string, + unsigned correction_index, ilya-biryukov wrote: > I'm a bit vary

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:704 +CXAvailabilityKind Availability, +const std::vector ) : Allocator(Allocator), CCTUInfo(CCTUInfo), Priority(Priority),

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 144285. yvvan marked 4 inline comments as done. yvvan added a comment. Minor clean-up according to the last comments https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 144076. yvvan added a comment. Wrapper around FIxItHint is removed, other review comments are addressed . https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang-c/Index.h:5278 + /** + * \brief Whether to try dot to arrow correction if arrow operator can be applied. + */ ilya-biryukov wrote: > This implies that "dot to arrow" is the only available correction.

[PATCH] D45815: [libclang] Add options to limit skipping of function bodies

yvvan added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:679 + struct SkipFunctionBodiesOptions { +SkipFunctionBodiesOptions() {} +enum { None, MainFileAndPreamble, Preamble } Scope = None; ilya-biryukov wrote: > Default ctor will be

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 143572. yvvan added a comment. Use vector instead of optional as Ilya suggested https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 143566. yvvan added a comment. Use wrapped FixItHint to keep corrections. Can be quite easily changed from Optional to some container if required. https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:565 + /// \brief For this completion result correction is required. + Optional Corr = None; + yvvan wrote: > ilya-biryukov wrote: > > Having a string replacement without an

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:565 + /// \brief For this completion result correction is required. + Optional Corr = None; + ilya-biryukov wrote: > Having a string replacement without an actual range to

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan added a comment. In https://reviews.llvm.org/D44426#1042162, @mibintc wrote: > I added some inline comments. You are using the Intel 18.0 compiler on > Windows - what version of Visual Studio is in the environment? Yes, I'm using 18.0 Comment at:

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan added a comment. @nhaehnle And that's the problem. There's no build machine for intel compiler and nobody cares. And if somebody like me want to build it - there's no solution rather than searching for workarounds yourself. This patch is not that complex in the end as you see so it should

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan created this revision. yvvan added reviewers: bkramer, klimek. Herald added subscribers: JDevlieghere, nhaehnle, arsenm. Herald added a reviewer: deadalnix. I've tested it on Windows with 64-bit icl These are mostly workarounds for https://software.intel.com/en-us/comment/1919743 ,

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 138139. yvvan added a comment. Return possibly required corrections in the string form https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h

[PATCH] D35200: Don't use mmap on Windows

yvvan abandoned this revision. yvvan added a comment. It was the wrong direction https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Or is your idea is to return the char sequence instead to use this correction in some universal way? https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. I've already added hints in this patch and it also do not add extra completions unless the flag IncludeCorrections is set. So this will not force editors to use corrections. Did you mean that you think it's good to have extra fixit hints even if this flag is not set?

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

yvvan added a comment. In https://reviews.llvm.org/D41005#1001854, @cameron314 wrote: > @yvvan: The clang frontend tests (`PCHPreambleTest` and friends) are disabled > on Windows in the makefile (I think because the VFS tests depend on > linux-like paths). So running the tests on Windows

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

yvvan added reviewers: ilya-biryukov, bkramer, arphaman. yvvan added a comment. Looks ok-ish, I haven't built it though. Also I don't have much exp with indexing part of libclang. Adding more reviewers. Repository: rC Clang https://reviews.llvm.org/D42895

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping... https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

yvvan added a comment. I feel quite ok about this patch. Can you please add unit-tests? Repository: rC Clang https://reviews.llvm.org/D42895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 132146. yvvan added a comment. Use https://reviews.llvm.org/D42474 code. Add missing parts and tests for errors and fixits. https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan marked 4 inline comments as done. yvvan added a comment. @ilya-biryukov Thanks a lot for you comments and for the provided code replacement. I'm checking now how it works and will continue addressing other comments. https://reviews.llvm.org/D41537

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Ping!!! https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. One more Ping! https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 130384. yvvan added a comment. Rebased. Applies for current master. Also ping again... https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h

[PATCH] D42099: [libclang] Add missing CINDEX_LINKAGE

yvvan added a comment. I have mentioned there the original number (https://reviews.llvm.org/D39903) in the commit message but it's also not mentioned in the log there. Repository: rC Clang https://reviews.llvm.org/D42099 ___ cfe-commits mailing

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 128509. yvvan added a comment. Update CIndex minor version, add call to libclang.exports https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Sema/CodeCompleteConsumer.h include/clang/Sema/CodeCompleteOptions.h

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

This revision was automatically updated to reflect the committed changes. Closed by commit rC321698: [libclang] Fix cursors for functions with trailing return type (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D40561?vs=124576=128499#toc Repository:

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rC321697: [libclang] Support querying whether a declaration is invalid (authored by yvvan, committed by ). Changed prior to commit: https://reviews.llvm.org/D40072?vs=128491=128497#toc Repository: rC

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

yvvan added a comment. No regression in tests on Windows with and without extra patch ([PATCH] Use file path instead of uniqueID) Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan created this revision. yvvan added reviewers: klimek, bkramer, arphaman, ilya-biryukov, erikjv. Currently getting such completions requires source correction, reparsing and calling completion again. And if it shows no results and rollback is required then it costs one more reparse. With

[PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

yvvan added a comment. Can we still have it in 5.0? Repository: rL LLVM https://reviews.llvm.org/D40746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification,

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added inline comments. Comment at: tools/libclang/CIndex.cpp:6888 + const SourceLocation fixedEnd = + RefNameRange.getEnd().getLocWithOffset(-1); + RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd); nik wrote: > yvvan wrote:

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

yvvan added inline comments. Comment at: tools/libclang/CIndex.cpp:6445 + struct PostChildrenAction { + CXCursor cursor; + enum Action { Invalid, Ignore, Postpone } action; 4 spaces instead of 2 Comment at:

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification,

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. @bkramer Not yet, it would be good to have one though :) https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. one more ping... https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan added a comment. ping https://reviews.llvm.org/D38618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan updated this revision to Diff 119273. yvvan added a comment. Rebased to update ScopeFlags. Rereview please https://reviews.llvm.org/D38618 Files: include/clang/Sema/Scope.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-super.cpp Index:

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan updated this revision to Diff 117988. yvvan added a comment. Fix according to the review comment https://reviews.llvm.org/D38618 Files: include/clang/Sema/Scope.h lib/Parse/ParseDeclCXX.cpp lib/Sema/SemaCodeComplete.cpp test/Index/complete-super.cpp Index:

[PATCH] D38618: Do not add a colon chunk to the code completion of class inheritance access modifiers

yvvan created this revision. With enabled CINDEXTEST_CODE_COMPLETE_PATTERNS env option (which enables IncludeCodePatterns in completion options) code completion after colon currently suggests access modifiers with 2 completion chunks which is incorrect. Example: class A : B { } Currently we

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. ping 3 https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   >