[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

yvvan added a comment. ping 3 https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. one more ping :) https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

yvvan added a comment. This actually fixes the ability to run safely without threads. This happens because by default this solution leads to try/catch block instead of the direct function call which is implemented in deleted if blocks. https://reviews.llvm.org/D37554

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. ping https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan updated this revision to Diff 111647. yvvan marked 5 inline comments as done. yvvan added a comment. Review comments + solved https://bugs.llvm.org/show_bug.cgi?id=34207 issue. I've also added the extra test for that issue https://reviews.llvm.org/D36390 Files:

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added inline comments. Comment at: lib/Sema/SemaOverload.cpp:6342 +&& !isa(FD)) { + Args = Args.slice(1); +} nik wrote: > bkramer wrote: > > assert that FD is a static method. > Just stumbled here because I was looking into

[PATCH] D35200: Don't use mmap on Windows

yvvan added a comment. The files might also be removed. I checked that with qtcreator from git. Switching to the different branch started reparse of some files. When I frequently switched branches back and forth I got lock issues. With mmap turned off this did not happen.

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan abandoned this revision. yvvan added a comment. In https://reviews.llvm.org/D34873#841624, @rnk wrote: > This shouldn't be necessary after https://reviews.llvm.org/rL310905. https://reviews.llvm.org/D34873 ___ cfe-commits mailing list

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan updated this revision to Diff 110978. yvvan added a comment. I have minimized the crash case and added simple test for it. https://reviews.llvm.org/D36458 Files: lib/Parse/Parser.cpp test/Index/std-begin-error.cpp Index: test/Index/std-begin-error.cpp

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Can someone help me to commit it to the proper branch? (I don't have permissions) https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. But I don't know the source of that issue, I only know how to fix it because I caught that one in debugger and added a check to prevent it. How can I write testcase for such fix? https://reviews.llvm.org/D36458 ___

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. And if you just meant how to reproduce: You need to parse and reparse standard header (my current one is C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory). I can provide the options and a command line that I have if you can't reproduce it with

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Ping... https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. Please check that one https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. Do you mean the testcase that runs only for windows with ms-extensions flag and msvc includes? I don't know if clang has that kind of tests. Does it? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. I've just found a regression in my change. in case I have std::string(/*complete here*/) I need to investigate that case because I thought it's covered by !isa(FD) ... https://reviews.llvm.org/D36390 ___ cfe-commits mailing

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan updated this revision to Diff 109980. yvvan added a comment. Yes, I missed to include one file in this diff where it's used https://reviews.llvm.org/D36390 Files: include/clang/Sema/Sema.h lib/Sema/SemaCodeComplete.cpp lib/Sema/SemaOverload.cpp test/Index/complete-call.cpp

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan updated this revision to Diff 109968. yvvan added a comment. Add unit-test for the case fixed in this review https://reviews.llvm.org/D35355 Files: lib/Frontend/ASTUnit.cpp lib/Parse/ParseTemplate.cpp test/Index/code-completion.cpp Index: test/Index/code-completion.cpp

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan created this revision. https://bugs.llvm.org/show_bug.cgi?id=33904 Happens when static function is accessed via the class variable. That leads to incorrect overloads number because the variable is considered as the first argument. struct Bar { static void foo(); static void foo(int);

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. In https://reviews.llvm.org/D35355#831845, @klimek wrote: > Sorry for missing this - can you add a test? I think I can :) Will add it next week. https://reviews.llvm.org/D35355 ___ cfe-commits mailing list

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. one more Ping. this is quite a useful fix that does not cost much https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. ping. Do you think this is ok now? https://reviews.llvm.org/D34873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan updated this revision to Diff 108878. yvvan marked 2 inline comments as done. yvvan added a comment. Make safe solution without regression https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. Ok, i will make safer solution... https://reviews.llvm.org/D34873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan updated this revision to Diff 108620. yvvan added a comment. Provide a workaround without regression https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp === ---

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan added a comment. The same alignment in other places works fine. i don't know the source of that issue. Should be somewhere in gcc(mingw) but it's not my focus. So this is a workaround that we can make (probably only for mingw builds) https://reviews.llvm.org/D34873

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 107077. yvvan added a comment. Add TODO about '=' check https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-completion.cpp test/Index/complete-optional-params.cpp Index:

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. So do we wait until the '=' case is more clear? This change should not break anything if it's fixed in either direction (if '=' will be provided always or never) https://reviews.llvm.org/D33644 ___ cfe-commits mailing list

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Ping https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan created this revision. When we have enabled cache for global completions we did not have diagnostics for Bar and could not complete Ba as in provided code example. template struct Foo { T member; }; template using Bar = Foo; int main() { Ba } https://reviews.llvm.org/D35355

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 106170. yvvan added a comment. Add more checks into GetDefaultValueString to make it safe https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-completion.cpp

[PATCH] D35200: Don't use mmap on Windows

yvvan added a comment. What do you think about that change? https://reviews.llvm.org/D35200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Ping! Comments are added :) https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 105976. yvvan added a comment. Add comments why it's needed to add '=' to default value in some cases https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp test/Index/code-completion.cpp

[PATCH] D35200: Don't use mmap on Windows

yvvan created this revision. Memory mapping does not make llvm faster (at least I don't see any difference). It also allows llvm not to lock files which is sometimes quite important. https://reviews.llvm.org/D35200 Files: lib/Support/MemoryBuffer.cpp Index: lib/Support/MemoryBuffer.cpp

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Ping :) It's quite likely ok now because covered with tests. Check please. https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 105045. yvvan added a comment. Add tests, append tests with default values. Move all default value handling to GetDefaultValueString https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/functions.cpp

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

yvvan added a comment. In https://reviews.llvm.org/D34680#794135, @vsk wrote: > Do you know which function clang was processing when it crashed? That would > help us find a test case. I have a trace: #0 0x7ff6942b777c HandleAbort d:\code\llvm_copy\lib\support\windows\signals.inc:405:0 #1

[PATCH] D34873: Fix miscompiled 32bit binaries by mingw

yvvan created this revision. With that patch applied my 32-bit libclang.dll built with mingw does not crash anymore unit tests are not affected by that change https://reviews.llvm.org/D34873 Files: lib/AST/ExprConstant.cpp Index: lib/AST/ExprConstant.cpp

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793594, @klimek wrote: > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > > > Do not

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#793573, @klimek wrote: > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > Do not evaluate numbers. > > Check for != "=" is needed not to mess with invalid default arguments or > > their types (without it I get "const Bar&

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

yvvan added a comment. F3487082: llvm.profdata Profdata which causes crash https://reviews.llvm.org/D34680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34680: Fix clang-cl build -fprofile-instr-use flag

yvvan created this revision. Reproduced while building llvm with clang-cl. I have trained profdata file. When I tried to use it I got crash complaining of nullptr casted inside visitor. https://reviews.llvm.org/D34680 Files: lib/CodeGen/CodeGenPGO.cpp Index: lib/CodeGen/CodeGenPGO.cpp

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan abandoned this revision. yvvan added a comment. Can't reproduce an error anymore https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Recheck please the latest diff https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I've tried once again to make a clean build and it worked... :) And I can't imagine what kind of configuration issue could it be because I always use quite the same one :) https://reviews.llvm.org/D34279 ___ cfe-commits

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. In https://reviews.llvm.org/D34279#784089, @hans wrote: > I have 19.00.24210, so slightly earlier I suppose, but I believe we use > Update 3 on our Chromium buildbots, and they seem happy. > > Can you paste the full error message? The part I see in your screenshot >

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 103016. yvvan added a comment. Do not evaluate numbers. Check for != "=" is needed not to mess with invalid default arguments or their types (without it I get "const Bar& bar = =" when Bar is not defined) https://reviews.llvm.org/D33644 Files:

[PATCH] D33644: Add default values for function parameter chunks

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2453 std::string PlaceholderStr = FormatFunctionParameter(Policy, Param); +if (Param->hasDefaultArg() && PlaceholderStr.find("=") == std::string::npos) { +std::string DefaultValue =

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. btw my cl version is 19.00.24215.1 (MS VS 2015 Update 3). Do you use the same one? https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I've checked once again. Werror is disabled and no /WX flag is used. So this is a compiler error in case of msvc even without these flags. https://reviews.llvm.org/D34279 ___ cfe-commits mailing list

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I also did not have any local patches applied - just checked out release_40 branch for llvm and clang. I believe I also don't have warnings as errors enabled. At least I've checked for the extra flags and did not find such. I'll search once again if I have /WX somewhere

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. error list https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan created this revision. I currently have narrowing conversion error without that fix. I try building with 64 and 32 bit compilers - both reproduce that error. https://reviews.llvm.org/D34279 Files: include/llvm/Target/TargetOpcodes.h Index: include/llvm/Target/TargetOpcodes.h

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 102800. yvvan added a comment. Use Lexer::getSourceText https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp === ---

[PATCH] D33644: Add default values for function parameter chunks

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2453 std::string PlaceholderStr = FormatFunctionParameter(Policy, Param); +if (Param->hasDefaultArg() && PlaceholderStr.find("=") == std::string::npos) { +std::string DefaultValue =

[PATCH] D33644: Add default values for function parameter chunks

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2411-2417 + const SourceLocation StartLoc = SrcRange.getBegin(); + const SourceLocation EndLoc = SrcRange.getEnd(); + if (StartLoc != SM.getExpansionLoc(StartLoc) || EndLoc != SM.getExpansionLoc(EndLoc))

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. In https://reviews.llvm.org/D33644#780188, @klimek wrote: > Can you give a bit more background what this is trying to do? Sure :) Currently default value string does not contain default value itself. This change fixes it and adds the default value to the string.

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Anyone? :) https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34098: Allow to set incremental processing from CIndex

yvvan created this revision. Make possible to parse translation Unit in CIndex with incremental processing turned on. 1. Why to do that? - Reparse with that option takes less time. 2. What's the affected area? - I don't know. Can someone explain me what incremental processing is and what I

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Can someone check my review please? https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101995. yvvan added a comment. "what kind of performance benefits do you get for the preamble load times?" In cases where many windows headers are included preamble loading takes almost the half of reparse time. With this fix time to load preamble goes towards

[PATCH] D33493: Speed up preamble loading

yvvan updated this revision to Diff 101865. yvvan added a comment. Improve commentary. Use StringMap https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp

[PATCH] D33493: Speed up preamble loading

yvvan added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:192 + /// of that loading + std::map SrcLocCache; + arphaman wrote: > You can use an `llvm::StringMap` instead. I will change that Comment at:

[PATCH] D33493: Speed up preamble loading

yvvan added a comment. In https://reviews.llvm.org/D33493#774264, @arphaman wrote: > Can you use a local map in `TranslateStoredDiagnostics` instead of storing > one in the `ASTUnit`, or do you need to keep it around? The whole purpose is to use it between different TranslateStoredDiagnostics

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 101533. yvvan added a comment. Remove global completion cache part because it's probably not always valid. https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Waiting for review... https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 100705. yvvan edited the summary of this revision. yvvan added a comment. Support for non-simple types. Drop results with macros. https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp

[PATCH] D33644: Add default values for function parameter chunks

yvvan created this revision. Append optional chunks with their default values. For example: before - "int i", after - "int i = 10". This change affects only simple types. https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 100605. yvvan added a comment. diff with -U https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp === ---

<    1   2   3