Re: Add warning for c++ member variable shadowing

cfe-commits@lists.llvm.org>" <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronballman.com<mailto:aa...@aaronballman.com>>, Richard Smith <rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>> Subject: Re: Add warning for c++ member variable

Re: Add warning for c++ member variable shadowing

.@fb.com>> Cc: "cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>" <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronballman.com<mailto:aa...@aaronballman.com>>, Richard Smith <rich...@metafoo.co.u

Re: Add warning for c++ member variable shadowing

:cfe-commits@lists.llvm.org>>, Aaron Ballman <aa...@aaronballman.com<mailto:aa...@aaronballman.com>>, Richard Smith <rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>> Subject: Re: Add warning for c++ member variable shadowing Some more stylistic comments:

Re: Add warning for c++ member variable shadowing

onballman.com<mailto:aa...@aaronballman.com>>, Richard Smith <rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>> Subject: Re: Add warning for c++ member variable shadowing Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the t

Re: Add warning for c++ member variable shadowing

lt;rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>> Subject: Re: Add warning for c++ member variable shadowing Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have in doxygen form. Im not sure if its in line

Re: Add warning for c++ member variable shadowing

lt;aa...@aaronballman.com<mailto:aa...@aaronballman.com>>, Richard Smith <rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>> Subject: Re: Add warning for c++ member variable shadowing Some more stylistic comments: The description that you have on CheckShadowInheritedVariab

Re: Add warning for c++ member variable shadowing

an.com>>, Richard Smith <rich...@metafoo.co.uk<mailto:rich...@metafoo.co.uk>> Subject: Re: Add warning for c++ member variable shadowing Some more stylistic comments: The description that you have on CheckShadowInheritedVariables isn't really the type of comments that we have

Re: Add warning for c++ member variable shadowing

eally the type of comments that we have in doxygen form. Im not sure if its in line with the rest of the code. The ignore warning comments are restating what is in the code, please remove them. Could you make the header and the source file match the name? Why are you checking that the DeclCon

Re: Add warning for c++ member variable shadowing

y the type of comments that we have in doxygen form. Im not sure if its in line with the rest of the code. The ignore warning comments are restating what is in the code, please remove them. Could you make the header and the source file match the name? Why are you checking that the DeclContext has a

Re: Add warning for c++ member variable shadowing

e source file match the name? Why are you checking that the DeclContext has a definition rather than the record itself? Space after the <<. Don't use the cast for the check, use isa. Although, since you use the value later, it is probably better to write this as: if (const auto *RD =

Re: Add warning for c++ member variable shadowing

the record itself? Space after the <<. Don't use the cast for the check, use isa. Although, since you use the value later, it is probably better to write this as: if (const auto *RD = cast(CurContext)) CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD, RD); On Tue, J

Re: Add warning for c++ member variable shadowing

use the cast for the check, use isa. Although, since you use the value later, it is probably better to write this as: if (const auto *RD = cast(CurContext)) CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD, RD); On Tue, Jan 24, 2017 at 4:06 PM, James Sun via cfe-commits

Re: Add warning for c++ member variable shadowing

Coding style change From: James Sun Date: Tuesday, January 24, 2017 at 2:36 PM To: "cfe-commits@lists.llvm.org" Subject: Add warning for c++ member variable shadowing Dear members Here is a patch (attached) to create warnings where a member

Add warning for c++ member variable shadowing

Dear members Here is a patch (attached) to create warnings where a member variable shadows the one in one of its inheriting classes. For cases where we really don't want to shadow member variables, e.g. class a { int foo; } class b : a { int foo; // Generate a warning } This patch (1)