[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 282263. Jac1494 added a comment. Hi @riccibruno, Address your review comment.Add please use Name :- Jaydeep Chauhan Mail id:- jaydeepchauhan1...@gmail.com Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281911. Jac1494 added a comment. Hi @aaron.ballman , Address your review comments. Thank you for accepting this. I don't have commit access please commit this. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281644. Jac1494 added a comment. Address @aaron.ballman review comments. I have added your test case that is passing as well. This patch covers this scenario also. Thanks @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281202. Jac1494 added a comment. Addressed @riccibruno comments.Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/ https://reviews.llvm.org/D84678 Files: clang/lib/Sema/SemaType.cpp clang/test/Sema/void-argument.cpp Index:

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 added inline comments. Comment at: clang/test/Sema/void-argument.cpp:1 +// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s + riccibruno wrote: > These kinds of tests are typically done with a `-verify` test. See the other > tests in `Sema/` for examples. we

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 created this revision. Jac1494 added a reviewer: rsmith. Jac1494 added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes false line number in a function definition with "void" parameter. For more details PR46417. Repository: rG LLVM Github Monorepo

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. In D71451#1817334 , @aprantl wrote: > In D71451#1816269 , @Jac1494 wrote: > > > ping > > > I'd be curious to the answer to David's questions. If the size increase is > because of unused

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 marked an inline comment as done. Jac1494 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4598 + if (!(DebugKind == clang::codegenoptions::FullDebugInfo)) +return; aprantl wrote: > nit: > > ``` > if (DebugKind <

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 updated this revision to Diff 239115. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-extern-variable-basic.c

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 updated this revision to Diff 239089. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGDebugInfo.cpp Index: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. > that still seems very surprising - this change is specifically intended to > add more debug info, is it not? So do you have any ideas/theories as to why > that's not showing up in the data? Yes, In clang and llvm extern variable are there inside header file ,So

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. > Do you have any reason to believe these patches would reduce the size of the > debug info? It seems like they only add more debug info, and don't remove > anything - so we'd expect an increase in the size, certainly not a decrease. > That means, to me, there's

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. >> I'd be curious to the answer to David's questions. If the size increase is >> because of unused extern variables coming in from libc or something then it >> doesn't seem worth the cost. For above case clang size is increase because ,it is difference between clang

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. > Am I reading this right that the data would suggest that enabling this > feature /reduces/ the size of debug info sections? That doesn't sound right - > can you explain why that would be the case? (perhaps the data is incorrect/it > wasn't built with

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. >> @Jac1494 - have you made any measurements of the size increase of this >> change? Perhaps a self-host build of clang? With change(default) and without change size diffrence given below ,in that only debug section size is changed. Without change:-(default) $size -A

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. In D71451#1786517 , @dblaikie wrote: > Do you have any particular users/use case for this? A case when shared library built without debug info and executable with debug info. And while debugging we want to know the types of

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 updated this revision to Diff 234273. Jac1494 added a comment. Separate clang patch with test cases . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 created this revision. Jac1494 added reviewers: dblaikie, vsk, echristo. Jac1494 added a project: debug-info. Herald added subscribers: cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. Hi Devs, Consider below testcases, $cat shlib.c int var; int test() { return

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

Jac1494 added a comment. For some real life case like below we need debuginfo for declaration of global extern variable . $cat shlib.c int var; int test() { return var++; } $cat test extern int test(); extern int var; int main() { var++; printf("%d\n",test()); } If we debug above case with