[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 marked an inline comment as done. jyu2 added a comment. Thanks. @rnk Comment at: clang/test/CodeGenCXX/ms-inheriting-ctor.cpp:41 + +// CHECK-LABEL: define internal noundef ptr @"??0?$B@_N@@QEAA@AEBVF@@AEBUA@@@Z"(ptr noundef nonnull returned align 1 dereferenceable(1)

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0bd8e51be2: [MSABI] Remove comdat attribute for inheriting ctor. (authored by jyu2). Changed prior to commit:

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 updated this revision to Diff 554025. jyu2 added a comment. Thanks @rnk. This is address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158538/new/ https://reviews.llvm.org/D158538 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Hi @rnk, Thank you so much for the suggestion. >> Before we do that, you should be able to delete the logic in >> CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. >> Your change should have the same effect. Can you do that, and check that it >>

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Ping, Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045 This issue related with big change of 5179eb78210a2ad01a18c37b75048ccfe78414ac Where internal linkage for inheriting ctor were set in change set at following code. Could

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 created this revision. jyu2 added reviewers: rnk, rsmith, majnemer, cfe-commits. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. Currently, for MS, the linkage for the inheriting constructors is set to internal. However, the comdat attribute

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff08c8e57e39: [SEH] Fix wrong argument passes to the call of OutlinedFinally. (authored by jyu2). Changed prior to commit:

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGCleanup.cpp:882 if (!Scope.hasBranchThroughs() && !HasFixups && !HasFallthrough && - Scope.getNumBranchAfters() == 1) { + !getLangOpts().EHAsynch && Scope.getNumBranchAfters() == 1) {

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

jyu2 updated this revision to Diff 552157. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158233/new/ https://reviews.llvm.org/D158233 Files: clang/lib/CodeGen/CGCleanup.cpp clang/test/CodeGen/exceptions-seh-finally.c

[PATCH] D158233: [SEH] Fix wrong argument passes to the call of OutlinedFinally.

jyu2 created this revision. jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. When return out of __try block. In this test case, currently "false" is passed to the OutlinedFinally call,

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33e3b2c46084: Fix assertion when -fasy-exception is used. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

jyu2 updated this revision to Diff 549174. jyu2 added a comment. Thanks all for the review! This is fix space problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157566/new/ https://reviews.llvm.org/D157566 Files: clang/lib/CodeGen/CGCleanup.cpp

[PATCH] D157566: [SEH] fix assertion when -fasy-exceptions is used.

jyu2 created this revision. jyu2 added reviewers: asmith, tentzen, rnk, efriedma, pengfei. jyu2 added a project: clang. Herald added a project: All. jyu2 requested review of this revision. The assertion only happens with use of -fasy-exception without -fexcessions. The assertion appen during the

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

jyu2 added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:794 + // [-Wc++20-extensions] + LabelDecl *TL = TargetLabel; + // Is TargetLabel one of the targets of the JumpStmt? If not, then skip Just wonder why not just use

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

jyu2 accepted this revision. jyu2 added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D155342 ___ cfe-commits mailing list

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG852fe30b687e: [OPENMP52] Deprecation of depend clause in ordered directive. (authored by jyu2). Changed prior to commit:

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jyu2 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1532 InGroup; +def warn_omp_depend_in_ordered_deprecated : Warning<"denpend clause for ordered is deprecated; use doacross instaed">, InGroup; aaron.ballman wrote: >

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jyu2 updated this revision to Diff 538162. jyu2 added a comment. Thanks @jdoerfert, @ABataev and @aaron.ballman for the code reviews. This is addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154672/new/

[PATCH] D154672: [OPENMP52] Deprecation of 'depend' clause in ordered directive.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf70967fdc473: [OPENMP52] Support Support omp_cur_iteration modifier for doacross (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:2516-2523 + if (DepType == OMPC_DOACROSS_source) +OS << "source:"; + else if (DepType == OMPC_DOACROSS_sink) +OS << "sink:"; + else if (DepType == OMPC_DOACROSS_source_omp_cur_iteration) +OS <<

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

jyu2 updated this revision to Diff 537749. jyu2 added a comment. Thanks Alexey for the review. This is address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154556/new/ https://reviews.llvm.org/D154556 Files:

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

jyu2 updated this revision to Diff 537553. jyu2 added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154556/new/ https://reviews.llvm.org/D154556 Files: clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D154556: [OPENMP52] Support Support omp_cur_iteration modifier for doacross clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35041a435def: [OPENMP52] Codegen support for doacross clause. (authored by jyu2). Changed prior to commit:

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added a comment. In D154180#4469417 , @ABataev wrote: > LG with a nit Thank you so much! Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11410 } else { -assert(C->getDependencyKind() == OMPC_DEPEND_sink); +assert(ODK.isSink(C)); RTLFn = OMPBuilder.getOrCreateRuntimeFunction(CGM.getModule(), ABataev

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536838. jyu2 added a comment. Thanks Alexey for the review!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11405-11406 + llvm::OpenMPIRBuilder = CGM.getOpenMPRuntime().getOMPBuilder(); + const OMPDependClause *DepC = dyn_cast(C); + const OMPDoacrossClause *DoC = dyn_cast(C); + if ((DoC &&

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536798. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11401-11402 llvm::Value *Args[] = { - emitUpdateLocation(CGF, C->getBeginLoc()), - getThreadID(CGF, C->getBeginLoc()), + RT.emitUpdateLocation(CGF, C->getBeginLoc()), +

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536443. jyu2 added a comment. Thanks Alexey!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11383 void CGOpenMPRuntime::emitDoacrossOrdered(CodeGenFunction , - const OMPDependClause *C) { + const OMPClause *CL)

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536394. jyu2 marked an inline comment as done. jyu2 added a comment. Thanks Alexey's review. This address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 closed this revision. jyu2 added a comment. Checked in with rG085845a2acbe CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535794. jyu2 added a comment. Sorry, full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 added a comment. Thanks. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier =

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535601. jyu2 added a comment. Thanks Alexey's review. This is address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files:

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 added a comment. Thanks Alexey for the review. Comment at: clang/lib/Parse/ParseOpenMP.cpp:4415-4439 + } else if (Kind == OMPC_doacross) { +// Handle dependence type for the doacross clause. +ColonProtectionRAIIObject ColonRAII(*this); +Data.ExtraModifier =

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 updated this revision to Diff 535289. jyu2 added a comment. Thanks Alex for the review. This is to address his comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153556/new/ https://reviews.llvm.org/D153556 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D153556: [OPENMP52] Initial support for doacross clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: sunshaoce, arphaman, guansong, yaxunl. Herald added a reviewer: kiranchandramohan. Herald added projects: Flang, All. jyu2 requested review of this

[PATCH] D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaa33b6a98de: Fix assert DeclRefExpr for Decl not entered in LocalDeclMap? (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D151743: [OMP] Fix compiler assert "DeclRefExpr for Decl not entered in LocalDeclMap?"

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Currently compiler assert when passing variable "memspace" in

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa419ec4f256d: Fix runtime crash inside __kmpc_init_allocator (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

jyu2 added a comment. In D148723#4376946 , @serge-sans-paille wrote: > @jyu2 : could you test that patch in your setup ? Also I can't find the bug > id associated with your original bug anymore... I just submit bug in

[PATCH] D151576: Fix runtime crash inside __kmpc_init_allocator

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, jplehr, sstefan1. It seems load of traits.addr should be passed in

[PATCH] D151517: Fix wrong error message when compiling C souce code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacb1b4fbb793: Fix wrong error message when compiling C souce code: (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151517: Fix wrong error message when compiling C souce code

jyu2 added a comment. In D151517#4374583 , @ABataev wrote: > Could you split it into 3 separate patch Thanks Alexey! Sure I am split into three. Here is first one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151517: Fix wrong error message when compiling C souce code

jyu2 updated this revision to Diff 525894. jyu2 retitled this revision from "Fix couple of problems in uses_allocators clause." to "Fix wrong error message when compiling C souce code". jyu2 edited the summary of this revision. jyu2 added a comment. Thanks Alexey, sure I am separate the patch.

[PATCH] D151517: Fix couple of problems in uses_allocators clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, jplehr, sstefan1. 1> Fix wrong error message when compiling C souce

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 accepted this revision. jyu2 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

This revision was automatically updated to reflect the committed changes. Closed by commit rG691927c904ed: Fix assertion when try is used inside catch(...) block (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150340/new/

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 added a comment. In D150340#4343915 , @efriedma wrote: > LGTM... but I don't think the IR we're generating is really correct overall; > see https://github.com/llvm/llvm-project/issues/62723 > > On a side-note, other open issues related to

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 updated this revision to Diff 521465. jyu2 added a comment. Address Eli's comment. Thanks for review!. :-( Sorry, You are right!! It is seems EmitSehTryScopeBegin is not called anywhere. Changed. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:650 +llvm::FunctionCallee SehCppScope = getSehTryBeginFn(CGM); +EmitSehScope(SehCppScope); + } efriedma wrote: > Do we need to make the same change in

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 created this revision. jyu2 added reviewers: asmith, efriedma, tentzen, pengfei. jyu2 added a project: clang. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. jyu2 requested review of this revision. Current assert wiht /EHa with A single unwind edge may only enter

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. If it is okay with is_divece_ptr. I am okay with it. Please add a lit test for this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

jyu2 added a comment. I think something like #ifdef RINZOCORE_SHARED #define RINZO_LIB __declspec(dllexport) #else #define RINZO_LIB __declspec(dllimport) #endif RINZO_LIB inline func() {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/

[PATCH] D148723: [clang] Enforce internal linkage for inline builtin

jyu2 added a comment. Hi @serge-sans-paille, thanks for the fix. Could you please also try some test with dllimport/dllexport with inline function? Jennifer Comment at: clang/lib/AST/ASTContext.cpp:11538 const FunctionDecl *FD)

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

jyu2 added a comment. This change seems cause assert: https://godbolt.org/z/z9G87Wr37 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d9880ebbcb7: [OpenMP]Skip generating this[:1] map info for non-member variable. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

jyu2 updated this revision to Diff 504907. jyu2 added a comment. Fix clang format problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146000/new/ https://reviews.llvm.org/D146000 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

jyu2 added a comment. In D145093#4179927 , @ronlieb wrote: > seems to fail amdgpu buildbot > https://lab.llvm.org/buildbot/#/builders/193/builds/27692 I turn off the test run to amdgpu. And rechecked in with c5b060900e98

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f2f37842582: Add map info for dereference pointer. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145093: [OpenMP] Add map info for dereference pointer.

jyu2 updated this revision to Diff 503413. jyu2 added a comment. Okay, I add code to get **a to work. Thanks Alexey for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 Files:

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) || +

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 502842. jyu2 added a comment. Add additional test as Alexey asked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D145093: Add map info for dereference pointer.

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7489-7493 + if (UO && UO->getOpcode() == UO_Deref) +if (isa(Last->getAssociatedExpression()) || +isa(Last->getAssociatedExpression()) ||

[PATCH] D145093: Add map info for dereference pointer.

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 502144. jyu2 added a comment. Thanks Alexey for the code review. I removed loop by using last expression in the component for checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7487-7497 + auto TNext = Next; + bool IsVarDerefAssoWithArray = false; + if (UO && UO->getOpcode() == UO_Deref) +for (; TNext != CE; TNext = std::next(TNext)) + if

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. > Yes, I understand. And did not ask for it. I just mean that a[0][:3] emits > different mapping data - TARGET_PAPARM|TO|FROM, PTR_AND_OBJ|TO|FROM Oh I see. I was think alloc for adding pointer. But I now think I should just orignal maptype. Changed thanks.

[PATCH] D145093: Add map info for dereference pointer.

jyu2 updated this revision to Diff 501921. jyu2 added a comment. Thanks Alexey for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145093/new/ https://reviews.llvm.org/D145093 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. > I mean we shall emit the same mapping for `(*a)[:3]` and for `a[0][:3]` Yes I mean emit (*a)[:3] as a[0][:3] The difficulty is during the process array section of OMPArraySectionExpr 0x12aa37e0 '' lvalue | -ImplicitCastExpr 0x12a8a918 'int *' | | `-ArraySubscriptExpr

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added a comment. In D145093#4164528 , @ABataev wrote: > What result produces `map(a[0][:3]`? Yes, that would be another way to fix the runtime problem. However the difficulty is when process array section, section base is different. with a[0][:3]

[PATCH] D145093: Add map info for dereference pointer.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_map_deref_array_codegen.cpp:17 +(*t1d)[j] = 1; + #pragma omp target map(to: (*t1d)[0:3]) +(*t1d)[2] = 2; ABataev wrote: > Is this correct at all? This is not a pointer to the array, it is

[PATCH] D145093: Add map info for dereference pointer.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. This is to fix run

[PATCH] D144616: Skip generating this[:1] map info for non-member variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b72a3276243: Skip using this[:1] map info for non-member variable. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144616/new/

[PATCH] D144616: Skip generating this[:1] map info for non-member variable.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. This fix runtime

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. Hi @sandeepkosuri, do you plan to fix this? Thanks. Jennifer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127855/new/ https://reviews.llvm.org/D127855 ___ cfe-commits mailing

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

jyu2 added a comment. That part of code is original add for is_device_address, so I just wonder, if the change could break is_device_address? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

jyu2 added a comment. In D127855#3956014 , @sandeepkosuri wrote: > As I do not have commit access, can someone commit this patch, now that it > passes the pre-merge tests ? I see some tests failed after this patch. Failed only with -fopenmp-vesion=51

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe29a1695a6c: This is to fix runtime problem for member data used in target region. (authored by jyu2). Changed prior to commit:

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490 +if (MD) + if (const CXXRecordDecl *RD = dyn_cast(MD->getParent())) +HasBaseClass = RD->getNumBases() > 0; ABataev wrote: > `const auto *RD =

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 updated this revision to Diff 487845. jyu2 added a comment. Thanks Alexey for code review. This is to address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 Files:

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added a comment. In D141350#4038619 , @ye-luo wrote: > Does this patch work when there are more than one level of inheritance? For > example `class B: public A; class C: public B` Yes, that works. For that we emit this[:1] instead. I can add

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added a project: clang. The problem is

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf781f704239: [OPENMP51]Codegen for error directive. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc =

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 updated this revision to Diff 481319. jyu2 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc =

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction , SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc =

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

jyu2 closed this revision. jyu2 added a comment. checked with 9d90cf2fca44 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138312/new/ https://reviews.llvm.org/D138312

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11048 SeverityClauses.empty() ? nullptr : (*SeverityClauses.begin()); + auto MessageClauses = + OMPExecutableDirective::getClausesOfKind(Clauses); ABataev wrote: > Use real type

[PATCH] D138312: [OPENMP5.1] Initial support for message clause.

jyu2 updated this revision to Diff 476534. jyu2 added a comment. Thanks Alexey for the review. Address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138312/new/ https://reviews.llvm.org/D138312 Files:

  1   2   3   4   >