[PATCH] D159465: Add index test with unconstrained auto.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without the fix in

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d2e756dacfd: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159450: Initialize `ConceptReference` of new `AutoTypeLoc` with nullptr.

massberg created this revision. massberg added a reviewer: sammccall. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159450

[PATCH] D159309: [ASTMatchers] basic matcher support for ConceptReference

massberg added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:2545 }; -dependentSizedArrayType() +dependentSizedArrayType matches "T data[Size]" Was this change to drop the () by purpose? Comment at:

[PATCH] D159300: [AST] Support ConceptReference in DynTypedNode, add dump().

massberg accepted this revision. massberg added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159300/new/ https://reviews.llvm.org/D159300

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc39dcd2c2bc7: [c++20][clangd] Simplify code using the new `ConceptReference` nodes. (authored by massberg). Repository: rG LLVM Github Monorepo

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg updated this revision to Diff 554985. massberg marked an inline comment as done. massberg added a comment. Use VisitConceptReference instead of TraverseConceptReference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159268/new/

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D155858: Add a concept AST node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2bf9baf5987: Add a concept AST node. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554743. massberg marked 7 inline comments as done. massberg added a comment. Fixed remaining nits. Thanks for the reviews and comments everyone! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/

[PATCH] D155858: Add a concept AST node.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size]; +

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554660. massberg marked 3 inline comments as done. massberg added a comment. Resolve remaining comments. - Added tests for new location functions of `ConceptReference`. There is an existing bug with the end location if there are no template arguments. As

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 554257. massberg marked 7 inline comments as done. massberg added a comment. Resolve more of the open comments. - add `getBeginLoc()`, `getEndLoc()` and `getSourceRange()` to `ConceptReference` and updated corresponding functions in

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552742. massberg marked 4 inline comments as done. massberg added a comment. Resolved the next round of comments. There are still some left to be addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155858: Add a concept AST node.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:6824-6836 + unsigned size = TL.getTypePtr()->getTypeConstraintArguments().size(); + TemplateArgumentLocInfo *TALI = new TemplateArgumentLocInfo[size];

[PATCH] D155858: Add a concept AST node.

massberg marked 13 inline comments as done. massberg added a comment. I have resolved some of the comments, but I need another round to finish all of the, Thanks to all reviewers so far! Comment at: clang/include/clang/AST/ExprConcepts.h:90 + // NOTE(massberg): For the first

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552307. massberg added a comment. Resolve some of the reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/ https://reviews.llvm.org/D155858 Files:

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 549066. massberg marked an inline comment as done. massberg added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Only call `AddConceptReference` if there is a concept reference. Repository: rG LLVM Github

[PATCH] D155858: Add a concept AST node.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang/include/clang/AST/ASTConcept.h:118 /// template arguments. -class ConceptReference { +class ConceptLoc { protected: cor3ntin wrote: > hokein wrote: > > I'm not sure

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 547804. massberg edited the summary of this revision. massberg added a comment. Rename `ConceptLoc` back to `ConceptReference`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/new/

[PATCH] D156867: [clang] Add a concept AST nodes.

massberg abandoned this revision. massberg added a comment. Abandon this revision in favor of https://reviews.llvm.org/D155858 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156867/new/ https://reviews.llvm.org/D156867

[PATCH] D155858: Add a concept AST node.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: ChuanqiXu, martong. Herald added a reviewer: shafik. Herald added a project: All. massberg updated this revision to Diff 544722. massberg added a comment. massberg updated this revision to Diff 545601.

[PATCH] D156867: [clang] Add a concept AST nodes.

massberg added a comment. @erichkeane Hi Erich, we would like to add an AST node for concepts (see description above) and we are interested in your opinion on the high level design.. This patch is a draft of what the new AST node could look like and how it would be part of the existing

[PATCH] D156867: Add a concept AST nodes.

massberg created this revision. massberg added reviewers: hokein, sammccall, erichkeane. Herald added subscribers: ChuanqiXu, kadircet, martong. Herald added a reviewer: shafik. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

This revision was automatically updated to reflect the committed changes. Closed by commit rG8af016aefd83: [clangd][c++20] Add concept semantic highlighting test case (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155581/new/

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9ab43dd44ca: [clangd][c++20] Add concept Hover tests. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155558: [clangd][c++20] Add concept Hover tests.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg added inline comments. Comment at: clang/unittests/AST/SourceLocationTest.cpp:274 + + Verifier.expectRange(2, 11, 2, 31); + EXPECT_TRUE(Verifier.match("template concept Fooable = true;\n" massberg wrote: > This range looks a bit to long. What I'm

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:562 )cpp"; - EXPECT_DECLS("ConceptSpecializationExpr", + EXPECT_DECLS("TemplateTypeParmTypeLoc", {"template concept Fooable = true"}); This

[PATCH] D155460: [clang][clangd][c++20] Improve support of type constraints in TemplateTypeParms.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, kristof.beyls. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg updated this revision to Diff 538952. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154853/new/ https://reviews.llvm.org/D154853 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec9e2048024: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154623: [clangd][c++20]Check for correct auto location in DeducedTypeVisitor

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

This revision was automatically updated to reflect the committed changes. massberg marked an inline comment as done. Closed by commit rG8af9a373ad95: Add missing semantic highlighing for concepts. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:969 + if (ATL.isConstrained()) { + StartLoc = ATL.getConceptNameInfo().getEndLoc().getLocWithOffset(1); + }

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg updated this revision to Diff 537643. massberg added a comment. Directly get correct source loc in case of deduced auto types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ https://reviews.llvm.org/D154580 Files:

[PATCH] D154580: [clangd][c++20]Add missing semantic highlighing for concepts.

massberg updated this revision to Diff 537642. massberg added a comment. Set correct token for deduced auto types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154580/new/ https://reviews.llvm.org/D154580 Files:

[PATCH] D154580: Add missing semantic highlighing for concepts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1af0e34477a3: [clangd][c++20] Drop first template argument in code completion in some… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537163. massberg marked 2 inline comments as done. massberg added a comment. Add test case that isn't correctly handled yet and add FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg marked 7 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:327 +return ""; + return "<" + Signature.substr(FirstComma + 2); +} sammccall wrote: > I don't love the arithmetic, the

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537161. massberg added a comment. Update code by resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ https://reviews.llvm.org/D154450 Files:

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f065bfd633d: [clangd][c++20]Consider rewritten binary operators in TargetFinder (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 533211. massberg marked an inline comment as done. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files:

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover, RewrittenBinaryOperatorSpaceshipMassberg) { + Annotations T(R"cpp( sammccall wrote: > massberg wrote: >

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 533204. massberg marked 2 inline comments as done. massberg added a comment. Switched the "Hover, All" test to run with C++20 instead of C++17 and moved the RewrittenBinaryOperatorSpaceship test to it. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments, I have added an additional test to FindTargetTest. See also my other comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover,

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532921. massberg added a comment. Add test to FindTargetTests and extend test in HoverTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files:

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg updated this revision to Diff 532867. massberg added a comment. Fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

massberg created this revision. massberg added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In C++20

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a7ca8036058: Fix parameter name in Sema::addInitCapture to ByRef. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg updated this revision to Diff 529312. massberg added a comment. Fix formatting (once again). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https://reviews.llvm.org/D139541 Files: clang/include/clang/Sema/Sema.h

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg updated this revision to Diff 529293. massberg added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https://reviews.llvm.org/D139541 Files: clang/include/clang/Sema/Sema.h

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg updated this revision to Diff 529277. massberg added a comment. Use correct format for burprone-argument-comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139541/new/ https://reviews.llvm.org/D139541 Files:

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. Any advice how I should proceed here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 ___ cfe-commits mailing list

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

This revision was automatically updated to reflect the committed changes. Closed by commit rG593a2740f7a4: [clang] Show error if defaulted comparions operator function is volatile or has… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 529231. massberg added a comment. Format code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 529216. massberg added a comment. Fix status of paper in status page to unreleased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files:

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg added a comment. In D148924#4391190 , @ilya-biryukov wrote: > @massberg did we figure out if there is anything else left from P2002R1? Are > there blockers to landing this? The only thing I came across was https://reviews.llvm.org/D151200

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparison operator aren't as expected.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3c0774b1d6e: [Clang][C++20] Error out if parameter types of a defaulted comparion operator… (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg updated this revision to Diff 524704. massberg added a comment. Also error out if the comparion operator has a single parameter that isn't a const reference. See also https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2002r1.html on how it shpuld behave in C++20. Repository:

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg added a comment. I just realized that we should probably also enable the other check (err_defaulted_comparison_param) for dependent types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151200/new/ https://reviews.llvm.org/D151200

[PATCH] D151200: [Clang][C++20] Error out if parameter types of a defaulted comparion operator are not all the same.

massberg created this revision. massberg added a reviewer: usaxena95. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes #62880 Repository: rG LLVM Github Monorepo

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg added a comment. I have checked the paper P2002R1 and as far as I can tell it is fully implemented when this patch has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 519432. massberg added a comment. Fix test that broke after last change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 519042. massberg marked an inline comment as done. massberg added a comment. Fixed typo, added release note and updated cxx_status.html. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/

[PATCH] D149649: Update comment.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [class.rel] has been renamed to [class.compare.secondary]. Repository: rG

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg marked 5 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8593 +const FunctionProtoType *FnType = FD->getType()->castAs(); +if (FnType->isVolatile()) { aaron.ballman wrote: > aaron.ballman

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg updated this revision to Diff 517489. massberg added a comment. Updated errort messages, code and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148924/new/ https://reviews.llvm.org/D148924 Files:

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implemed the change proposed in [P2002R1] to 11.11.1

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto

[PATCH] D141671: Move definitions to prevent incomplete types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf88c6b9166f8: Move definitions to prevent incomplete types. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141671: Move definitions to prevent incomplete types.

massberg added a comment. I have updated the code. It turned out that much less code has to be moved than I initially thought. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg updated this revision to Diff 488976. massberg added a comment. Clean up code and only mode definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141671/new/ https://reviews.llvm.org/D141671 Files:

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg added a comment. > Having as few code in headers as possible is the general style guide in LLVM, > so I'd rather err towards that and put definitions out-of-line as much as > possible. Therefore if we can getaway by just moving definitions out-of-line, > while keeping rest of the

[PATCH] D141671: Move around structs and definitions to prevent incomplete types.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C++20 is more strict when erroring out due to incomplete types.

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg marked 2 inline comments as done. massberg added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:11 +#include // massberg #include "TreeTransform.h" shafik wrote: > Please remove. Ups, thanks! Comment at:

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 482140. massberg added a comment. Additionally check for ODR use and remove inlcude added by accident. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files:

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. In D139400#3974624 , @shafik wrote: > It looks like we have an existing message for the regular function case Thanks! We can indeed reuse this error message. In D139400#3974654 ,

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 481295. massberg added a comment. Reuse existing error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 481264. massberg added a comment. Use isLocalVarDecl to check if we have a local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files:

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename parameter in Sema::addInitCapture as proposed in review of

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedbea62f72f7: [clang] Correctly handle by-reference capture with an initializer that is a… (authored by massberg). Repository: rG LLVM Github

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. In D139400#3974654 , @shafik wrote: > It looks like the existing diagnostic is issued by > `CheckDefaultArgumentVisitor`. I think you can reuse it here but not 100% on > that. Thanks for the pointer! I will have a look.

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType,

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480800. massberg added a comment. Simplify code and update description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://reviews.llvm.org/D139125 Files: clang/include/clang/Sema/Sema.h

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480518. massberg added a comment. Instead of lokking if there is a pack expansion pass the already computed information whether we have a by ref or a by copy type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480475. massberg added a comment. Moved check if we have a pack expansion with reference type to Sema::BuildLambdaExpr. I'm still not sure if this is the right place, or if `From.isCopyCapture()` should be `false` for pack expansions with refernece types.

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType,

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 480369. massberg added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I haven't found an existing error message for this in

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType,

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 479581. massberg added a comment. Remove unnecessary code from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://reviews.llvm.org/D139125 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 479579. massberg added a comment. Add a diagnostics test for pack expansions to check if args are passed by reference and not by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a new init capture type for a lamdba expression is created, one has to

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG849b650cf3b6: [clang] Skip defaulted functions in zero-as-null-pointer-constant. (authored by massberg). Repository: rG LLVM Github Monorepo

[PATCH] D138727: [clang] Skip defaulted functions in zero-as-null-pointer-constant.

massberg added a comment. Note: The build failures are in parts of the code that isn't effected by this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138727/new/ https://reviews.llvm.org/D138727

  1   2   >