[PATCH] D143094: [clang] Change AMX macros to match names from GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rG8998fa6c14f1: [clang] Change AMX macros to match names from GCC (authored by jloser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143094/new/

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

jloser added a comment. In D143094#4098208 , @LuoYuanke wrote: > LGTM, thanks Thanks for the review. Do I need to wait for another approver before landing this? I mostly work on `libc++`, so not too familiar with expectations on Clang reviews, or

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

jloser updated this revision to Diff 494008. jloser added a comment. Update commit message to properly display the #define Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143094/new/ https://reviews.llvm.org/D143094 Files:

[PATCH] D143094: [clang] Change AMX macros to match names from GCC

jloser created this revision. jloser added reviewers: yubing, LuoYuanke, pengfei, craig.topper. Herald added a project: All. jloser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current behavior for AMX macros is: gcc

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); serge-sans-paille wrote: > random nit: This could be rewritten as > > ``` >

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa288d7f93770: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides (authored by jloser). Changed prior to commit:

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser created this revision. jloser added reviewers: MaskRay, serge-sans-paille, dblaikie. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, foad, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo,

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. Sorry for the delay here; this patch LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ cfe-commits mailing list

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. I'm +1 for the direction here; I took a brief look but will look closely either later tonight or tomorrow before I approve. Thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

jloser added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15908 - llvm::TimeTraceScope TimeScope("isIntegerConstantExpr", [&] { -return Loc->printToString(Ctx.getSourceManager()); - }); + ExprTimeTraceScope TimeScope(this, Ctx, "isIntegerConstantExpr");

[PATCH] D136549: [clang] Fix time profile in "isIntegerConstantExpr"

jloser accepted this revision. jloser added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix. I did leave an open question or two though, but it is non-blocking. Comment at: clang/lib/AST/ExprConstant.cpp:15908 - llvm::TimeTraceScope

[PATCH] D136022: [clang] Add time profile for constant evaluation

jloser added a comment. I like the idea of this — +1 for the direction. I'd like to see some tests through before I approve. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136022/new/ https://reviews.llvm.org/D136022

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

jloser closed this revision. jloser added a comment. This landed with https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. The revision didn't auto-close for some reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

jloser created this revision. jloser added reviewers: RKSimon, nikic, fhahn. Herald added a project: All. jloser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The docs mention that `__builtin_reduce_add` and `__builtin_reduce_mul`

[PATCH] D133520: [clang] Use std::size instead of llvm::array_lengthof

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b3a78d1d534: [clang] Use std::size instead of llvm::array_lengthof (authored by jloser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133520/new/

[PATCH] D133520: [clang] Use std::size instead of llvm::array_lengthof

jloser created this revision. jloser added reviewers: MaskRay, kazu, dblaikie, aaron.ballman. Herald added subscribers: mattd, gchakrabarti, asavonic, StephenFan. Herald added a project: All. jloser requested review of this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added

[PATCH] D131935: [clang][llvm][NFC] Change misexpect's tolerance option to be 32-bit

jloser accepted this revision. jloser added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the follow-up cleanup. I'll rebase once this lands to avoid the cast in https://reviews.llvm.org/D131869 if that works for you. Repository: rG LLVM Github Monorepo

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8578968f684: [ADT] Replace STLForwardCompat.hs C++17 equivalents (authored by joe_loser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131717/new/

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser updated this revision to Diff 452022. jloser added a comment. Fix unqualified use of `in_place` so the delegating constructor in `Optional` calls the one taking the `std::in_place_t` tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser added a comment. In D131717#3717363 , @MaskRay wrote: > The llvm/include/llvm/ADT/STLForwardCompat.h and > llvm/unittests/ADT/STLForwardCompatTest.cpp removal can be in a separate > patch. Sure. I just split them out of this patch and I'll do

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser updated this revision to Diff 451977. jloser added a comment. Revert removal of these utilities and type traits from STLForwardCompat.h and their corresponding unit tests. The removal of these will be done in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser created this revision. jloser added reviewers: scott.linder, MaskRay, bkramer, zero9178, dblaikie. Herald added a subscriber: StephenFan. Herald added a project: All. jloser requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D99134: Lambdas are not necessarily locals. This resolves DR48250.

jloser added a comment. Would love to see this cherry-picked into the llvm 14 release branch if possible! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99134/new/ https://reviews.llvm.org/D99134 ___

[PATCH] D45677: [libcxx] [test] Fix typo in filesystem test

jloser added a comment. Jim, thanks for accepting the review. Do you mind landing this on my behalf? I don't have commit rights. Thanks! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45677/new/ https://reviews.llvm.org/D45677

[PATCH] D45677: [libcxx] [test] Fix typo in filesystem test

jloser created this revision. jloser added a reviewer: EricWF. Herald added subscribers: cfe-commits, christof. There was a typo in "omitted" in `/test/std/experimental/filesystem/fs.op.funcs/fs.op.relative/relative.pass.cpp ` Repository: rCXX libc++ https://reviews.llvm.org/D45677 Files:

[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

jloser added a comment. In https://reviews.llvm.org/D44411#1056374, @EricWF wrote: > Have you verified that we're not losing test coverage here? That is, are you > sure we still have tests for the rvalue overloads in other test files? Yep. These containers already have tests for inserts with

[PATCH] D44411: [libcxx] [test] Fix Container::insert(value_type const&) tests

jloser updated this revision to Diff 141573. jloser added a comment. Use `v3` rather than an rvalue of `3` in `libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp` https://reviews.llvm.org/D44411 Files: libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp

[PATCH] D44411: [libc++] Fix Container::insert(value_type const&) tests

jloser created this revision. jloser added reviewers: EricWF, matthew. Herald added subscribers: cfe-commits, christof. [libc++] Fix Container::insert(value_type const&) tests Several unit tests meaning to test the behavior of lvalue insertion incorrectly pass rvalues. Fixes bug 27394.