Author: joey
Date: Wed Aug 9 07:52:47 2017
New Revision: 310477
URL: http://llvm.org/viewvc/llvm-project?rev=310477=rev
Log:
[OpenCL] Minor refactoring to reduce copy/pasted code
Set the type of TheCall inside SemaBuiltinReserveRWPipe to reduce
duplicated code.
Modified:
Author: joey
Date: Tue Aug 1 06:27:09 2017
New Revision: 309678
URL: http://llvm.org/viewvc/llvm-project?rev=309678=rev
Log:
[OpenCL] Add missing subgroup builtins
This adds get_kernel_max_sub_group_size_for_ndrange and
get_kernel_sub_group_count_for_ndrange.
Modified:
Author: joey
Date: Mon Jul 31 08:50:27 2017
New Revision: 309571
URL: http://llvm.org/viewvc/llvm-project?rev=309571=rev
Log:
[OpenCL] Enable subgroup extension in tests
This fixes the test, so that it can be run on different hosts that may have
different OpenCL extensions enabled.
Modified:
Author: joey
Date: Mon Jul 31 08:15:59 2017
New Revision: 309567
URL: http://llvm.org/viewvc/llvm-project?rev=309567=rev
Log:
[OpenCL] Add extension Sema check for subgroup builtins
Check the subgroup extension is enabled, before doing other Sema checks.
Modified:
Author: joey
Date: Tue Jul 4 04:50:23 2017
New Revision: 307067
URL: http://llvm.org/viewvc/llvm-project?rev=307067=rev
Log:
[OpenCL] Rename err_opencl_enqueue_kernel_expected_type
Rename err_opencl_enqueue_kernel_expected_type so that other builtins
can use the same diagnostic.
Author: joey
Date: Fri Jun 30 07:23:01 2017
New Revision: 306827
URL: http://llvm.org/viewvc/llvm-project?rev=306827=rev
Log:
[OpenCL] Add function name to extension diagnostic
Slightly improve the diagnostic by including the function name.
Modified:
Author: joey
Date: Fri Feb 10 09:51:11 2017
New Revision: 294754
URL: http://llvm.org/viewvc/llvm-project?rev=294754=rev
Log:
[libclang] [OpenCL] Expose half type.
Expose the half type (fp16) through libclang and the python bindings.
It seems CXType_LastBuiltin was not updated in b2ea6d9
Author: joey
Date: Thu Dec 1 05:30:49 2016
New Revision: 288332
URL: http://llvm.org/viewvc/llvm-project?rev=288332=rev
Log:
[OpenCL] Refactor read_only/write_only pipes.
This adds the access qualifier to the Pipe Type, rather than using a class
hierarchy.
It also fixes mergeTypes for Pipes,
joey created this revision.
joey added reviewers: yaron.keren, bader.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
This patch to keep the pipe access qualifier inside PipeType itself looks
cleaner overall than my
RTTI.html
>
> Good example is how ConstantArrayType, IncompleteArrayType,
> VariableArrayType, DependentSizedArrayType inherit from ArrayType.
>
> Yaron
>
>
>
> 2016-11-18 16:10 GMT+02:00 Joey Gouly via cfe-commits
> <cfe-commits@lists.llvm.org>:
>>
>>
joey closed this revision.
joey marked 3 inline comments as done.
joey added a comment.
Committed as r287343.
Repository:
rL LLVM
https://reviews.llvm.org/D26746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: joey
Date: Fri Nov 18 08:10:54 2016
New Revision: 287343
URL: http://llvm.org/viewvc/llvm-project?rev=287343=rev
Log:
[OpenCL] Introduce ReadPipeType and WritePipeType.
This allows Sema to diagnose passing a read_only pipe to a
write_only pipe argument.
Modified:
joey created this revision.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
Split the PipeType into two derived classes. This allows Sema to diagnose
passing read_only to write_only and vice versa.
Repository:
rL
joey closed this revision.
joey added a comment.
Committed as r287100.
Comment at: test/SemaOpenCL/access-qualifier.cl:71
+
+#if __OPENCL_C_VERSION__ >= 200
+void myPipeWrite(write_only pipe int); // expected-note {{passing argument to
parameter here}}
This
Author: joey
Date: Wed Nov 16 05:34:09 2016
New Revision: 287100
URL: http://llvm.org/viewvc/llvm-project?rev=287100=rev
Log:
[OpenCL] Use the semantic spelling of the Access attribute, rather than a
string.
Also fix a latent bug, due to an incorrect traversal of the AttributeList.
joey marked an inline comment as done.
joey added inline comments.
Comment at: lib/Sema/SemaType.cpp:1224
}
- return "";
+ return OpenCLAccessAttr::Keyword_read_only;
}
aaron.ballman wrote:
> The caller can no longer tell the difference between a real-only
joey updated this revision to Diff 78017.
joey added a comment.
Fixed a latent infinite loop bug in 'getImageAccess', it was dereferencing
Attrs, instead of Next.
Repository:
rL LLVM
https://reviews.llvm.org/D26668
Files:
lib/Sema/SemaType.cpp
test/SemaOpenCL/access-qualifier.cl
joey created this revision.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
Use the semantic spelling (an enum) rather than a string, to determine what
access qualifier is used.
Repository:
rL LLVM
joey added a comment.
Two minor comments, but otherwise LGTM!
Comment at: include/clang/Basic/OpenCLOptions.h:33
// Enable all options.
+ void setAll(bool Enable = true) {
This comment needs to be changed, to reflect that they are now all enabled or
joey added a subscriber: joey.
Comment at: lib/CodeGen/CodeGenModule.cpp:101
@@ -100,3 +100,3 @@
DoubleTy = llvm::Type::getDoubleTy(LLVMContext);
PointerWidthInBits = C.getTargetInfo().getPointerWidth(0);
PointerAlignInBytes =
What if you create a new
Author: joey
Date: Wed Aug 10 11:04:14 2016
New Revision: 278235
URL: http://llvm.org/viewvc/llvm-project?rev=278235=rev
Log:
[OpenCL] Fix typo in test that I accidentally introduced in my previous commit.
Modified:
cfe/trunk/test/CodeGenOpenCL/cl20-device-side-enqueue.cl
Modified:
Author: joey
Date: Wed Aug 10 10:57:02 2016
New Revision: 278234
URL: http://llvm.org/viewvc/llvm-project?rev=278234=rev
Log:
[OpenCL] Change block descriptor address space to constant.
The block descriptor is a GlobalVariable in the LLVM IR, so it shouldn't be
in the private address space.
joey accepted this revision.
joey added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D17578
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
23 matches
Mail list logo
