[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-05-22 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: The LLDB bots are still failing: https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/4342/ https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/2244/ https://github.com/llvm/llvm-project/pull/92885

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-21 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/92953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-21 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: No objections in the context of LLDB. We don't use terminfo directly (although I think editline does, but that isn't affected by this) and if we want the TUI we depend on curses anyway. https://github.com/llvm/llvm-project/pull/92865

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-17 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: > It's a `sed s/== None/is None/g` - what is there to review? 10 separate > commits/PRs for the same exact `sed` costs more in commit noise (and effort > on the part of @e-kwsm) than one solid, patient, review here. In addition to what @ftynse said above, the `sed` might

[clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere commented: This should really be broken up into separate PRs per subproject. One large PR like this makes reviewing harder and causes unnecessary churn in the case that this gets reverted. https://github.com/llvm/llvm-project/pull/91857

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-16 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: I don't think Alex is arguing in favor of keeping the old (wrong) behavior, but the first file looks like this: ``` foundSpec = False if [...] foundSpec = True [...] if foundSpec is False: ``` It's pretty obvious this is a boolean and should use `if not foundSpec`.

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-14 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere requested changes to this pull request. As per Aiden's suggestion, please split this up into smaller PRs, grouped by subproject. https://github.com/llvm/llvm-project/pull/91856 ___ cfe-commits mailing list

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-14 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: > If this is split out from the other larger PR, should there be `clang/` > changes in here? +1, please unstage the `clang` and `openmp` changes. https://github.com/llvm/llvm-project/pull/91858 ___ cfe-commits mailing list

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

2024-04-24 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: Right, my point is that (I think) that doesn't make sense. AFAIK `addMinVersionArgs` is called exclusively from the code snippet I pasted, which should check the linker version. The version of `ld` in which this changed is much newer than the 520 referenced there. I'd

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

2024-04-24 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Rename -macosx_version_min to -macos_version_min (PR #88810)

2024-04-24 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere requested changes to this pull request. We should be using `-platform-version` for newer versions of the linker. How are we ending up in this code path? https://github.com/llvm/llvm-project/pull/88810 ___ cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: This looks like a nice improvement for folks using those generators. Even though most of these changes look straightforward, it would be a lot easier to review if this was broken up per subproject. Is there any reason that's not possible?

[clang] [lldb] [llvm] [mlir] [lldb][Core] Remove pointless condition (PR #89480)

2024-04-19 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere requested changes to this pull request. +1 on what Cyndy said. The lldb change itself looks fine. https://github.com/llvm/llvm-project/pull/89480 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [lldb] [llvm] Apply modernize-use-starts-ends-with on llvm-project (PR #89140)

2024-04-19 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [lldb] [llvm] Apply modernize-use-starts-ends-with on llvm-project (PR #89140)

2024-04-19 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. LLDB & VFS change LGTM. https://github.com/llvm/llvm-project/pull/89140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [lldb][test] Remove LLDB_TEST_USE_VENDOR_PACKAGES (PR #89260)

2024-04-18 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] NFC: Make clang resource headers an interface library (PR #88317)

2024-04-15 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: Hey @etcwilde, this breaks the Xcode standalone build for lldb: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-standalone/121/ The failing command in the generated script phase is: ``` cmake -E copy_directory

[clang] [lldb] [llvm] [cmake] Build executables with -no_exported_symbols when building Apple toolchain (PR #87684)

2024-04-05 Thread Jonas Devlieghere via cfe-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE option(LLVM_EXTERNALIZE_DEBUGINFO "Generate dSYM files and strip executables and libraries (Darwin Only)" OFF) +option(LLVM_ENABLE_EXPORTED_SYMBOLS JDevlieghere wrote: @delcypher I was referring to the tools in

[clang] [llvm] [driver] Make --version show if assertions, etc. are enabled (PR #87585)

2024-04-04 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. Thanks, this LGTM! https://github.com/llvm/llvm-project/pull/87585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [cmake] Build executables with -no_exported_symbols when building Apple toolchain (PR #87684)

2024-04-04 Thread Jonas Devlieghere via cfe-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE option(LLVM_EXTERNALIZE_DEBUGINFO "Generate dSYM files and strip executables and libraries (Darwin Only)" OFF) +option(LLVM_ENABLE_EXPORTED_SYMBOLS JDevlieghere wrote: "tools" has a pretty specific meaning for

[clang] [clang] Upstream visionOS Availability & DarwinSDKInfo APIs (PR #84279)

2024-03-07 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/84279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang-tools-extra] [compiler-rt] [llvm] [clang] [flang] [libc] LLDB Debuginfod usage tests (with fixes) (PR #79181)

2024-01-26 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere commented: I'm wondering if shell test are really the best way to test this. For more complex scenarios like are being tested here, we generally prefer [1] API tests because they're more expressive and allow you to build more complicated test binaries with our

[lldb] [clang] [flang] [libc] [llvm] [clang-tools-extra] [compiler-rt] LLDB Debuginfod usage tests (with fixes) (PR #79181)

2024-01-26 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/79181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [flang] [clang] [libc] [lldb] [clang-tools-extra] [llvm] LLDB Debuginfod usage tests (with fixes) (PR #79181)

2024-01-26 Thread Jonas Devlieghere via cfe-commits
@@ -0,0 +1,65 @@ +# Tests for basic Debuginfod functionality + +Because the Debuginfod protocol is a simple HTTP path-based system, one can +mimic a Debuginfod server by setting up a directory structure to reflect the +protocol properly. That's how all these tests operate. We

[clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/78392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [clang-tools-extra] [flang] [llvm] [lldb] [mlir] [clang] [lld] [libcxx] [DWARFLinker][NFC] Decrease DWARFLinker dependence on DwarfStreamer. (PR #77932)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
@@ -30,6 +30,20 @@ using namespace llvm; using namespace dwarf_linker; using namespace dwarf_linker::classic; +Expected> DwarfStreamer::createStreamer( +const Triple , DWARFLinkerBase::OutputFileType FileType, +raw_pwrite_stream , DWARFLinkerBase::TranslatorFuncTy

[clang] [flang] [lldb] [lld] [libcxx] [mlir] [compiler-rt] [clang-tools-extra] [llvm] [DWARFLinker][NFC] Decrease DWARFLinker dependence on DwarfStreamer. (PR #77932)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. Before this patch, the DWARFLinker was the one responsible for creating the streamer, which meant that both the classic and parallel implementation needed to conform to the same interface. After this patch, the concrete

[flang] [llvm] [compiler-rt] [lldb] [clang] [libcxx] [mlir] [lld] [clang-tools-extra] [DWARFLinker][NFC] Decrease DWARFLinker dependence on DwarfStreamer. (PR #77932)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/77932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/78392 >From 52ff81ffbce596fd89b296e7f4199be13f9402ff Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 16 Jan 2024 20:36:47 -0800 Subject: [PATCH 1/2] [clang] Upstream XROS support in Clang Upstream

[clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/78392 >From d7c431e0fbc0ad006b9d37a4e3a43c61ce1f50b7 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 16 Jan 2024 20:36:47 -0800 Subject: [PATCH] [clang] Upstream XROS support in Clang Upstream XROS

[lldb] [clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-17 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/78392 >From 6f6d93b6cc413d54dbdec05f30ede00ffdb4 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 10 Jan 2024 17:35:47 -0800 Subject: [PATCH 1/2] [lldb] Upstream xros support in lldb Upstream

[clang] [clang] Upstream XROS support in Clang (PR #78392)

2024-01-16 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/78392 Upstream XROS support in the clang frontend and driver. >From 1e65420f87eed1f7f4380496f96eef2560a15cb0 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 16 Jan 2024 20:36:47 -0800 Subject:

[llvm] [clang-tools-extra] [lldb] [clang] [lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (PR #73067)

2024-01-08 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/73067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang-tools-extra] [compiler-rt] [mlir] [llvm] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/77216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [compiler-rt] [llvm] [mlir] [clang-tools-extra] [clang] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Jonas Devlieghere via cfe-commits
@@ -108,13 +108,9 @@ else() linux/HostInfoLinux.cpp linux/LibcGlue.cpp linux/Support.cpp + android/HostInfoAndroid.cpp + android/LibcGlue.cpp ) -if (CMAKE_SYSTEM_NAME MATCHES "Android") JDevlieghere wrote: While Android

[clang] [mlir] [llvm] [compiler-rt] [lldb] [clang-tools-extra] Fix Multiple Build Errors on different platforms (PR #77216)

2024-01-06 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/77216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM][DWARF] Add support for monolithic types in .debug_names (PR #70512)

2023-10-27 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/70512 >From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Thu, 5 Oct 2023 12:39:02 -0700 Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-16 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. I like how this centralizes everything in a single place and the def file format seems like a natural fit for the platforms. https://github.com/llvm/llvm-project/pull/69262 ___ cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2023-09-08 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fc60bf2 - [DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms

2023-06-14 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2023-06-14T15:28:33-07:00 New Revision: fc60bf2de11149d2c027d63e7ad5a98afa6fab80 URL: https://github.com/llvm/llvm-project/commit/fc60bf2de11149d2c027d63e7ad5a98afa6fab80 DIFF:

[clang] 04c0161 - Revert "[DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms"

2023-06-14 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2023-06-14T14:16:16-07:00 New Revision: 04c0161c027676119fdc617f5b883dbda97c8549 URL: https://github.com/llvm/llvm-project/commit/04c0161c027676119fdc617f5b883dbda97c8549 DIFF:

[clang] e0d5729 - [DebugInfo] Always emit `.debug_names` with DWARF 5 for Apple platforms

2023-06-14 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2023-06-14T13:03:31-07:00 New Revision: e0d57295bf6a3c04f2901d9c70f529d570f48b65 URL: https://github.com/llvm/llvm-project/commit/e0d57295bf6a3c04f2901d9c70f529d570f48b65 DIFF:

[clang] 97b9130 - [clang] Disable assertion that can "easily happen"

2022-10-19 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2022-10-19T15:08:56-07:00 New Revision: 97b91307b00e958bc1d511c93a8a6bef510485ac URL: https://github.com/llvm/llvm-project/commit/97b91307b00e958bc1d511c93a8a6bef510485ac DIFF:

[clang] a262f4d - Revert "[Clang] Add a warning on invalid UTF-8 in comments."

2022-07-12 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2022-07-12T15:22:29-07:00 New Revision: a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437 URL: https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437 DIFF:

[clang] c7fd751 - Revert "[C++20][Modules] Update handling of implicit inlines [P1779R3]"

2022-07-11 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2022-07-11T13:59:41-07:00 New Revision: c7fd7512a5c5b133665bfecbe2e9748c0607286e URL: https://github.com/llvm/llvm-project/commit/c7fd7512a5c5b133665bfecbe2e9748c0607286e DIFF:

[clang] df6fcef - Fix the implicit module build (2/2)

2022-03-14 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2022-03-14T09:43:13-07:00 New Revision: df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9 URL: https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9 DIFF:

[clang] f51d7e4 - Fix the implicit module build

2022-03-14 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2022-03-14T09:24:17-07:00 New Revision: f51d7e4bae9e861e711ad9711599456fc2f1bbca URL: https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca DIFF:

[clang] 4cb7929 - Revert "[clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block"

2021-12-06 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2021-12-06T09:34:53-08:00 New Revision: 4cb79294e8df8c91ae15264d1014361815d34a53 URL: https://github.com/llvm/llvm-project/commit/4cb79294e8df8c91ae15264d1014361815d34a53 DIFF:

[clang] 6331680 - Re-land "[Driver] Support default libc++ library location on Darwin"

2021-04-21 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2021-04-21T14:22:13-07:00 New Revision: 6331680ad2ad000fdaf7e72f3c1880c7908ffa25 URL: https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25 DIFF:

[clang] 05eeed9 - Revert "[Driver] Support default libc++ library location on Darwin"

2021-04-20 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2021-04-20T20:42:50-07:00 New Revision: 05eeed9691aeb3e0316712195b998e9078cdceb0 URL: https://github.com/llvm/llvm-project/commit/05eeed9691aeb3e0316712195b998e9078cdceb0 DIFF:

[clang] 27a909a - [Apple-stage2] Install FileCheck and yaml2obj in the toolchain

2020-10-20 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-10-20T13:46:44-07:00 New Revision: 27a909a24f99d4de40c4ce6553b9cd420b11c056 URL: https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056 DIFF:

Re: [clang] 849c605 - PR47792: Include the type of a pointer or reference non-type template

2020-10-11 Thread Jonas Devlieghere via cfe-commits
I've reverted this in ba2dff0159fcd1d2349bc610331914618ca9bc30 because it also caused a build failure when building a stage 2 clang: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24177/console FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o

[clang] ba2dff0 - Revert "PR47792: Include the type of a pointer or reference non-type template"

2020-10-11 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-10-11T20:16:46-07:00 New Revision: ba2dff0159fcd1d2349bc610331914618ca9bc30 URL: https://github.com/llvm/llvm-project/commit/ba2dff0159fcd1d2349bc610331914618ca9bc30 DIFF:

[clang] 6b742cc - [clang] Replace call to private ctor with ElementCount::getScalable (2/2)

2020-08-19 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-08-19T09:40:46-07:00 New Revision: 6b742cc48d91f35bfa98844d5add3655f33f8326 URL: https://github.com/llvm/llvm-project/commit/6b742cc48d91f35bfa98844d5add3655f33f8326 DIFF:

[clang] fc53bd6 - [clang] Replace call to private ctor with ElementCount::getScalable

2020-08-19 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-08-19T09:35:08-07:00 New Revision: fc53bd610ff95d2824617095bcf4976035b4cb9a URL: https://github.com/llvm/llvm-project/commit/fc53bd610ff95d2824617095bcf4976035b4cb9a DIFF:

[clang] a1f4e48 - [clang][docs] Add note about using `-flto` with `-g` on macOS

2020-06-30 Thread Jonas Devlieghere via cfe-commits
Author: Philippe Blain Date: 2020-06-30T09:33:20-07:00 New Revision: a1f4e48c4aca8c7339be2018926baf860a562f13 URL: https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13 DIFF:

[clang] df53f09 - Revert "PR46209: properly determine whether a copy assignment operator is"

2020-06-05 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-06-04T23:45:36-07:00 New Revision: df53f09056b0f6a91029cae5f1cdc941c21b URL: https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b DIFF:

Re: [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

2020-06-05 Thread Jonas Devlieghere via cfe-commits
Hey Richard, It appears this broke the lldb bots: http://lab.llvm.org:8011/builders/lldb-x86_64-debian http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/ It's hitting an assertion in llvm-project/clang/include/clang/AST/DeclCXX.h:887: Assertion

[clang] 70ad03d - Revert "Set the captures on a CXXRecordDecl representing a lambda closure type"

2020-06-05 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-06-04T23:45:36-07:00 New Revision: 70ad03d93818532ef19f149f8ff89bcd8af80163 URL: https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163 DIFF:

[clang] a94e08d - [StaticAnalyzer] Fix non-virtual destructor warning

2020-05-26 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-05-26T11:32:02-07:00 New Revision: a94e08d2e840a0e7ce032f59e9344bc49b5a54a1 URL: https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1 DIFF:

[clang] 56abcfa - Revert "[analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes"

2020-03-23 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-03-23T12:09:24-07:00 New Revision: 56abcfad70ee679ad95ab41d934491ebcaebdf7d URL: https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d DIFF:

[clang-tools-extra] 45e2c6d - [clang-tools-extra/clang-tidy] Mark modernize-make-shared as offering fixes

2020-03-05 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-03-05T21:45:20-08:00 New Revision: 45e2c6d956141618683d31a683d762aaf0e7168d URL: https://github.com/llvm/llvm-project/commit/45e2c6d956141618683d31a683d762aaf0e7168d DIFF:

[clang] 509e21a - [clang] Replace SmallStr.str().str() with std::string conversion operator.

2020-01-29 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-01-29T21:27:46-08:00 New Revision: 509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e URL: https://github.com/llvm/llvm-project/commit/509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e DIFF:

[clang] 43a1c80 - Fix another implicit conversion in the directory watcher

2020-01-28 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-01-28T15:28:22-08:00 New Revision: 43a1c80508d17fa42c78b690d426105eaa84c539 URL: https://github.com/llvm/llvm-project/commit/43a1c80508d17fa42c78b690d426105eaa84c539 DIFF:

[clang] 00d834e - Fix more implicit conversions

2020-01-28 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-01-28T15:19:27-08:00 New Revision: 00d834e08719c994f12b216c7eb17bbc0c976714 URL: https://github.com/llvm/llvm-project/commit/00d834e08719c994f12b216c7eb17bbc0c976714 DIFF:

r372672 - Revert "Support for DWARF-5 C++ language tags."

2019-09-23 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Sep 23 16:49:36 2019 New Revision: 372672 URL: http://llvm.org/viewvc/llvm-project?rev=372672=rev Log: Revert "Support for DWARF-5 C++ language tags." This reverts commit bf9c8ffb54943c6d77398adbedddf05ef9724007. Modified: cfe/trunk/include/clang/AST/DeclCXX.h

r371813 - Revert "For PR17164: split -fno-lax-vector-conversion into three different"

2019-09-12 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Thu Sep 12 22:16:59 2019 New Revision: 371813 URL: http://llvm.org/viewvc/llvm-project?rev=371813=rev Log: Revert "For PR17164: split -fno-lax-vector-conversion into three different" This breaks the LLDB build. I tried reaching out to Richard, but haven't gotten a

r368954 - [NFC] Update doc comment to fix warning.

2019-08-14 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Aug 14 20:59:30 2019 New Revision: 368954 URL: http://llvm.org/viewvc/llvm-project?rev=368954=rev Log: [NFC] Update doc comment to fix warning. This fixes the warning: parameter 'EnableNullFPSuppression' not found in the function declaration [-Wdocumentation]

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

2019-08-09 Thread Jonas Devlieghere via cfe-commits
The bot is a little special in that it has modules enabled. Maybe that explains it? Let me know if that doesn't work and I can try reproducing locally. On Fri, Aug 9, 2019 at 12:02 PM Gábor Horváth wrote: > > I reverted but I cannot reproduce this locally on a linux box. Is there any > way to

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

2019-08-09 Thread Jonas Devlieghere via cfe-commits
I think this is causing a stage2 failure: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/124/consoleFull#-95886206949ba4694-19c4-4d7e-bec5-911270d8a58c On Fri, Aug 9, 2019 at 10:41 AM Gabor Horvath via cfe-commits wrote: > > Author: xazax > Date: Fri Aug 9 10:42:41 2019 > New

r367271 - [DependencyCollector] Make maybeAddDependency virtual (NFC)

2019-07-29 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Jul 29 16:02:11 2019 New Revision: 367271 URL: http://llvm.org/viewvc/llvm-project?rev=367271=rev Log: [DependencyCollector] Make maybeAddDependency virtual (NFC) Make DependencyCollector::maybeAddDependency, just like its other methods, which I made virtual a

r366447 - [CMake] Don't set Python_ADDITIONAL_VERSIONS

2019-07-18 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Thu Jul 18 08:17:42 2019 New Revision: 366447 URL: http://llvm.org/viewvc/llvm-project?rev=366447=rev Log: [CMake] Don't set Python_ADDITIONAL_VERSIONS Until recently, Python_ADDITIONAL_VERSIONS was used to limit LLVM's Python support to 2.7. Now that both LLVM and

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-07 Thread Jonas Devlieghere via cfe-commits
Hi Leonard, My personal rule of thumb is that if I can fix it in something like 30 minutes or less, I'll leave the bot red and commit a fix. Otherwise I'll revert my change. The problem with leaving the bot red is that if something else breaks, that person doesn't get a signal, and issue start to

r360192 - Revert "[OpenMP][Clang] Support for target math functions"

2019-05-07 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue May 7 14:08:15 2019 New Revision: 360192 URL: http://llvm.org/viewvc/llvm-project?rev=360192=rev Log: Revert "[OpenMP][Clang] Support for target math functions" This commit appears to be breaking stage-2 builds on GreenDragon. The OpenMP wrappers for cmath and

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-07 Thread Jonas Devlieghere via cfe-commits
Hi Leonard, The test that is asserting is part of the debuginfo test. ( https://github.com/llvm-project/debuginfo-tests) The reason that it's only failing on the non-incremental bot is because the incremental one isn't running those, I believe. RA stands for Release/Asserts. Hope that helps!

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

2019-05-07 Thread Jonas Devlieghere via cfe-commits
Hi Leonard, It appears that your patch is still triggering an assertion on GreenDragon: http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/56255/consoleFull#312501878d489585b-5106-414a-ac11-3ff90657619c Can you please have a look? Thanks, Jonas On Mon, May 6, 2019 at 8:17 PM

r353882 - Make ModuleDependencyCollector's method virtual (NFC)

2019-02-12 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue Feb 12 13:45:14 2019 New Revision: 353882 URL: http://llvm.org/viewvc/llvm-project?rev=353882=rev Log: Make ModuleDependencyCollector's method virtual (NFC) For reproducers in LLDB we want to hook up into the existing clang infrastructure. To make that happen we

r352605 - [ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC)

2019-01-29 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue Jan 29 22:26:26 2019 New Revision: 352605 URL: http://llvm.org/viewvc/llvm-project?rev=352605=rev Log: [ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC) Use the real_path implementation from llvm::sys::fs::real_path instead of having a custom

r346675 - Revert "Make clang-based tools find libc++ on MacOS"

2018-11-12 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Nov 12 08:59:50 2018 New Revision: 346675 URL: http://llvm.org/viewvc/llvm-project?rev=346675=rev Log: Revert "Make clang-based tools find libc++ on MacOS" This breaks the LLDB bots. Removed: cfe/trunk/test/Tooling/Inputs/mock-libcxx/include/c++/v1/mock_vector

r346601 - Pass the function type instead of the return type to FunctionDecl::Create

2018-11-10 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Sat Nov 10 16:56:15 2018 New Revision: 346601 URL: http://llvm.org/viewvc/llvm-project?rev=346601=rev Log: Pass the function type instead of the return type to FunctionDecl::Create Fix places where the return type of a FunctionDecl was being used in place of the

[clang-tools-extra] r344140 - Lift VFS from clang to llvm (NFC)

2018-10-10 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Oct 10 06:27:25 2018 New Revision: 344140 URL: http://llvm.org/viewvc/llvm-project?rev=344140=rev Log: Lift VFS from clang to llvm (NFC) This patch moves the virtual file system form clang to llvm so it can be used by more projects. Concretely the patch: - Moves

r337717 - [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.

2018-07-23 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Jul 23 10:50:15 2018 New Revision: 337717 URL: http://llvm.org/viewvc/llvm-project?rev=337717=rev Log: [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target. Currently, support for debug_types is only present for ELF and trying to pass

r335834 - [DebugInfo] Follow-up commit to improve consistency. NFC

2018-06-28 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Thu Jun 28 03:56:40 2018 New Revision: 335834 URL: http://llvm.org/viewvc/llvm-project?rev=335834=rev Log: [DebugInfo] Follow-up commit to improve consistency. NFC Follow-up commit for r335757 to address some inconsistencies. Modified:

r335757 - [DebugInfo] Emit ObjC methods as part of interface

2018-06-27 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Jun 27 10:31:59 2018 New Revision: 335757 URL: http://llvm.org/viewvc/llvm-project?rev=335757=rev Log: [DebugInfo] Emit ObjC methods as part of interface As brought up during the discussion of the DWARF5 accelerator tables, there is currently no way to associate

[clang-tools-extra] r333673 - PrintEscapedString -> printEscapedString

2018-05-31 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Thu May 31 10:36:31 2018 New Revision: 333673 URL: http://llvm.org/viewvc/llvm-project?rev=333673=rev Log: PrintEscapedString -> printEscapedString Update PrintEscapedString after renaming it in ADT. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp Modified:

r332448 - [diagtool] Add diagtool to install target.

2018-05-16 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed May 16 03:23:25 2018 New Revision: 332448 URL: http://llvm.org/viewvc/llvm-project?rev=332448=rev Log: [diagtool] Add diagtool to install target. Although not very well known, diagtool is an incredibly convenient utility for dealing with diagnostics. Particularly

r328196 - [CodeGen] Emit DWARF "constructor" calling convention

2018-03-22 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Thu Mar 22 06:53:30 2018 New Revision: 328196 URL: http://llvm.org/viewvc/llvm-project?rev=328196=rev Log: [CodeGen] Emit DWARF "constructor" calling convention Now that LLVM has support for emitting calling conventions in DWARF (see r328191) have clang emit them.

r327790 - [dsymutil] Rename llvm-dsymutil -> dsymutil

2018-03-18 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Sun Mar 18 04:38:41 2018 New Revision: 327790 URL: http://llvm.org/viewvc/llvm-project?rev=327790=rev Log: [dsymutil] Rename llvm-dsymutil -> dsymutil Now that almost all functionality of Apple's dsymutil has been upstreamed, the open source variant can be used as a

r326091 - Re-land: "[Support] Replace HashString with djbHash."

2018-02-26 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Feb 26 07:16:42 2018 New Revision: 326091 URL: http://llvm.org/viewvc/llvm-project?rev=326091=rev Log: Re-land: "[Support] Replace HashString with djbHash." This patch removes the HashString function from StringExtraces and replaces its uses with calls to djbHash

r326082 - Revert "[Support] Replace HashString with djbHash."

2018-02-26 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Feb 26 04:05:18 2018 New Revision: 326082 URL: http://llvm.org/viewvc/llvm-project?rev=326082=rev Log: Revert "[Support] Replace HashString with djbHash." It looks like some of our tests depend on the ordering of hashed values. I'm reverting my changes while I try

r326081 - [Support] Replace HashString with djbHash.

2018-02-26 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Feb 26 03:30:13 2018 New Revision: 326081 URL: http://llvm.org/viewvc/llvm-project?rev=326081=rev Log: [Support] Replace HashString with djbHash. This removes the HashString function from StringExtraces and replaces its uses with calls to djbHash from DJB.h This

r321090 - [clang] -foptimization-record-file= should imply -fsave-optimization-record

2017-12-19 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue Dec 19 09:16:45 2017 New Revision: 321090 URL: http://llvm.org/viewvc/llvm-project?rev=321090=rev Log: [clang] -foptimization-record-file= should imply -fsave-optimization-record The Clang option -foptimization-record-file= controls which file an optimization

r312545 - [NFC] Loop modernization in diagtool

2017-09-05 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue Sep 5 11:04:34 2017 New Revision: 312545 URL: http://llvm.org/viewvc/llvm-project?rev=312545=rev Log: [NFC] Loop modernization in diagtool Precommit for https://reviews.llvm.org/D37390 Modified: cfe/trunk/tools/diagtool/DiagnosticNames.cpp

r312546 - [diagtool] Change default tree behavior to print only flags

2017-09-05 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue Sep 5 11:04:40 2017 New Revision: 312546 URL: http://llvm.org/viewvc/llvm-project?rev=312546=rev Log: [diagtool] Change default tree behavior to print only flags This patch changes the default behavior of `diagtool tree` to only display warning flags and not the

[clang-tools-extra] r307040 - [clang-tidy] Resolve cppcoreguidelines-pro-type-member-init false positive

2017-07-03 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Jul 3 09:46:46 2017 New Revision: 307040 URL: http://llvm.org/viewvc/llvm-project?rev=307040=rev Log: [clang-tidy] Resolve cppcoreguidelines-pro-type-member-init false positive Summary: https://bugs.llvm.org/show_bug.cgi?id=33557 Reviewers: Eugene.Zelenko,

[clang-tools-extra] r299461 - [clangd] Link against clangSema

2017-04-04 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Tue Apr 4 14:42:29 2017 New Revision: 299461 URL: http://llvm.org/viewvc/llvm-project?rev=299461=rev Log: [clangd] Link against clangSema Fixes linking issue introduced by rL299421 when building LLVM with shared libraries. Modified:

r297649 - [Linker] Provide callback for internalization

2017-03-13 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Mon Mar 13 13:08:11 2017 New Revision: 297649 URL: http://llvm.org/viewvc/llvm-project?rev=297649=rev Log: [Linker] Provide callback for internalization Differential Revision: https://reviews.llvm.org/D30738 Modified:

[clang-tools-extra] r295207 - [clang-tidy] Fix test modernize-return-braced-init-list

2017-02-15 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Feb 15 11:37:58 2017 New Revision: 295207 URL: http://llvm.org/viewvc/llvm-project?rev=295207=rev Log: [clang-tidy] Fix test modernize-return-braced-init-list Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-return-braced-init-list.cpp Modified:

[clang-tools-extra] r295205 - Fixed indentation issue in release notes

2017-02-15 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Feb 15 11:19:44 2017 New Revision: 295205 URL: http://llvm.org/viewvc/llvm-project?rev=295205=rev Log: Fixed indentation issue in release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

[clang-tools-extra] r295199 - [clang-tidy] Add check 'modernize-return-braced-init-list'

2017-02-15 Thread Jonas Devlieghere via cfe-commits
Author: jdevlieghere Date: Wed Feb 15 11:06:06 2017 New Revision: 295199 URL: http://llvm.org/viewvc/llvm-project?rev=295199=rev Log: [clang-tidy] Add check 'modernize-return-braced-init-list' Summary: Replaces explicit calls to the constructor in a return with a braced initializer list. This

  1   2   >