failure in check-libcxx with just-built clang.
>>
>> http://bb.pgr.jp/builders/bootstrap-clang-libcxx-lld-i686-
>> linux/builds/758
>>
>>
>> On Wed, Aug 9, 2017 at 4:45 AM Josh Gao via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
&g
Author: jmgao
Date: Fri Aug 11 00:54:35 2017
New Revision: 310698
URL: http://llvm.org/viewvc/llvm-project?rev=310698=rev
Log:
Revert "Thread Safety Analysis: warn on nonsensical attributes."
This reverts commit rL310403, which caused spurious warnings in libc++,
because it didn't properly
inux/builds/758
>
>
> On Wed, Aug 9, 2017 at 4:45 AM Josh Gao via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: jmgao
>> Date: Tue Aug 8 12:44:35 2017
>> New Revision: 310403
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=310403=rev
Author: jmgao
Date: Tue Aug 8 12:44:35 2017
New Revision: 310403
URL: http://llvm.org/viewvc/llvm-project?rev=310403=rev
Log:
Thread Safety Analysis: warn on nonsensical attributes.
Add warnings in cases where an implicit `this` argument is expected to
attributes because either `this` doesn't
Author: jmgao
Date: Tue Aug 8 12:44:34 2017
New Revision: 310402
URL: http://llvm.org/viewvc/llvm-project?rev=310402=rev
Log:
Reland "Thread Safety Analysis: fix assert_capability."
Delete the test that was broken by rL309725, and add it back in a
follow up commit. Also, improve the tests a
Author: jmgao
Date: Tue Aug 1 12:53:31 2017
New Revision: 309731
URL: http://llvm.org/viewvc/llvm-project?rev=309731=rev
Log:
Revert "Thread Safety Analysis: fix assert_capability."
This reverts commit rL309725.
Broke test/Sema/attr-capabilities.c.
Modified:
Author: jmgao
Date: Tue Aug 1 12:18:05 2017
New Revision: 309725
URL: http://llvm.org/viewvc/llvm-project?rev=309725=rev
Log:
Thread Safety Analysis: fix assert_capability.
Summary:
Previously, the assert_capability attribute was completely ignored by
thread safety analysis.
Reviewers:
> I suspect this is because using PATH in this way as part of a test doesn't
> work well, but I'll let you look at what the best option is for fixing
> this. For now I've reverted it in
>
> Please watch the bots when committing in the future.
>
> -Chandler
>
> On Fri, Jun
Author: jmgao
Date: Fri Jun 10 13:30:33 2016
New Revision: 272413
URL: http://llvm.org/viewvc/llvm-project?rev=272413=rev
Log:
Strip Android version when looking up toolchain paths.
Summary:
Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21'),
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272413: Strip Android version when looking up toolchain
paths. (authored by jmgao).
Changed prior to commit:
http://reviews.llvm.org/D21163?vs=60294=60379#toc
Repository:
rL LLVM
jmgao added a comment.
Thanks for the review!
http://reviews.llvm.org/D21163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmgao updated this revision to Diff 60294.
jmgao added a comment.
Add test.
http://reviews.llvm.org/D21163
Files:
lib/Driver/Driver.cpp
test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld
test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld.exe
jmgao created this revision.
jmgao added reviewers: srhines, danalbert.
jmgao added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, aemerson.
Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21'), used for
jmgao marked 4 inline comments as done.
jmgao added a comment.
http://reviews.llvm.org/D12181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmgao updated this revision to Diff 32769.
jmgao added a comment.
Doc fix, 80 col
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
jmgao updated this revision to Diff 32788.
jmgao marked 7 inline comments as done.
jmgao added a comment.
clang-format, remove \brief from modified doxygen comments.
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
jmgao marked 8 inline comments as done.
Comment at: tools/clang/lib/CodeGen/CGExpr.cpp:2388
@@ +2387,3 @@
+ }
+ return EmitTrapCheck(Checked);
+}
samsonov wrote:
This is confusing. So, you have the following behavior whenever you need to
emit a check for
jmgao updated this revision to Diff 32755.
jmgao marked 2 inline comments as done.
jmgao added a comment.
Address comments
http://reviews.llvm.org/D12181
Files:
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGExpr.cpp
18 matches
Mail list logo
