cuviper added inline comments.
Comment at: llvm/include/llvm-c/Core.h:163
LLVMX86_MMXTypeKind, /**< X86 MMX */
+ LLVMX86_AMXTypeKind, /**< X86 AMX */
LLVMTokenTypeKind, /**< Tokens */
This is a breaking change to the C ABI -- can we move it to the
cuviper added inline comments.
Comment at: clang/tools/clang-shlib/CMakeLists.txt:54
+ PROPERTIES
+ SOVERSION ${LIBCLANG_LIBRARY_VERSION})
tstellar wrote:
> cuviper wrote:
> > I think you also need `VERSION` here, or else it symlinks back to `.so.11`.
>
cuviper added inline comments.
Comment at: clang/tools/clang-shlib/CMakeLists.txt:54
+ PROPERTIES
+ SOVERSION ${LIBCLANG_LIBRARY_VERSION})
I think you also need `VERSION` here, or else it symlinks back to `.so.11`.
Repository:
rG LLVM Github Monorep
cuviper added a comment.
If the SONAME is different in any way, it is totally distinct to the dynamic
linker. There's no semver parsing or anything like that. That's all we can do
from a technical perspective, and the rest is just communication in the release.
Repository:
rG LLVM Github Mono
cuviper added inline comments.
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1595
const DISubrange *Subrange = cast(Element);
-assert(Subrange->getLowerBound() == 0 &&
+assert(!Subrange->getRawLowerBound() &&
"codeview doesn't support subrange
