[PATCH] D125208: [OpenCL] Fix __remove_address_space documentation code example

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Herald added a project: All. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously code example didn't compile

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Topotuna accepted this revision. Topotuna added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116271/new/ https://reviews.llvm.org/D116271 ___ cfe-commits mailing list

[PATCH] D116271: [Docs] Document C++ for OpenCL 2021 support in clang

Topotuna added a comment. Overall, I think that adjustments are accurate. Suggested a couple of small edits Comment at: clang/docs/OpenCLSupport.rst:28-29 -For general issues and bugs with OpenCL in clang refer to `Bugzilla

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna closed this revision. Topotuna added a comment. Closed by commit: rGb5fef6dbfd6b4c84d61155fd2221064bcc1ecdcf CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://reviews.llvm.org/D110155

[PATCH] D110185: [OpenCL] Reuse C++ for OpenCL 1.0 address space tests for version 2021

Topotuna updated this revision to Diff 390622. Topotuna added a comment. Herald added a subscriber: Naghasan. Test coverage expanded CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110185/new/ https://reviews.llvm.org/D110185 Files:

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna updated this revision to Diff 390617. Topotuna added a comment. Run line argument reordering CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/ https://reviews.llvm.org/D110155 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG388e8110db6f: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021 (authored by Topotuna). Herald added a subscriber: Naghasan.

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna updated this revision to Diff 386773. Topotuna added a comment. Herald added a subscriber: Naghasan. Run line `-triple` is now set explicitly. Test moved from `CodeGenOpenCLCXX` directory to `SemaOpenCLCXX` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110155/new/

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna added a comment. In D110155#3117786 , @carlosgalvezp wrote: > Hi! I believe this commit broke a number of CI jobs, would you be able to > look into it? > > https://lab.llvm.org/buildbot/#/builders/52/builds/12263 Hi, I am aware it broke some

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81081daef029: [OpenCL] Allow optional __generic in __remove_address_space utility (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Topotuna added a comment. In D110184#3115361 , @Anastasia wrote: > Ping, @Topotuna do you still plan to commit this? Ah, yes. I will commit it in the next couple of days as well as D110155 Repository: rG LLVM

[PATCH] D110185: [OpenCL] Reuse C++ for OpenCL 1.0 address space tests for version 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `RUN` lines in C++ for OpenCL address space tests to cover

[PATCH] D110184: [OpenCL] Constructor address space test adjusted for C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reuses C++ for OpenCL constructor address space test so that it

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types require

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Topotuna added a comment. Changes rG054e331d9dbd and rG37cdc7ebd9a3 contain test cases that display C++ for OpenCL version 2021 in diagnostics.

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32b994bca666: [OpenCL] Defines helper function for OpenCL default address space (authored by Topotuna). Changed prior to commit:

[PATCH] D110155: [OpenCL] Allow optional __generic in __remove_address_space utility

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang builtin utility `__remove_address_space` now works if generic

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna marked 2 inline comments as done. Topotuna added a comment. Both comments addressed. Personally, I would shuffle words around to rename helper function as `getDefaultOpenCLPointeeAddrSpace` or `getOpenCLDefaultPointeeAddrSpace`. Although I am not sure if there are some assumed naming

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna updated this revision to Diff 373834. Topotuna edited the summary of this revision. Topotuna added a comment. Helper function renamed for clarity. Additional check added to `if` statement to ensure it is only carried out in OpenCL. CHANGES SINCE LAST ACTION

[PATCH] D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b8b5c114b6: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG228dd20c3f1e: [OpenCL] Supports atomics in C++ for OpenCL 2021 (authored by Topotuna). Changed prior to commit:

[PATCH] D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca3bebd8440f: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e9d203c679: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021 (authored by Topotuna). Changed prior to commit:

[PATCH] D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37cdc7ebd9a3: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna updated this revision to Diff 372937. Topotuna edited the summary of this revision. Topotuna added reviewers: olestrohm, Anastasia. Topotuna added a comment. Code refactored inside `clang/lib/AST/Expr.cpp`. Commit message added. CHANGES SINCE LAST ACTION

[PATCH] D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG054e331d9dbd: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna planned changes to this revision. Topotuna added a comment. Current change is an initial draft. More code refactoring will be performed and change summary provided in near future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109874/new/

[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109874 Files:

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rG3b9470a6c46d: [OpenCL] Supports optional image types in C++ for OpenCL 2021 (authored by Topotuna).

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rG09dc454b00b8: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGad88632b6503: [OpenCL] Tests C++ for OpenCL version macros (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109366/new/

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

Topotuna updated this revision to Diff 371831. Topotuna added a comment. Reuses `--check-prefix=CHECK-CLCPP10` for default C++ for OpenCL command line version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109366/new/ https://reviews.llvm.org/D109366 Files:

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Topotuna accepted this revision. Topotuna added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109327/new/ https://reviews.llvm.org/D109327 ___ cfe-commits mailing list

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

Topotuna updated this revision to Diff 371544. Topotuna retitled this revision from "[OpenCL] Tests C++ for OpenCL 2021 version macros" to "[OpenCL] Tests C++ for OpenCL version macros". Topotuna edited the summary of this revision. Topotuna added a comment. Test case added for command line flag

[PATCH] D109492: [OpenCL] Test case for C++ for OpenCL 2021 in OpenCL C header test

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. RUN line representing C++ for OpenCL 2021 added to the test. This

[PATCH] D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Atomics in C++ for OpenCL 2021 are now handled the same way as in

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `.rgba` vector extension setting in C++ for OpenCL 2021 is now

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL 2021 version macros

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Version macro definitions are tested for C++ for OpenCL 2021.

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Topotuna added a comment. Overall, I think the release notes accurately describe tasks I have been working on. A couple of suggestions and minor grammatical changes provided. Comment at: clang/docs/ReleaseNotes.rst:159 + +- All builtin types, macros and functions declarations

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rGc33e296be1da: [OpenCL] Disallows static kernel functions in C++ for OpenCL (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109150/new/

[PATCH] D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro __opencl_c_3d_image_writes in C++ for

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Topotuna updated this revision to Diff 370895. Topotuna added a comment. Condition on OpenCL C / C++ for OpenCL version removed because it was redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109150/new/ https://reviews.llvm.org/D109150 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Topotuna added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9972 // OpenCL v1.2 s6.8 static is invalid for kernel functions. -if ((getLangOpts().OpenCLVersion >= 120) -&& (SC == SC_Static)) { +if ((getLangOpts().getOpenCLCompatibleVersion() >=

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rGcc9260a0fb7c: [OpenCL] Supports optional generic address space semantics in C++ for OpenCL… (authored by

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:413 OpenCLFeaturesMap, "__opencl_c_generic_address_space"); - Opts.OpenCLPipes = - hasFeatureEnabled(OpenCLFeaturesMap,

[PATCH] D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Herald added a reviewer: aaron.ballman. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature

[PATCH] D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_pipes` in C++ for OpenCL

[PATCH] D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for macro `__opencl_c_program_scope_global_variables` in

[PATCH] D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd74f4b10834: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is disallowed in OpenCL C to declare static kernel functions and

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna updated this revision to Diff 370237. Topotuna added a comment. Boolean variable renamed to `IsOpenCLC30Compatible`. `FIXME` comment added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109002/new/ https://reviews.llvm.org/D109002 Files: clang/lib/Sema/SemaType.cpp

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

Topotuna updated this revision to Diff 369913. Topotuna retitled this revision from "[OpenCL] Supports optional generic address space in C++ for OpenCL 2021" to "[OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021". Topotuna edited the summary of this revision.

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types require

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb321c2ea274: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_images` in C++ for OpenCL

[PATCH] D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_fp64` in C++ for OpenCL

[PATCH] D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9bc1b3bee55: [OpenCL] Defines helper function for kernel language compatible OpenCL version (authored by Topotuna). Repository: rG LLVM Github

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modifies OpenCL 3.0 optional core feature macro definitions so that

[PATCH] D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, yaxunl. Herald added a reviewer: aaron.ballman. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change

[PATCH] D108461: [OpenCL] Supports optional generic address space in C++ for OpenCL 2021

Topotuna planned changes to this revision. Topotuna added a comment. `__opencl_c_generic_address_space` should not have been chosen as the first feature to be addressed out of all OpenCL 3.0 optional core features. This is because `__opencl_c_device_enqueue` has a dependency on this feature. I

[PATCH] D108461: [OpenCL] Supports optional generic address space in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_generic_address_space` in

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae9262857a1: [OpenCL] Fix version reporting of C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108379/new/

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Topotuna added a comment. In D108379#2954826 , @Anastasia wrote: > LGTM! Thanks! > > I imagine you will be adding some tests that will check the correctness of > diagnostic wording in the subsequent commits? Yes, I will add tests for diagnostics

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++ for OpenCL version 2021 and later are expected to

[PATCH] D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d0628b2d213: [OpenCL] C++ for OpenCL version 2021 introduced to command line. (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D108113: [C++4OpenCL] Enable -cl-std flag clc++21 as a shorthand for clc++2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, dang, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allows `clc++21` and `CLC++21` to be used as

[PATCH] D108038: [C++4OpenCL] C++ for OpenCL version 2021 introduced to command line

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, dang, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduces language standard `lang_openclcpp2021`

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfdfb75c1ff3: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version. (authored by Topotuna). Changed prior to commit:

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna updated this revision to Diff 365179. Topotuna added a comment. Diagnostic `err_opencl_unknown_type_specifier` addressed. Deprecation conditions changed in `nosvm` attribute test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107648/new/ https://reviews.llvm.org/D107648

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna updated this revision to Diff 365157. Topotuna added a comment. Herald added a subscriber: dexonsmith. Diagnostics reworded. Helper function `getOpenCLVersionString()` added. Tests updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107648/new/

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna updated this revision to Diff 364796. Topotuna added a comment. Diagnostic argument index updated (from `%1` to `%2`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107648/new/ https://reviews.llvm.org/D107648 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D107648: [OpenCL] Clang diagnostics allow reporting C++ for OpenCL version.

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Herald added a reviewer: aaron.ballman. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some Clang diagnostics could

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a2f05dcc80: [C++4OpenCL] Introduces __remove_address_space utility (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 364420. Topotuna added a comment. Documentation section title reworded CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExtensions.rst clang/lib/Headers/opencl-c-base.h

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rGb13fc7311eab: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode. (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/Driver/threadsafe-statics.clcpp:2 +// RUN: %clang -### -c -DNO_THREADSAFE_STATICS %s 2>&1 | FileCheck --check-prefix=CHECK-NO-THREADSAFE-STATICS %s +// RUN: %clang -###

[PATCH] D107163: [OpenCL] __cpp_threadsafe_static_init is by default undefined in OpenCL mode

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Definition of __cpp_threadsafe_static_init macro is controlled by

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 362027. Topotuna added a comment. Test case added that checks if __remove_address_space modifies types without address space CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files:

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1964 +Address space removal +- Anastasia wrote: > Anastasia wrote: > > Maybe we could title it something like: > > > > `Address space removal utility` > > or > >

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 361975. Topotuna added a comment. Documentation rewording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExtensions.rst clang/lib/Headers/opencl-c-base.h

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 361954. Topotuna added a comment. Additional tests added for `is_same` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files: clang/docs/LanguageExtensions.rst clang/lib/Headers/opencl-c-base.h

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna updated this revision to Diff 361937. Topotuna added a comment. Reference to C++ for OpenCL 1.0 specification removed. More elaborate code example added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/ https://reviews.llvm.org/D106785 Files:

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna added a comment. Change to `LanguageExtensions.rst` assumes there is a section about the utility on official C++ for OpenCL documentation. However, it is not yet documented Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106785/new/

[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change provides a way to conveniently declare types that have

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added a comment. That is good to know. Thank you for sorting it out CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") Anastasia wrote: > I am not sure we should move it into the deprecated

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna updated this revision to Diff 360059. Topotuna added a comment. `clc++` made no longer deprecated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/LangStandards.def

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: jeroen.dobbelaere, ldrumm, dexonsmith, dang, yaxunl. Topotuna requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. The commit

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:26 #ifdef CL20 // Accept explicitly pointer to generic address space in OpenCL v2.0. Anastasia wrote: > while we are at it, do you

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna updated this revision to Diff 359702. Topotuna added a comment. Separate NFC performed in D106254 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D106254: [OpenCL][NFC] Refactors conditional versioning

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removes run line declaration -DCL20 and substitutes it with condition

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:13 +#if defined(__OPENCL_CPP_VERSION__) +// expected-error@+2{{cannot initialize a variable of type '__global int *__private' with an rvalue of type

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna updated this revision to Diff 359256. Topotuna added a comment. Patch made compatible with changes to D105988 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105987/new/ https://reviews.llvm.org/D105987 Files:

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna marked 2 inline comments as done. Topotuna added inline comments. Comment at: clang/test/SemaOpenCL/null_literal.cl:7 #define NULL ((void*)0) Anastasia wrote: > Anastasia wrote: > > I think we should remove this `NULL` definition but instead add >

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna updated this revision to Diff 358911. Topotuna added a comment. Full diff now added. Redundant condition `#if` removed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna updated this revision to Diff 358628. Topotuna added a comment. Wrong diff file added previously CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 Files: clang/lib/Headers/opencl-c-base.h clang/test/SemaOpenCL/null_literal.cl

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna updated this revision to Diff 358625. Topotuna added a comment. Added compile time flags -finclude-default-header -fdeclare-opencl-builtins instead of #define NULL ((void*)0) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NULL macro maps to ((void*)0) for OpenCL versions earlier than 2.0 NULL was undefined in OpenCL

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Redefines NULL as nullptr instead of ((void*)0) in C++ for OpenCL. Such internal representation

  1   2   >