[PATCH] D158923: [clang-c] Visit ranged for initializer

2023-08-26 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. Can we get this into release/17.x still? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158923/new/ https://reviews.llvm.org/D158923 ___ cfe-commits mailing list

[PATCH] D158923: [clang-c] Visit ranged for initializer

2023-08-26 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia created this revision. kiloalphaindia added reviewers: HAPPY, aaron.ballman. kiloalphaindia added a project: clang-c. Herald added a subscriber: arphaman. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. I had copied the warning-flags from the build-bot command line and ended up as follows: -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. It could also be a different version of gtest or so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224 ___ cfe-commits mailing

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. Also affects: clang-ppc64-aix https://lab.llvm.org/buildbot/#/builders/214/builds/8649 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/ https://reviews.llvm.org/D156224

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. See: https://lab.llvm.org/buildbot/#/builders/57/builds/28680 I couldn't reproduce this on my system. Anyone knows how to test it before merging? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156224/new/

[PATCH] D156224: [Clang] use unsigned integer constants in unit-test | fixes build error on ppc64le-lld-multistage-test

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia created this revision. kiloalphaindia added a reviewer: cor3ntin. Herald added a subscriber: shchenz. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes:

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. Please use Kai Stierand as in 5d859a1cdee3c15dce692767ee3e9ad03a8c4c1b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

2023-07-25 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia updated this revision to Diff 543845. kiloalphaindia added a comment. The test is no more using any includes now. Hopefully this fixes it, otherwise I will have to add something that prints the diagnostic. I don't have write permissions on the repository. Please commit it when

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

2023-07-24 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. Yes, I think so, too. Will have a look this evening. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

2023-07-23 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia updated this revision to Diff 543304. kiloalphaindia added a comment. Sorry... forgot formatting... removed commented code... changed "Hallo Welt!" to english CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 Files:

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

2023-07-23 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia updated this revision to Diff 543302. kiloalphaindia added a comment. Yes, that's a good idea. Now `kdevelop` also highlights the message-expression properly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156053/new/ https://reviews.llvm.org/D156053 Files:

[PATCH] D156053: [Clang] Fix crash in CIndex, when visiting a static_assert without message

2023-07-23 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia created this revision. kiloalphaindia added a reviewer: cor3ntin. Herald added a subscriber: arphaman. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. After implementation

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

2022-10-11 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia added a comment. @sammccall I don't think I can commit anything. Can you please do it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13/new/ https://reviews.llvm.org/D13 ___

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

2022-10-10 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia updated this revision to Diff 466701. kiloalphaindia added a comment. renamed function `from_CXString` -> `fromCXString` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13/new/ https://reviews.llvm.org/D13 Files:

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

2022-10-10 Thread Kai Stierand via Phabricator via cfe-commits
kiloalphaindia created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D13