[PATCH] D80031: [clang-format] [NFC] release note placed in the wrong location and other rst linting errors

ghvg1313 accepted this revision. ghvg1313 added a comment. This revision is now accepted and ready to land. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80031/new/ https://reviews.llvm.org/D80031

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 added a comment. In D77039#1967224 , @MyDeveloperDay wrote: > what is changing in clang/docs/ClangFormatStyleOptions.rst? if nothing then > remove from the diff there's an indentation issue, this changes the example of the doc from: -

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 added a comment. @jolesiak I don't yet have the commit access, do you mind help merging this diff? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 updated this revision to Diff 254015. ghvg1313 added a comment. reset diff's base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 updated this revision to Diff 254014. ghvg1313 added a comment. - Fix documentation formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

ghvg1313 created this revision. ghvg1313 added reviewers: jolesiak, benhamilton. Herald added a project: clang. Herald added a subscriber: cfe-commits. While the original diff makes a lot of sense, and multiple inline block parameter/trailing paramemter after

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 240260. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rebase master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files:

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:164 + +- Clang-format now supports JavaScript null operators. + MyDeveloperDay wrote: > is this line part of this patch? No, rebased again and got

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 239458. ghvg1313 added a comment. - rebase master - formatting code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. @MyDeveloperDay gentle ping for help merging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 ___ cfe-commits mailing list

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1790848 , @MyDeveloperDay wrote: > Thanks for the patch. Happy new year! Could you help landing this diff? I don't know exactly what to do from here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked 2 inline comments as done. ghvg1313 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:869 State.Stack[i].BreakBeforeParameter = true; if (PreviousNonComment && ghvg1313 wrote: > MyDeveloperDay wrote: > > I'm

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 234621. ghvg1313 added a comment. - Handle parameter break between blocks - Fix test cases and move them to objcTest - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. @MyDeveloperDay Anything I'll need to do on my end to start the landing process? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 ___

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 added a comment. In D70926#1769437 , @MyDeveloperDay wrote: > LGTM > > A little advice as you fix each comment check the "Done" button. > > I notice you are a new user, will you need help landing it? Thanks for the review! And yes I do need

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 232177. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - Move documents from release notes to header and proper rst, register test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 231971. ghvg1313 marked an inline comment as done. ghvg1313 added a comment. - rename option, remove handlers for nested block itself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 marked an inline comment as done. ghvg1313 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:869 State.Stack[i].BreakBeforeParameter = true; if (PreviousNonComment && MyDeveloperDay wrote: > I'm a little confused

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

ghvg1313 updated this revision to Diff 231790. ghvg1313 added a comment. - Update documents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70926/new/ https://reviews.llvm.org/D70926 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D70926: Add option for not breaking line before ObjC params

ghvg1313 created this revision. ghvg1313 added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. >From `clang-format` version 3.7.0 and up, , there is no way to keep following >format of ObjectiveC block: - (void)_aMethod { [self.test1 t:self