https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/94931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 edited
https://github.com/llvm/llvm-project/pull/94931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/94931
>From c5b2765d9f4bd2a8412c0722a052148673411f94 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Mon, 10 Jun 2024 07:45:48 +0200
Subject: [PATCH 1/2] [test][OpenMP] Avoid writing to a potentially
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -emit-llvm -verify -fopenmp %s
+// RUN: %clang_cc1 -fsyntax-only -verify -fopenmp %s
karka228 wrote:
It seems like this was a bad idea. When I test this locally this test works for
me, but it seems like the it fail in the
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/94931
The test clang/test/OpenMP/error_unsupport_feature.c don't check the output
written to the current directory. The current directory may be write protected
e.g. in a sandboxed environment.
This patch replace
karka228 wrote:
> LGTM. Thanks.
I will close the issue #87758.
Thanks @andykaylor and @zahiraam for reviewing.
https://github.com/llvm/llvm-project/pull/90377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/90377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/90377
>From 80836f51573c8ba474a0b5d5890a489d5f0c7034 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Sat, 27 Apr 2024 22:04:11 +0200
Subject: [PATCH 1/6] Pre-commit reproducer for fast-math flags on calls
@@ -0,0 +1,76 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s
+
+// precise mode
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -fmath-errno -ffp-contract=on \
+// RUN: -fno-rounding-math -emit-llvm -o - %s | FileCheck \
+// RUN:
@@ -0,0 +1,55 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm
-disable-llvm-passes -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/90377
>From 80836f51573c8ba474a0b5d5890a489d5f0c7034 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Sat, 27 Apr 2024 22:04:11 +0200
Subject: [PATCH 1/5] Pre-commit reproducer for fast-math flags on calls
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
+// RUN: | FileCheck -check-prefix=CHECK %s
+
+// Reproducer for issue #87758
+// The
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/90377
>From 80836f51573c8ba474a0b5d5890a489d5f0c7034 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Sat, 27 Apr 2024 22:04:11 +0200
Subject: [PATCH 1/4] Pre-commit reproducer for fast-math flags on calls
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
+// RUN: | FileCheck -check-prefix=CHECK %s
+
karka228 wrote:
Sure, I
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
karka228 wrote:
The only reason for using `-O3` was to get rid of all
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
+// RUN: | FileCheck -check-prefix=CHECK %s
+
+// Reproducer for issue #87758
+// The
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/90377
>From 80836f51573c8ba474a0b5d5890a489d5f0c7034 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Sat, 27 Apr 2024 22:04:11 +0200
Subject: [PATCH 1/3] Pre-commit reproducer for fast-math flags on calls
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/90377
This is a fix for the issue #87758 where fast-math flags are not propagated all
builtins.
It seems like pragmas with fast math flags was only propagated to calls of
unary floating point builtins. This patch
https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/89242
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/89242
>From 4cc801e00e80f9727ade71213193e8d5cc5610f8 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Thu, 18 Apr 2024 16:24:13 +0200
Subject: [PATCH 1/2] [test] Avoid writing to a potentially write-protected
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm
-disable-llvm-passes -verify -verify-ignore-unexpected
+// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.6-library %s
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/89242
These tests just don't check the output written to the current directory. The
current directory may be write protected e.g. in a sandboxed environment.
Typically one would write `clang -o %t.o` for a writeable
@@ -12,8 +12,8 @@
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -Wformat
-verify=okay %s
// Verify that -Wformat-signedness with -Wno-format are not reported (gcc
compat).
karka228 wrote:
That discussion is only about -Wformat
@@ -218,5 +218,5 @@ void test_printf_unsigned_priX16(uint16_t x) {
void test_suppress(int x)
karka228 wrote:
Same as above about gcc compatibility. The comment need at least to be updated.
https://github.com/llvm/llvm-project/pull/88595
@@ -12,8 +12,8 @@
// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -Wformat
-verify=okay %s
// Verify that -Wformat-signedness with -Wno-format are not reported (gcc
compat).
karka228 wrote:
The -Wformat-signedness warning was
https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/74440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From 1dd6c32ee8e053c900e23f37d50f8c3f4868858a Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 01/10] [Sema] Implement support for -Wformat-signedness
In
karka228 wrote:
> LGTM!
Thanks. I will rebase and then "squash and merge" this to the main branch.
https://github.com/llvm/llvm-project/pull/74440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From aa9d6cd10ff32fdcdd3d1b2ef334aa70f56cccb1 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 01/10] [Sema] Implement support for -Wformat-signedness
In
@@ -0,0 +1,223 @@
+// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+// RUN: %clang_cc1 -triple=x86_64-pc-win32 -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+
+// Verify that -Wformat-signedness
@@ -0,0 +1,223 @@
+// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+// RUN: %clang_cc1 -triple=x86_64-pc-win32 -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+
+// Verify that -Wformat-signedness
karka228 wrote:
> > With the current implementation `-Wformat-signedness` by itself actually
> > turn on the signedness warnings. This is not compatible with how gcc do it.
> > I guess I have thought that it was not that important to be compatible with
> > gcc in this respect. However if it
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From aa9d6cd10ff32fdcdd3d1b2ef334aa70f56cccb1 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/9] [Sema] Implement support for -Wformat-signedness
In
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From aa9d6cd10ff32fdcdd3d1b2ef334aa70f56cccb1 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/8] [Sema] Implement support for -Wformat-signedness
In
karka228 wrote:
> Can you also add a test showing the difference between `-Wformat
> -Wformat-signedness` and `-Wformat-signedness` by itself (which does nothing)?
With the current implementation `-Wformat-signedness` by itself actually turn
on the signedness warnings. This is not compatible
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From aa9d6cd10ff32fdcdd3d1b2ef334aa70f56cccb1 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/7] [Sema] Implement support for -Wformat-signedness
In
karka228 wrote:
> Sorry for the delayed response, this fell off my radar (thanks @Endilll for
> mentioning this after meeting with @hazohelet!).
No problem. As I wrote above I work in an out of tree backend and I have
already implemented this in our downstream repo. Our customer that
karka228 wrote:
Ping.
https://github.com/llvm/llvm-project/pull/74440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
karka228 wrote:
Ping. Lets pickup the discussion from before Christmas. Is the solution with
the dummy warning (that @hazohelet wrote about in a previous comment) an
acceptable solution?
https://github.com/llvm/llvm-project/pull/74440
___
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/7] [Sema] Implement support for -Wformat-signedness
In
@@ -11881,6 +11896,8 @@ CheckPrintfHandler::checkFormatExpr(const
analyze_printf::PrintfSpecifier ,
ICE->getType() == S.Context.UnsignedIntTy) {
// All further checking is done on the subexpression
ImplicitMatch = AT.matchesType(S.Context, ExprTy);
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/6] [Sema] Implement support for -Wformat-signedness
In
karka228 wrote:
> Alternatively, you could probably use `DiagnosticsEngine::isIgnored` to check
> if the `-Wformat-signedness` is enabled or not, and control whether
> `MatchSignedNess` is `NoMatch` or `Match`, as your first implementation did.
> This way we can achieve GCC compatibility for
karka228 wrote:
> > 1. The option -Wformat-signedness is default off.
> >
> > 2. The -Wformat-signedness warnings are not enabled alone by the -Wformat
> > option.
> >
> > 3. The -Wformat-signedness warnings are not enabled alone by the
> > -Wformat-signedness option.
> >
> > 4. The
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/5] [Sema] Implement support for -Wformat-signedness
In
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/4] [Sema] Implement support for -Wformat-signedness
In
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/3] [Sema] Implement support for -Wformat-signedness
In
karka228 wrote:
I have started to implement defining the -Wformat-signedness option config in
clang/include/clang/Basic/DiagnosticSemaKinds.td as suggested originally by
@hazohelet and I agree that the implementation is a lot cleaner that way.
However before finishing implementing that I think
karka228 wrote:
> I'd like to understand the need for this diagnostic a bit more. I realize GCC
> has it, but it's off-by-default in GCC and `-Wformat` does not enable it
> either: https://godbolt.org/z/Gxczsjdj5
>
> We believe that users don't enable off by default warnings often enough to
@@ -918,6 +918,9 @@ def Wdeprecated : Flag<["-"], "Wdeprecated">,
Group,
HelpText<"Enable warnings for deprecated constructs and define
__DEPRECATED">;
def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group,
Visibility<[ClangOption, CC1Option]>;
+def
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From a80bf9d03f19d48c0aca4af7758dc49516da8825 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 1/2] [Sema] Implement support for -Wformat-signedness
In
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/74440
In gcc there exist a modifier option -Wformat-signedness that turns on
additional signedness warnings in the already existing -Wformat warning.
This patch implements that support in clang.
>From
https://github.com/karka228 closed
https://github.com/llvm/llvm-project/pull/69521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From db4a254b721eddacf592a647d3de4fd10a8032e0 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH] [Sema] Fixed faulty shift count warning
Constant values
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From a4a9fb73de9319acd26290ef31d1e17b127c0c3b Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH] [Sema] Fixed faulty shift count warning
Constant values
karka228 wrote:
Ping
https://github.com/llvm/llvm-project/pull/69521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From a9bfc65f6d6b0953cd762f851fb6044e1c4b8ab8 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH 1/2] [Sema] Fixed faulty shift count warning
Constant
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/69521
Constant values of _BitInt have the bitwith to exactly fit the constant number.
This patch fix a problem in Sema when building an APInt where the supplied
bitwidth can become too small and simply truncate the
Author: Karl-Johan Karlsson
Date: 2020-04-07T08:39:17+02:00
New Revision: 39e9149d8e12d77cd389f55860ac2cb9a30b4552
URL:
https://github.com/llvm/llvm-project/commit/39e9149d8e12d77cd389f55860ac2cb9a30b4552
DIFF:
Author: Karl-Johan Karlsson
Date: 2020-03-26T11:23:59+01:00
New Revision: 7055cd42b5ffc88757eb3d12192047abe63a3714
URL:
https://github.com/llvm/llvm-project/commit/7055cd42b5ffc88757eb3d12192047abe63a3714
DIFF:
Author: Karl-Johan Karlsson
Date: 2019-12-26T09:33:21+01:00
New Revision: 073cdb239044dc056a3c79b995265f640ffb40e6
URL:
https://github.com/llvm/llvm-project/commit/073cdb239044dc056a3c79b995265f640ffb40e6
DIFF:
Author: Karl-Johan Karlsson
Date: 2019-12-20T09:16:33+01:00
New Revision: e8efac4b15303932581c128dc3976f4359388338
URL:
https://github.com/llvm/llvm-project/commit/e8efac4b15303932581c128dc3976f4359388338
DIFF:
Author: karka
Date: Mon Sep 16 02:52:23 2019
New Revision: 371969
URL: http://llvm.org/viewvc/llvm-project?rev=371969=rev
Log:
Change signature of __builtin_rotateright64 back to unsigned
The signature of __builtin_rotateright64 was by misstake changed from
unsigned to signed in r360863, this
Author: karka
Date: Thu May 16 00:18:02 2019
New Revision: 360863
URL: http://llvm.org/viewvc/llvm-project?rev=360863=rev
Log:
[builtin] Fixed definitions of builtins that rely on the int/long long type is
32/64 bits
Summary:
The definition of the builtins __builtin_bswap32,
Author: karka
Date: Tue Aug 7 01:10:33 2018
New Revision: 339112
URL: http://llvm.org/viewvc/llvm-project?rev=339112=rev
Log:
Fix clash of gcc toolchains in driver regression tests
For some regression tests the path to the right toolchain is specified
using the -sysroot switch. However, if
Author: karka
Date: Fri Aug 3 02:13:15 2018
New Revision: 338831
URL: http://llvm.org/viewvc/llvm-project?rev=338831=rev
Log:
Fix unused variable warning in tablegen generated code
Modified:
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified:
Author: karka
Date: Wed May 2 22:53:29 2018
New Revision: 331438
URL: http://llvm.org/viewvc/llvm-project?rev=331438=rev
Log:
Fix -Wunused-variable warning in Clang.cpp
Modified:
cfe/trunk/lib/Driver/ToolChains/Clang.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL:
Author: karka
Date: Wed Sep 6 01:47:18 2017
New Revision: 312623
URL: http://llvm.org/viewvc/llvm-project?rev=312623=rev
Log:
Debug info: Fixed faulty debug locations for attributed statements
Summary:
As the attributed statements are considered simple statements no
stoppoint was generated
68 matches
Mail list logo