[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

This revision was automatically updated to reflect the committed changes. Closed by commit rG2129cc1b3a14: [clang][Darwin] Error out when missing requested libarclite library (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 527261. keith added a comment. Improve error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 523899. keith added a comment. Improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith created this revision. Herald added a project: All. keith requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Starting with the SDKs provided with Xcode 14.3, this library no longer exists. Before this change this results in an

[PATCH] D147561: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

keith accepted this revision. keith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Modules/module-file-home-is-cwd.m:7-8 // RUN: -o %t/mod.pcm // RUN: llvm-bcanalyzer --dump --disable-histogram %t/mod.pcm | FileCheck %s +//

[PATCH] D126598: Fixed typo in hmaptool CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f2e4992456: [clang][cmake] Fixed typo in hmaptool CMakeLists.txt (authored by danielh2942, committed by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

keith added a comment. I took this comment from the issue: > Since the feature you're proposing is specific to gcov, using a separate flag > that matches the name used by GCC would be preferable to me. To mean that we should introduce a new flag matching gcc's name. I think in general fewer

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

keith added a comment. Based on the issue it sounds like this should be gated behind a new `-fprofile-prefix-map` flag? I assume we'd also want `-ffile-prefix-map` to apply to it as well, similar to the others. And we'll definitely want some tests here! Repository: rG LLVM Github Monorepo

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcca10c69aaa: [AArch64] Add support for -march=native for Apple M1 CPU (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith abandoned this revision. keith added a comment. There were 2 competing revisions for this bug fix, I landed https://reviews.llvm.org/D121663 instead since it sounds like having an empty `directory` is more correct in this case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121663: reland: [clang] Don't append the working directory to absolute paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2db7d5e9c52: reland: [clang] Dont append the working directory to absolute paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added inline comments. Comment at: clang/test/Modules/module-debuginfo-prefix.m:24 -// Dir should always be empty, but on Windows we can't recognize /var -// as being an absolute path. -// CHECK: !DIFile(filename: "/OVERRIDE/DebugObjC.h", directory: "{{()|(.*:.*)}}")

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html I discovered the issue from the failed tests on https://reviews.llvm.org/D113718 where you can see the test output contains a

[PATCH] D121663: reland: [clang] Don't append the working directory to absolute paths

keith created this revision. keith added a reviewer: aprantl. Herald added a project: All. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug that happens when using -fdebug-prefix-map to remap an absolute path to a

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415307. keith added a comment. Fix tests with dwarf 6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb22d71806b7: [clang] Fix DIFile directory root on Windows (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Bump, I think I've covered everything here, let me know if not! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 ___ cfe-commits mailing

[PATCH] D111457: [test] Add lit helper for windows paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6541d3e979c1: [test] Add lit helper for windows paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415292. keith added a comment. Herald added a project: All. Update subsitutions with slashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files:

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 415291. keith marked an inline comment as done. keith added a comment. Update subsitutions with dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files:

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 415290. keith added a comment. Update substitutions to use dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: llvm/docs/CommandGuide/lit.rst

[PATCH] D100692: clang-tidy: discover binaries in build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG5da83eeb91ba: clang-tidy: discover binaries in build dir (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100692/new/

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a comment. Ping, all green here, I just had to mess with the test regex a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 ___ cfe-commits

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 415004. keith added a comment. Replace \w with . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. Herald added a project: All. @compnerd can you re-review here? I think I covered your feedback, let me know! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 414976. keith added a comment. Herald added a project: All. Remove variables from test expectations This didn't work out because of the double vs single slash of the expansions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100692: clang-tidy: discover binaries in build dir

keith updated this revision to Diff 414975. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100692/new/ https://reviews.llvm.org/D100692 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index:

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 414878. keith added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 414866. keith added a comment. Herald added a project: All. Update default to latest known CPU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files:

[PATCH] D100692: clang-tidy: discover binaries in build dir

keith added a comment. Herald added subscribers: cfe-commits, carlosgalvezp. Herald added a project: All. Ping, it seems like https://reviews.llvm.org/D101037 is stalled but the docs at this point state py >=3.6 is required for working on llvm so I think we're good here

[PATCH] D111457: [test] Add lit helper for windows paths

keith added a comment. For reference here's an example of a test that uses this https://reviews.llvm.org/D111579 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457

[PATCH] D111457: [test] Add lit helper for windows paths

keith added inline comments. Comment at: llvm/utils/lit/lit/TestRunner.py:1124 +if kIsWindows: +fs_root = 'C:\\' +substitutions.extend([ probinson wrote: > rnk wrote: > > It is pretty common to run the LLVM test suite on secondary drives, > >

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411926. keith added a comment. Fix parent revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411923. keith added a comment. Update test with new variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 411922. keith added a comment. Update tests with new syntax and FileCheck variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files:

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 411921. keith marked 3 inline comments as done. keith edited the summary of this revision. keith added a comment. Use the actual drive on windows, split out into fssrcroot and fstmproot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 411576. keith added a comment. Update test with new specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 411575. keith marked 3 inline comments as done. keith added a comment. Add more test path changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files:

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 411573. keith added a comment. Herald added subscribers: llvm-commits, delcypher. Herald added a project: LLVM. Move config to llvm lit config, add docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

keith added a comment. In D102669#3325467 , @steakhal wrote: > Hi @keith, I've seen you commented on a clang driver-related issue: "Why does > march=native not work on Apple M1?" >

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added inline comments. Comment at: llvm/lib/Support/Host.cpp:1326 + case CPUFAMILY_ARM_CYCLONE: +return "apple-a7"; + case CPUFAMILY_ARM_TYPHOON: jrtc27 wrote: > ARM only calls it cyclone, AArch64 allows both but apple-a7 is the canonical > name

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 410040. keith marked 2 inline comments as done. keith added a comment. Code review improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files:

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Thanks for the tips! I left the default as generic here, but I totally take your point on defaulting to the newest and I'm happy to update if you feel strongly, lmk what you think Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith updated this revision to Diff 409849. keith added a comment. Update to read CPU from sysctl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 Files: clang/lib/Driver/ToolChains/Arch/AArch64.cpp

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added reviewers: beanz, efriedma. keith added a comment. Adding folks from https://reviews.llvm.org/D69597 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya, kristof.beyls. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This improves the getHostCPUName check for Apple M1

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG502f14d6f2ee: [VFS] Add a redirecting-with field to overlays (authored by bnbarham, committed by keith). Changed prior to commit:

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: compnerd wrote: > This isn't really a separator, this is the root itself. I think that it > makes sense to name it accordingly.

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

keith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:575 +/// instead> +/// 'redirecting-with': bnbarham wrote: > keith wrote: > > I think `redirecting-with` is fine, and I can't come up with something > >

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

keith accepted this revision. keith added a comment. This revision is now accepted and ready to land. I'm definitely not a VFS expert, but I do think this is much nicer than trying to do the other workarounds with multiple VFSs that you described, I left some minor comments, I reviewed

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

keith added a comment. In D117730#3262622 , @dexonsmith wrote: > @keith, any thoughts on this? IIRC, you'd found a few other bugs while you > were in there which you'd left for later; not sure if this is related to them > or not. This issue wasn't

[PATCH] D116174: [clang] support relative roots to vfs overlays

keith added a comment. This LGTM but I'm interested to hear from folks with more knowledge about the VFS' desired behavior to comment on if this will have any unexpected side effects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

This revision was automatically updated to reflect the committed changes. Closed by commit rGace03d0df4fa: [clang][Darwin] Remove old lld implementation handling (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114974/new/

[PATCH] D114974: [clang][Darwin] Remove old lld implementation handling

keith created this revision. keith added reviewers: int3, MaskRay, oontvoo, thakis. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This now assumes that for the darwin driver any lld is the "new" macho lld implementation.

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3552523ebd: [lld-macho] Remove old macho darwin lld (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 391065. keith marked an inline comment as done. keith added a comment. Remove lld/lib directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files:

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390911. keith added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390910. keith added a comment. Stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390908. keith added a comment. Herald added subscribers: dang, sstefan1, mgrang. Herald added a reviewer: jdoerfert. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. More deletions Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163229 , @int3 wrote: > lgtm. Could you make a post to llvm-dev before landing this? Thanks! Sent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163232 , @MaskRay wrote: > Consider moving the clang driver change to a separate change so that the > removal is a more pure file deletion (other than some build system changes) Fair enough, I'll submit as a follow up

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. I chose to remove the darwinnew / darwinold symlinks here as well. Let me know if you all think we should leave those around for a while for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG86e2af8043c7: reland: [VFS] Use original path when falling back to external FS (authored by keith). Repository: rG

[PATCH] D113832: reland: [VFS] Use original path when falling back to external FS

keith created this revision. keith added a reviewer: dexonsmith. Herald added subscribers: pengfei, hiraditya. keith requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit

[PATCH] D109128: [VFS] Use original path when falling back to external FS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc972175649f4: [VFS] Use original path when falling back to external FS (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 387030. keith added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

keith added a comment. In D113645#3126652 , @kadircet wrote: > I got a couple of concerns about the general ideas in the change. Even though > the convenience of using ~/.config/clangd/config.yaml seems nice, I think > it'll just end up creating

[PATCH] D113645: [clangd] Allow Unix config paths on Darwin

keith created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. keith requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tools-extra. It's common for CLIs

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @JDevlieghere can you take another pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8a9507ef8c: [clang][driver] Fix multiarch output name with -Wl arg (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112767/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. @dexonsmith turns out the test I was adding is broken on main today too. If it's alright with you I will punt that to another diff to not increase the scope of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 383406. keith added a comment. Remove broken test for now Turns out this fails on main as well, so I'll punt this to another change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

keith updated this revision to Diff 383213. keith marked an inline comment as done. keith added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112767/new/ https://reviews.llvm.org/D112767 Files:

[PATCH] D112767: [clang][driver] Fix multiarch output name with -Wl arg

keith created this revision. keith added reviewers: ddunbar, JDevlieghere. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed a `-Wl,-foo` _before_ the source filename, the first `InputInfos`, which is used for

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added a comment. In D111457#3082398 , @mstorsjo wrote: > In D111457#3073726 , @keith wrote: > >> In D111457#3066508 , @mstorsjo >> wrote: >> >>> Wouldn't this one

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:1738 + +TEST_F(VFSFromYAMLTest, RelativePathHitWithoutCWD) { + IntrusiveRefCntPtr BaseFS( So this test case is actually failing. The difference between it and the others

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380821. keith added a comment. Fix test paths on windows Otherwise this resulted in a json string with non-escaped backslashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + dexonsmith wrote: > keith wrote: > > JDevlieghere wrote: > > > I'm pretty sure there was a reason

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380802. keith marked 2 inline comments as done. keith added a comment. Remove `cd` of ExternalFS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files:

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME:

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added a comment. In D111457#3066508 , @mstorsjo wrote: > Wouldn't this one also be solved pretty much the same, but differently, by > changing `if (llvm::sys::path::is_absolute(RemappedFile)) {` into > `is_absolute_gnu`? I think it //could// but

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17386cb4dc89: [clang][Driver] Make multiarch output file basenames reproducible (authored by keith). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added inline comments. Comment at: clang/test/CodeGen/debug-prefix-map.c:24 +// CHECK-NO-MAIN-FILE-NAME: !DIFile(filename: "{{/|C:}}UNLIKELY_PATH{{/|}}empty{{/|}}{{.*}}", +// CHECK-NO-MAIN-FILE-NAME-SAME:directory: "") +// CHECK-NO-MAIN-FILE-NAME:

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 380125. keith added a comment. Improve lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379882. keith added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files: clang/test/VFS/relative-path-errors.c

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379881. keith marked an inline comment as done. keith added a comment. Extract fallback status logic to another function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:1179-1180 + if (ExternalFS) +ExternalFS->setCurrentWorkingDirectory(Path); + JDevlieghere wrote: > I'm pretty sure there was a reason we stopped doing this. There should be >

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 379570. keith added a comment. Fix windows test paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith added a comment. Ok I've updated the diff here based on @dexonsmith's original suggestion, and some offline discussion with @JDevlieghere The new logic remaps the files and statuses, in the fallback to the external FS case, to use the originally requested path. I opted not to use the

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 379559. keith marked 4 inline comments as done. keith added a comment. Update to remap file paths after fetching them from the external FS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. https://reviews.llvm.org/D111587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111352/new/ https://reviews.llvm.org/D111352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. This broke tests on windows (see the new parent revisions in the stack) otherwise the actual change's behavior, outside of the tests, is unchanged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith added a reviewer: probinson. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a reviewer: compnerd. keith added a comment. Adding since you might be interested in this, I think the Swift logic is also derived from this so it might have the same difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On unix systems this logic would not separate the file and directory of the DIFile unless they shared more components at the start than just the root path

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 378796. keith added a comment. Fix slashes for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378725. keith marked 2 inline comments as done. keith added a comment. Allow empty leading on windows This behavior is currently broken, the directory should never be `/` or `C:\` but the logic is broken and only handles `/` Repository: rG LLVM Github

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: rmaz wrote: > `c:\`? Do you mean lowercase or a single slash? I see ~2x the number of uppercase vs lowercase in this codebase

  1   2   >