[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392753. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: clang-

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392696. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address the last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: clang

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392688. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve almost all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files: cl

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

This revision was automatically updated to reflect the committed changes. Closed by commit rG976a74d7d2db: [clangd] Dex Trigrams: Improve query trigram generation (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ http

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 392380. kbobyrev marked an inline comment as done. kbobyrev added a comment. No problem, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-to

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbab7a30ab692: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls… (authored by kbobyrev). Repository: rG LLVM Github Mono

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev updated this revision to Diff 391567. kbobyrev marked an inline comment as done. kbobyrev added a comment. Improve wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files: clang-tools-ex

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev updated this revision to Diff 391566. kbobyrev added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev added a comment. In D114949#3169074 , @kadircet wrote: > thanks! Aww, sorry, I capitalized/reformatted parts of them but missed the rest :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev updated this revision to Diff 391393. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114949/new/ https://reviews.llvm.org/D114949 Files: clang-

[PATCH] D113898: [NFC][clangd] cleaning up llvm-qualified-auto

kbobyrev added a comment. In D113898#3167050 , @kuhnel wrote: > Looking at the documentation, this looks like a bug in the clang-tidy check: > https://releases.llvm.org/13.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability-qualified-auto.html

[PATCH] D113896: [clangd] cleanup of header guard names

kbobyrev added a comment. Also, please mention the In D113896#3166732 , @kuhnel wrote: > @kadircet looks like clang-tidy does not detect missing comments in `#endif`. > It does complain about missing comments for namespaces. E.g. in > `Serialization.h`

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. In D112707#3166703 , @sammccall wrote: > In D112707#3166535 , @kbobyrev > wrote: > >> @sammccall >> >> There is one part of your comment that I couldn't understand, could you >> please

[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This makes IncludeCleaner more u

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. @sammccall There is one part of your comment that I couldn't understand, could you please clarify what you mean bi this? > we can't skip based on a definition (main file or class) that can't stand > alone, usually because of qualifiers. e.g. void foo::bar() {}. FWIW

[PATCH] D113896: [clangd] cleanup of header guard names

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.h:2 +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H +#define LLVM_CLANG_TOOLS_EXTRA_CLANGD_PATHMAPPING_H + Please move the header guard after the comment like we do in the other

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3a4ef35685c: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's… (authored by kbobyrev). Repository: rG LLVM Github Mono

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kbobyrev updated this revision to Diff 391249. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114864/new/ https://reviews.llvm.org/D114864 Files: clang-t

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kbobyrev updated this revision to Diff 390999. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comments, add justification in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114864/new/ https://reviews.llvm.

[PATCH] D114864: [clangd] IncludeClenaer: Don't mark forward declarations of a class if it's declared in the main file

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will mark more headers that

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390643. kbobyrev added a comment. Remove refactoring leftovers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.c

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390641. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:130 + // IWYU pragmas but it needs to be explicitly added to as a preprocessor + // comment handler. PP wants to own the PPCallbacks, so the typical way to + // do both is: sammccal

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 390639. kbobyrev marked an inline comment as done. kbobyrev added a comment. Fix failures, address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 F

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 390631. kbobyrev marked an inline comment as done. kbobyrev added a comment. Change the API, update the patch. It's crashing ATM, investigating the problems. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:47 + const size_t NPOS = std::numeric_limits::max(); + llvm::SmallVector> Next(LowercaseIdentifier.size()); + size_t NextTail = NPOS, NextHead = NPOS; sammccall wrote:

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390627. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

kbobyrev added a comment. Mostly LG, few nits. Comment at: clang-tools-extra/clangd/Headers.h:32 namespace clang { +class NamespaceDecl; namespace clangd { Do we need a forward decl here? Comment at: clang-tools-extra/clangd/Headers.h:42 +p

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390298. kbobyrev added a comment. Slightly improve docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp cl

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390297. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34cc210aa8af: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to… (authored by kbobyrev). Repository: rG LLVM Github Mo

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 390052. kbobyrev added a comment. Add some docs for the helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114623/new/ https://reviews.llvm.org/D114623 Files: clang-tools-extra/clangd/IncludeCle

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 390051. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114623/new/ https://reviews.llvm.org/D114623 Files: clang-

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0ca5a0eaa1: [clangd] Record information about non self-contained headers in IncludeStructure (authored by kbobyrev). Repository: rG LLVM Github

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + sammccall wrote: > kbobyrev wrote: > > sammccall wrote: > > > could consider `friend class RecordHe

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 390024. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Get rid of the setter in IncludeStructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D11437

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + sammccall wrote: > could consider `friend class RecordHeaders`, either is ugly, up to you That was

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When a symbol comes f

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389953. kbobyrev added a comment. Get the changes back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-extra/clangd/CodeComplete.

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389952. kbobyrev added a comment. Change base to D114370 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-ext

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389950. kbobyrev added a comment. [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents When a symbol comes from the non self-contained header, we recursively uplift the file we consider used to the first includer that

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389947. kbobyrev added a comment. Leave the feature changes (IncludeCleaner bits) out of this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-to

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389946. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address review comments. Next step: split this patch into two, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad897778638: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced… (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114525: [clang] Change ordering of PreableCallbacks to make sure PP can be referenced in them

kbobyrev created this revision. kbobyrev added reviewers: kadircet, sammccall. kbobyrev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, BeforeExecute is called before BeginSourceFile which does not allow using PP in the callbacks

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389457. kbobyrev added a comment. Untangle BeforeExecute call ordering change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-extra/clangd/Code

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389454. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Herald added a project: clang. Resolve review comments. This turned into a rather large refactoring change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:262 + ID != SM.getMainFileID() && FE && + !isSelfContainedHeader(PP, ID, FE);) { + ID = SM.getFileID(SM.getIncludeLoc(ID)); sammccall wrote: > it seems li

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389183. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-to

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev added a comment. In D114370#3148143 , @sammccall wrote: > The ReferencedFiles is designed to make add() as cheap as possible, and do > any per-file logic after folding the fileIDs together. > This keeps that loop tighter and also isolates the co

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389131. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When a symbol comes from the non

[PATCH] D114287: [clangd] IncludeCleaner: Mark possible expr resolutions as used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5f20372a82f: [clangd] IncludeCleaner: Mark possible expr resolutions as used (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

kbobyrev updated this revision to Diff 388816. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114287/new/ https://reviews.llvm.org/D114287 Files: clang-

[PATCH] D114287: [clangd] IncludeCleaner: Traverse unresolved expressions

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 388461. kbobyrev added a comment. Add improvements for identifier trigram generation and make query & id generators consistent with each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https:/

[PATCH] D114034: [clang-tidy] fix debug-only test failure

kbobyrev added a comment. In D114034#3141446 , @mattbeardsley wrote: > @dstenb Thanks for the confirmation! > > @kbobyrev Sorry about my mixup! Would you be able to help me commit this? Done! Thank you for the patch! Repository: rG LLVM Github Monor

[PATCH] D114034: [clang-tidy] fix debug-only test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rG85e03cb7ebac: [clang-tidy] fix debug-only test failure (authored by mattbeardsley, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1140

[PATCH] D114034: [clang-tidy] fix debug-only test failure

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! I skimmed through the original patch and couldn't understand the `RenameFcn` part, thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will allow the IncludeClea

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 387615. kbobyrev added a comment. Add a small comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp clan

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are the trigrams for quer

[PATCH] D113974: [clangd] Put additional qualifiers to enum constants not declared as "enum class"

kbobyrev planned changes to this revision. kbobyrev added a comment. Actually, I'm not sure this change is worth it. Maybe the intent of not having `enum class` is actually making the constants discoverable from the outer scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113974: [clangd] Put additional qualifiers to enum constants not declared as "enum class"

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a cheap "fix" of the pro

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

kbobyrev added a comment. Hey, I'm really sorry, I missed this, too but I just landed the patch for you, apologies for such a huge delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.org/D97265 ___

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda168dd875bf: [clang] Allow clang-check to customize analyzer output file or dir name (authored by OikawaKirie, committed by kbobyrev). Herald added

[PATCH] D113889: [NFC] disabling clang-tidy check readability-identifier-naming in Protocol.h

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:39 +/* This file is using the LSP syntax for identifier names which is different + from the LLVM coding standard. To avoid the clang-tidy warnings, we're Nit: we're only using C-sty

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev planned changes to this revision. kbobyrev added a comment. Will split the patch in two, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112707/new/ https://reviews.llvm.org/D112707

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev added a comment. Oh, sorry, I marked it as "changes intended" so that you could know it's not review-ready yet :) I was just playing around with it and previewing to see how it would feel to have a somewhat working solution. I didn't really implement the feature (add the proper header

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev planned changes to this revision. kbobyrev added a comment. This is POC, I need to deal with forward decls and definitions from D112707 firs. Otherwise, this introduces too much noise (LLVM really has *lots* of forward decls that make almost no sense).

[PATCH] D113262: [clangd] Allow IncludeCleaner to replace unused header with transitively used

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf47564ea87a5: [clangd] IncludeCleaner: Skip non self-contained headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383378. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: cl

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

This revision was automatically updated to reflect the committed changes. Closed by commit rG32f102912493: [clangd] Track performance of IncludeCleaner (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kbobyrev updated this revision to Diff 383278. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112783/new/ https://reviews.llvm.org/D112783 Files: clang-

[PATCH] D112783: [clangd] Track performance of IncludeCleaner

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383253. kbobyrev added a comment. Add a header guard in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev added a comment. In D112707#3093876 , @sammccall wrote: > What's the purpose of this patch at a high level? Was it triggered by a real > example? > IIUC it's avoiding false negatives, where we're using a class and an > otherwise-unused header f

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383250. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383086. kbobyrev added a comment. Remove stale FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-to

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:247 for (const Inclusion &MFI : Structure.MainFileIncludes) { // FIXME: Skip includes that are not self-contained. if (!MFI.HeaderID) { sammccall wrote: > this is

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 383085. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-

[PATCH] D112707: [clangd] IncludeCleaner: Be more conservative in marking RecordDecl usage

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. For expression with RecordDecl t

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382970. kbobyrev added a comment. Revert docs change that is no longer true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/Includ

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382969. kbobyrev added a comment. Remove redundant changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp cl

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382968. kbobyrev added a comment. Put the check into the right place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleane

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev planned changes to this revision. kbobyrev added a comment. Aww, I think this is the wrong place to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 __

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev updated this revision to Diff 382955. kbobyrev added a comment. Update the docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112695/new/ https://reviews.llvm.org/D112695 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools

[PATCH] D112695: [clangd] IncludeCleaner: Skip non self-contained headers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Headers without include guards

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112652/new/ https://reviews.llvm.org/D112652 __

[PATCH] D112652: [clangd] Avoid expensive checks of buffer names in IncludeCleaner

kbobyrev added a comment. Thank you for taking care of this! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:261 +if (!FE) { + assert(isSpecialBuffer(FID, SM)); + continue; Implementation-wise, this seems like the right place to drop nonex

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev added a comment. In D112608#3090971 , @sammccall wrote: > I'll try some things out and send a patch... Oh, okay, I won't do mine then to avoid crashing into each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev added a comment. In D112608#3090910 , @sammccall wrote: > Sorry to be late to the party, just some efficiency concerns No problem, thank you for the comments, I'll send a follow-up! Comment at: clang-tools-extra/clangd/Includ

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22079c61a823: [clangd] IncludeCleaner: Do not process locations in built-in files (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHA

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:245 +int y = CLI; + kadircet wrote: > you can change this to `int y = CLI + __llvm__` to explicitly check for both > CLI and built-in macros. Ahh, that's

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev updated this revision to Diff 382713. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112608/new/ https://reviews.llvm.org/D112608 Files: clang-

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev updated this revision to Diff 382608. kbobyrev added a comment. Also handle the Command-Line defines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112608/new/ https://reviews.llvm.org/D112608 Files: clang-tools-extra/clangd/IncludeClea

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4723785c190: [clangd] IncludeCleaner: Don't warn on system headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

kbobyrev updated this revision to Diff 382576. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112571/new/ https://reviews.llvm.org/D112571 Files: clang-t

<    1   2   3   4   5   6   7   8   9   10   >