[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

kromanenkov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:199 - for (const auto : llvm::reverse(PathRange)) -PathList = prependCXXBase(I, PathList); + llvm::SmallPtrSet BaseTypes; + for (const auto : PathList)

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

kromanenkov added a comment. Looks like you run formatter on the whole file, maybe narrow down its scope a little? For example, only for the touched function? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95307/new/

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

kromanenkov added a comment. A few comments. Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:19 +if (S.second) + return S; + Maybe I miss something, but do not we return StringRef to temporary string going out of scope here? Same

[PATCH] D39800: [analyzer] pr34404: Fix a crash on pointers to members in nested anonymous structures.

kromanenkov added a comment. @NoQ Do we need to change a `DeclaratorDecl` field in PointerToMember SVal to something more common, like `ValueDecl`, to support `IndirectFieldDecl` as well? https://reviews.llvm.org/D39800 ___ cfe-commits mailing

[PATCH] D31887: [clangd] Add documentation page

kromanenkov added inline comments. Comment at: docs/clangd.rst:10 + +:program:`clangd` is an implementation of the `Languge Server Protocol `_ leveraging Clang. +Clangd's goal is to provide language "smartness" features

[PATCH] D28033: [analyzer] Treat pointers to static member functions as function pointers

kromanenkov accepted this revision. kromanenkov added a comment. This revision is now accepted and ready to land. Looks good to me, apart from a very small cavil introduced in not even your code. Thanks for not leaving pointers to static member functions out of account!

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov updated this revision to Diff 81598. kromanenkov added a comment. Fix issues pointed by @dcoughlin and rebase patch on master. https://reviews.llvm.org/D25475 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov updated this revision to Diff 81352. kromanenkov added a comment. Thanks for your comments, Devin! You were right about the list of path specifiers construction order, so i fix it. Now the base specifier list is being used for figuring out the correct subobject field. Also this diff

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:899 +case UO_AddrOf: { + // Process pointer-to-member address operation + const Expr *Ex = U->getSubExpr()->IgnoreParens(); kromanenkov wrote: > dcoughlin wrote:

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:899 +case UO_AddrOf: { + // Process pointer-to-member address operation + const Expr *Ex = U->getSubExpr()->IgnoreParens(); dcoughlin wrote: > Just sticking this

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov marked an inline comment as done. kromanenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:217 + + llvm::ImmutableList consCXXBase( + const CXXBaseSpecifier *CBS, NoQ wrote: > Hmm, is

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov updated this revision to Diff 79560. kromanenkov added a comment. Thanks for your comments, Artem! Make function name less ambiguous. Also I take liberty to update analogical function name. https://reviews.llvm.org/D25475 Files:

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added a comment. ping https://reviews.llvm.org/D25475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits