[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 549745. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 549034. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547574. Krishna-13-cyber added a comment. - Update section of Execution Results Handling in Clang-REPL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547529. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547231. Krishna-13-cyber added a comment. - Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst

[PATCH] D156877: Update Clang-REPL docs with removing the redundant subsections

Krishna-13-cyber created this revision. Krishna-13-cyber added a reviewer: v.g.vassilev. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang documentation is currently displaying 3

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: v.g.vassilev, davidlange6, QuillPusher. Herald added a subscriber: arphaman. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4466998 , @aaron.ballman wrote: > I think the existing wording is pretty reasonable, changing "non-static > declaration" into "extern declaration" isn't really giving the user any more > information to help

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber added a comment. In D152109#4464563 , @v.g.vassilev wrote: > LGTM! If you don't have commit access I can commit this on your behalf. Yes, It would be great if you could land it on my behalf! Thanks. Repository: rG LLVM Github

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4463163 , @tbaeder wrote: > Ping. Thanks for the ping! Does this require any further modification? I think if we will have to change the whole set of diagnostics if we go with this change of `pick exactly

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 536221. Krishna-13-cyber marked 2 inline comments as done. Krishna-13-cyber added a comment. - Update with addressing the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber added a comment. In D149000#4420607 , @aaron.ballman wrote: > LGTM! There's still a formatting issue in warn-tautological-compare.c but I > can fix that up when landing, assuming you still need me to land this on your > behalf. (If

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 531243. Krishna-13-cyber removed a reviewer: Quuxplusone. Krishna-13-cyber added a comment. - Update with the given suggestion - Add release notes Thanks a lot @aaron.ballman for the instant assistance. Repository: rG LLVM Github Monorepo

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 530227. Krishna-13-cyber added a comment. - Update with addressing the comments - Update with example of Dynamic library usage in repl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber updated this revision to Diff 529287. Krishna-13-cyber added a comment. - Update with addressing the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://reviews.llvm.org/D152109 Files:

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: v.g.vassilev, QuillPusher, davidlange6. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update Clang-repl documentation

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4288149 , @Krishna-13-cyber wrote: > I have tried a little modification from my side thinking on a beneficial > note. I will make the changes to all the other test files as well if this > diagnostic

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 517151. Krishna-13-cyber added a comment. - Updated with re-adding the required diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 Files:

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516857. Krishna-13-cyber added a comment. - Updated with reviewed changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 Files:

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516397. Krishna-13-cyber added a comment. - Update with addition of testcase - There is an issue for which the build fails,actually when I replace the diagnostic by `comparison of address of 'x' not equal to a null pointer is always true` in

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516201. Krishna-13-cyber added a comment. - Update with diagnostic addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 Files:

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516087. Krishna-13-cyber added a comment. - Apologies for uploading some other/incorrect diff - Updated Diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: aaron.ballman, tbaeder, Quuxplusone. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch solves the issue

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 515843. Krishna-13-cyber added a comment. I have tried a little modification from my side thinking on a beneficial note. I will make the changes to all the other test files as well if this diagnostic representation goes well after mentor review.

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber added a comment. In D147888#4274763 , @cjdb wrote: > I think we should fundamentally rethink this entire category of diagnostic. > Rather than having a static diagnostic per offence stating //what// happened, > we should instead have a

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 512848. Krishna-13-cyber added a comment. - Updated with removing redundant flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147888/new/ https://reviews.llvm.org/D147888 Files:

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: tbaeder, cjdb, aaron.ballman. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch aims to improve the diagnostic

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 511630. Krishna-13-cyber added a comment. Thanks a lot everyone for helping me out with my first patch. I have uploaded the patch again after rebase. Yes, It would be great if you could land it on my behalf. Name: Krishna Narayanan Email: Thanks

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 511181. Krishna-13-cyber added a comment. - Updated with the diagnostic messages (comments for test cases) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 510909. Krishna-13-cyber added a comment. - Updated with release note - I had tried adding more text to the `expected-error` but it already gives a diagnostic of `static assertion failed due to requirement` currently. If I try additions to

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 510186. Krishna-13-cyber added a comment. - Updated diff with `git clang-format HEAD~1` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 Files:

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 509632. Krishna-13-cyber added a comment. Herald added subscribers: llvm-commits, kadircet, arphaman. Herald added a project: LLVM. - Updated patch - Added testcases for chained operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 509589. Krishna-13-cyber edited the summary of this revision. Krishna-13-cyber added a comment. This patch aims to remove some redundant cases of static assert messages where the expansions are particularly unhelpful. In this particular patch, we

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 509249. Krishna-13-cyber added a comment. I have removed the redundant comments and have moved the `if' condition above with the ongoing conditional statement (to avoid printing obvious expressions). - Updated static_assert warning message - Added

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 508297. Krishna-13-cyber added a comment. Updated with the new test cases and implemented the logic suggested for ignoring the BO_LOr operators at the top level. My sincere apologies @tbaeder that I could not place this logic at the first instance.

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber added a comment. The above Binary operator test case says that there are two Boolean expressions,**UsefulToPrintExpr** says we can avoid to print these expressions as they are don't need a note and are understandable. So if we go by this we will have to remove the note.By this

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 507413. Krishna-13-cyber added a comment. Have worked on the top level with Boolean literals unlike the previous diffs.I have updated the test case as well with this new upcoming change. Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 507113. Krishna-13-cyber added a comment. I have updated the patch without removing the whole of the previous block.I have added a condition to find the case where we don't need a diagnostic message to be printed or warned. Repository: rG LLVM

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: tbaeder, cjdb. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are some simple messages where an expansion isn't

[PATCH] D106674: Runtime for Interop directive

sriharikrishna marked 3 inline comments as done. sriharikrishna added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:239-242 + if (interop_val->interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list,

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 381801. sriharikrishna marked 16 inline comments as done. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 381800. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files:

[PATCH] D106674: Runtime for Interop directive

sriharikrishna marked an inline comment as not done. sriharikrishna added inline comments. Comment at: openmp/libomptarget/src/interop.cpp:198-201 + if (interop_type == kmp_interop_type_tasksync) { +__kmpc_omp_wait_deps(loc_ref, gtid, ndeps, dep_list, ndeps_noalias, +

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 372329. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362524. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files:

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362280. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files:

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362269. sriharikrishna added a comment. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files:

[PATCH] D106674: Runtime for Interop directive

sriharikrishna updated this revision to Diff 362266. sriharikrishna added a comment. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Runtime for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 362070. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361913. sriharikrishna marked an inline comment as done. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna marked an inline comment as done. sriharikrishna added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6330-6331 + if (const auto *C = S.getSingleClause()) { +llvm::Value *InteropvarPtr = +

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361186. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361079. sriharikrishna added a comment. OMPIRBuilder for Interop directive. Squashed commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358631. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files:

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358587. sriharikrishna added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna created this revision. sriharikrishna added reviewers: jdoerfert, ABataev, RaviNarayanaswamy. Herald added a subscriber: hiraditya. sriharikrishna requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM.