[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 492684. paperchalice added a comment. Use `LLVM_LIBRARY_OUTPUT_INTDIR`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 Files:

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice created this revision. paperchalice added reviewers: phosek, Ericson2314. Herald added a subscriber: Enna1. Herald added a project: All. paperchalice requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers:

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 480054. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 480025. paperchalice added reviewers: tstellar, MaskRay. paperchalice added a comment. Herald added a subscriber: StephenFan. Use genex `$` due to `CMAKE_CFG_INTDIR` is deprecated since cmake 3.21. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. Ping @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. Ping @Ericson2314 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 475706. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 475696. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/lib/Headers/CMakeLists.txt:285 +include(GetClangResourceDir) +get_clang_resource_dir(output_dir PREFIX ${LLVM_BINARY_DIR}/$ SUBDIR include) set(out_files)

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice updated this revision to Diff 474715. paperchalice added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add cmake module to handle clang resource dir. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice updated this revision to Diff 471717. paperchalice added a comment. Add test on Unix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 Files: clang/lib/Driver/Driver.cpp

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. I would appreciate if someone can commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-commits mailing

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. In D136940#3893391 , @MaskRay wrote: > `clang/test/Driver/config-file3.c` tests `--config-user-dir=` but I cannot > think of a portable way testing this. > `RUN: echo ~; %clang -### --config-user-dir=~ ...` doesn't work as

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice updated this revision to Diff 471494. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice created this revision. paperchalice added a reviewer: MaskRay. paperchalice added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. paperchalice requested review of this revision. Herald added a subscriber: cfe-commits. This patch allows users to

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice updated this revision to Diff 470992. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice added a comment. Thanks a lot if someone can commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 ___ cfe-commits mailing list

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice created this revision. paperchalice added reviewers: phosek, Ericson2314. paperchalice added projects: LLVM, clang, OpenMP. Herald added a subscriber: Enna1. Herald added a project: All. paperchalice requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D134597: [CMake] install clang and other resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice added a comment. Ping @phosek, but may need suggestions from other reviewers... Thanks in advance if someone can commit this change. Comment at: openmp/CMakeLists.txt:80 if(${OPENMP_STANDALONE_BUILD}) set(LIBOMP_HEADERS_INSTALL_PATH

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice updated this revision to Diff 466249. paperchalice added a comment. Herald added subscribers: llvm-commits, openmp-commits, Sanitizers, Enna1. Herald added projects: Sanitizers, OpenMP, LLVM. Let other projects consider CLANG_RESOURCE_DIR too. Repository: rG LLVM Github Monorepo

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice added a comment. If it is ready to land, could you commit this change? I don't have commit right, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134597/new/ https://reviews.llvm.org/D134597

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice updated this revision to Diff 463114. paperchalice added a comment. Update the //output_dir//. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134597/new/ https://reviews.llvm.org/D134597 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice created this revision. paperchalice added a reviewer: phosek. paperchalice added a project: clang. Herald added a project: All. paperchalice requested review of this revision. Herald added a subscriber: cfe-commits. When `CLANG_RESOURCE_DIR` is not empty, clang will look up builtin