[PATCH] D71226: Also synthesize _cmd and self for properties

liuliu added a comment. Thanks. Verified in our codebase this patch indeed fixed the crashes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___ cfe-commits

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. No problem! I have a custom patch that isn't as nice but get the job done. Let me know when you put new diff out and I can test it on our codebase again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. We don't use PCH :) I arc patched the latest diff, still have that crash. More strangely, I tried this latest diff on previously simplistic test case and it crashes now: #import @interface SCTestMainEntity : NSObject @property (nonatomic, readonly, direct)

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu marked an inline comment as done. liuliu added inline comments. Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4839 + ObjCMethod->createImplicitParams(Context, ObjCMethod->getClassInterface()); + Yeah, I applied this change. As I said, for my trivial

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. With this latest fix applied on top of b220662a45c8067a2ae485ae34c1138d93506df9 , in our company's internal code, I still encounter the crash. Showing All Messages

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. Did you mean the linkage issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org