Re: Patch for Bug 30413, including test case

Yes, please, if you don't mind! I'd like to commit both the path and the unit test, if possible. Thanks, David > On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote: > > Do you need someone to commit this patch for you? > >> On Mar 10, 2017, at 6:44 AM, Lobron, David

Re: Patch for Bug 30413, including test case

Hi Akira, Thank you very much! Please let me know if I need to take any further steps beyond this email to cfe-commits in order for the patch and the unit test to be committed. Thanks, David > On Mar 9, 2017, at 4:46 PM, Akira Hatanaka wrote: > > Hi David, > > The

Re: Patch for Bug 30413, including test case

Hi Akira, > My concern is that the patch changes the encoding of @encode(id) on > Darwin, which I think isn’t what you are trying to fix. If you compile the > following code with command “clang -cc1 -triple x86_64-apple-macosx”, the > type encoding changes after applying the patch. > > const

Re: Patch for Bug 30413, including test case

Hi Akira, Pardon my slowness in addressing your question. > This patch changes the encoding of an id conforming to a protocol, which I > think was not intended: For example: > > @encode(id) > > Would passing IVD to the call to getObjCEncodingForType in > CGObjCGNU::GenerateClass solve the

Re: Patch for Bug 30413, including test case

coding of an id conforming to a protocol, which I > think was not intended: For example: > > @encode(id) > > Would passing IVD to the call to getObjCEncodingForType in > CGObjCGNU::GenerateClass solve the problem? > >> On Feb 15, 2017, at 1:59 PM, Lobron, David via cfe-comm

Patch for Bug 30413, including test case

Hi All, I am re-submitting my patch for Bug 30413, this time with a test case included as well (ivar-type-encoding.m). The test case file should be added to clang/test/CodeGenObjC. The test verifies that correct metadata is emitted by clang for an object-valued instance variable. I've

Re: Patch for Bug 30413

ducer to use as a test case? Ideally, you'd add a > regression test to clang/test/CodeGenObjC, or extend an existing one. > > vedant > >> On Feb 7, 2017, at 6:42 PM, Lobron, David via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> >> Hello clang de

Patch for Bug 30413

Hello clang developers, I discovered a bug that affects Objective-C programs compiled with clang on Linux. The current code was not emitting Objective-C class name metadata, which made it impossible for programs to do runtime type introspection. I opened a bug report that describes the