[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4100387 , @aaron.ballman wrote: > @diseraluca -- do you need this cherry picked into Clang 16 or are you fine > if this goes into Clang 17 instead? Sorry for checking in so late, I noticed the notifications only

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca updated this revision to Diff 492042. diseraluca added a comment. Fixed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140756/new/ https://reviews.llvm.org/D140756 Files: clang/bindings/python/clang/cindex.py

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca reopened this revision. diseraluca added a comment. This revision is now accepted and ready to land. When I pushed the patch the tests produced failures in buildbot. I reverted the patch as I did not have the time to check what was happening. I've now had time to check and the

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddbe14084da7: Add clang_CXXMethod_isExplicit to libclang (authored by diseraluca). Changed prior to commit:

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4051383 , @aaron.ballman wrote: > LGTM aside from some minor things you can correct when landing. > Thank you for the great suggestions! I'll try to correct it as soon as possible, hopefully this weekend.

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

diseraluca added a comment. In D137246#3919795 , @aaron.ballman wrote: > In D137246#3911881 , @diseraluca > wrote: > >> I finally had some time to look into the pre-merge failure. I couldn't >> replicate it on

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c67cf0a7fdc: Add clang_CXXMethod_isMoveAssignmentOperator to libclang (authored by diseraluca). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

diseraluca added a comment. I finally had some time to look into the pre-merge failure. I couldn't replicate it on my machine by following https://buildkite.com/llvm-project/premerge-checks/builds/119952#01843856-e8c7-4709-89c6-d52d0286862a . Looking at the log it does not seem related to the

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

diseraluca added a comment. In D136604#3882192 , @aaron.ballman wrote: > In D136604#3881949 , @diseraluca > wrote: > >> In D136604#3879928 , >> @aaron.ballman wrote:

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

diseraluca added a comment. In D136604#3879928 , @aaron.ballman wrote: > LGTM! > > Would you like to obtain commit access to land this one on your own > (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)? If not, > that's fine, I can

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of

[PATCH] D133195: Expose QualType::getNonReferenceType in libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The method is now wrapped by

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca updated this revision to Diff 456116. diseraluca added a comment. Fixed some typos in the added documentation of `clang_getUnqualifiedType`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132749/new/ https://reviews.llvm.org/D132749

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca added a comment. In D132749#3752419 , @aaron.ballman wrote: > > Welcome to the community! Thank you for the kind welcome! > Feel free to put up a new review for that and add me as a reviewer, I'm happy > to look at it Thank you, I'll be

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca updated this revision to Diff 456099. diseraluca added a comment. Added a note to the release-notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132749/new/ https://reviews.llvm.org/D132749 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca added a comment. I recently encountered a few cases, at work, as an employee of The Qt Company, where we would have liked to have access to `getUnqualifiedType` in libclang. I found a precedence on the old mailing list, from 2018

[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The method is now wrapped by