Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lhchavez marked 9 inline comments as done. lhchavez added a comment. Addressed all comments. PTAAL. https://reviews.llvm.org/D24319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lhchavez updated this revision to Diff 72064. lhchavez added a comment. Addressed lovato's comments https://reviews.llvm.org/D24319 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format === ---

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lhchavez added a comment. Gentle ping. Is there anything else that needs addressing? Did I miss anything? https://reviews.llvm.org/D24319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lhchavez marked 2 inline comments as done. Comment at: cfe/trunk/tools/clang-format/git-clang-format:323 @@ -312,1 +322,3 @@ +def create_tree_from_commit(commit, filenames): + """Create a new git tree with the given files from `commit`. lhchavez wrote: >

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez updated this revision to Diff 71104. lhchavez added a comment. Rebased to r281293 https://reviews.llvm.org/D24401 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format === ---

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lhchavez marked 3 inline comments as done. Comment at: cfe/trunk/tools/clang-format/git-clang-format:93 @@ -92,1 +92,3 @@ help='default commit to use if none is specified'), + p.add_argument('--single-commit', action='store_true', + help=('run

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lhchavez updated this revision to Diff 71103. lhchavez added a comment. Using lodato's proposed interface. This patch: - Accepts an arbitrary number of commits as arguments. Validation will be done in main(), such that two commits are valid only when running in --diff mode. - Allows diffing two

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez updated this revision to Diff 71087. lhchavez added a comment. Using arcanist to fix the paths as well https://reviews.llvm.org/D24401 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez updated this revision to Diff 71075. lhchavez added a comment. Generated the diff properly this time, and it now shows full context. Repository: rL LLVM https://reviews.llvm.org/D24401 Files: cfe/trunk/tools/clang-format/git-clang-format Index:

[PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez created this revision. lhchavez added a reviewer: djasper. lhchavez added subscribers: cfe-commits, srhines. lhchavez set the repository for this revision to rL LLVM. This change adds "java" to the list of known extensions that clang-format supports. Repository: rL LLVM

[PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lhchavez created this revision. lhchavez added a reviewer: djasper. lhchavez added subscribers: srhines, cfe-commits. lhchavez set the repository for this revision to rL LLVM. lhchavez added a project: clang-c. When building pre-upload hooks using git-clang-format, it is useful to limit the