[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

madsravn added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), + Value->getSourceRange());

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

madsravn added a comment. This patch has now been merged. https://github.com/llvm/llvm-project/commit/bd324fa2273778430a4fdf8371fec5d64d2231bb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61861/new/ https://reviews.llvm.org/D61861

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

madsravn added a comment. In D61861#1500900 , @J-Camilleri wrote: > In D61861#1500868 , @madsravn wrote: > > > Looks good to me :) > > > Thanks for the review and suggestion, who should I contact now in order to >

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

madsravn accepted this revision. madsravn added a comment. This revision is now accepted and ready to land. Looks good to me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61861/new/ https://reviews.llvm.org/D61861

[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

madsravn added a comment. Besides my one comment this looks good to me. Comment at: clang-tools-extra/test/clang-tidy/readability-delete-null-pointer.cpp:9 // #1 - if (p) { // #2 + if (p /**/) { // #2 delete p; Would you mind creating a new test

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

This revision was automatically updated to reflect the committed changes. Closed by commit rL301167: [clang-tidy] New check: modernize-replace-random-shuffle. (authored by madsravn). Changed prior to commit: https://reviews.llvm.org/D30158?vs=96303=96362#toc Repository: rL LLVM

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. In https://reviews.llvm.org/D30158#734810, @aaron.ballman wrote: > This continues to LGTM; do you need someone to land the patch for you? I will remove the extra newline and land the patch tomorrow. Thanks! :) https://reviews.llvm.org/D30158

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 96303. madsravn added a comment. Small changes to code due to comments. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. In https://reviews.llvm.org/D30158#702778, @jroelofs wrote: > In https://reviews.llvm.org/D30158#702760, @madsravn wrote: > > > In https://reviews.llvm.org/D30158#699342, @jroelofs wrote: > > > > > In https://reviews.llvm.org/D30158#699132, @madsravn wrote: > > > > > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. In https://reviews.llvm.org/D30158#699342, @jroelofs wrote: > In https://reviews.llvm.org/D30158#699132, @madsravn wrote: > > > In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote: > > > > > In https://reviews.llvm.org/D30158#696534, @madsravn wrote: > > > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote: > In https://reviews.llvm.org/D30158#696534, @madsravn wrote: > > > Any updates on this? > > > Have you run it over the test suite on the revision before random_shuffle was > removed from libc++? I

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. Any updates on this? https://reviews.llvm.org/D30158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. Looks good for the two tests the are for `random_shuffle` in llvm libc++. https://reviews.llvm.org/D30158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added a comment. In https://reviews.llvm.org/D30158#689904, @aaron.ballman wrote: > Out of curiosity, have you run this over libc++ or libstdc++ test suites > involving `std::random_shuffle`? If so, were the results acceptable? I haven't. Good idea. I will get onto that. I don't have

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 90223. madsravn added a comment. Last small changes based on comments. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > madsravn wrote: > > aaron.ballman wrote: > > > madsravn wrote: > > > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > madsravn wrote: > > aaron.ballman wrote: > > > madsravn wrote: > > > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn marked an inline comment as done. madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > madsravn wrote: > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn marked 9 inline comments as done. madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:77 + + auto Diag = [=]() { +std::string Message = ReplaceMessage; aaron.ballman wrote: > Is there a reason this needs

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 90148. madsravn added a comment. Updated patch according to comments by Ballman. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 89919. madsravn added a comment. Minor update to fix spelling mistake. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 89817. madsravn marked an inline comment as done. madsravn added a comment. Made small changes based on comments. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn marked 18 inline comments as done. madsravn added inline comments. Comment at: test/clang-tidy/modernize-replace-random-shuffle.cpp:50 + // CHECK-MESSAGE: [[@LINE-1]]:3: warning: do not use 'random_shuffle'. It is deprecated and replaced by 'shuffle'. The old user

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 89543. madsravn added a comment. Updated the code based on comments received. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:81 + Stream << "shuffle("; + FirstArgument->printPretty(Stream, nullptr, Ctx.getPrintingPolicy()); + Stream << ", "; xazax.hun wrote: > madsravn wrote: > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:81 + Stream << "shuffle("; + FirstArgument->printPretty(Stream, nullptr, Ctx.getPrintingPolicy()); + Stream << ", "; xazax.hun wrote: > madsravn wrote: > >

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:30 +" The old user defined 'RandomFunction' is not usable for 'shuffle'. You " +"need to " +"make additional changes if you want a specific random function.";

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn created this revision. Herald added subscribers: JDevlieghere, mgorny. random_shuffle was deprecated by C++14 and will be removed by C++17. This check will find and replace usage of random_shuffle with its modern counterpart (shuffle). https://reviews.llvm.org/D30158 Files:

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

This revision was automatically updated to reflect the committed changes. Closed by commit rL294912: [clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work… (authored by madsravn). Changed prior to commit: https://reviews.llvm.org/D29726?vs=88123=88143#toc Repository:

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

madsravn updated this revision to Diff 88123. madsravn marked an inline comment as done. madsravn added a comment. Added comment in CHECK-FIX to ensure the line we are referring to is uniquely identified. https://reviews.llvm.org/D29726 Files:

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

madsravn marked 3 inline comments as done. madsravn added inline comments. Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:46 + DeleteExpr, DeleteMemberExpr, + compoundStmt(anyOf(has(DeleteExpr), has(DeleteMemberExpr)), +

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

madsravn updated this revision to Diff 87829. madsravn added a comment. Small change to check. Minor changes to the lit test. https://reviews.llvm.org/D29726 Files: clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tidy/readability/DeleteNullPointerCheck.h

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

madsravn created this revision. Made a small fix to readability-delete-null-pointer check such that it includes class members. https://reviews.llvm.org/D29726 Files: clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tidy/readability/DeleteNullPointerCheck.h

[PATCH] D29018: [clang-tidy] Ignore implicit functions in performance-unnecessary-value-param

madsravn added a comment. Looks good to me. Nice touch by solving with implicit. https://reviews.llvm.org/D29018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28614: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value

madsravn added a comment. Looks good to me. https://reviews.llvm.org/D28614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28180: Fixing small errors in libAST Matcher Tutorial.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290766: [clang] Minor fix to libASTMatcherTutorial (authored by madsravn). Changed prior to commit: https://reviews.llvm.org/D28180?vs=82735=82742#toc Repository: rL LLVM

[PATCH] D28180: Fixing small errors in libAST Matcher Tutorial.

madsravn created this revision. madsravn added reviewers: aaron.ballman, malcolm.parsons. madsravn added a subscriber: cfe-commits. The tutorial contains a few errors which results in code not being able to compile. One error was described here: https://llvm.org/bugs/show_bug.cgi?id=25583 . I

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

This revision was automatically updated to reflect the committed changes. Closed by commit rL290747: [clang-tidy] Add check 'misc-string-compare'. (authored by madsravn). Changed prior to commit: https://reviews.llvm.org/D27210?vs=82521=82721#toc Repository: rL LLVM

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 82521. madsravn added a comment. Changes based on comments. Shortened the ast matcher. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn added inline comments. Comment at: clang-tidy/misc/StringCompareCheck.cpp:37 + hasArgument(0, expr().bind("str2")), argumentCountIs(1), + callee(memberExpr(has(implicitCastExpr(anyOf( +

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 82518. madsravn added a comment. Reviews based on comments. Removed check for suspicious string compare. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn marked 2 inline comments as done. madsravn added inline comments. Comment at: clang-tidy/misc/MiscStringCompareCheck.h:24 +/// http://clang.llvm.org/extra/clang-tidy/checks/misc-string-compare-check.html +class MiscStringCompareCheck : public ClangTidyCheck { +public:

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 82513. madsravn added a comment. Updated according to comments. I have decided to keep the fixit for match1 a FIXME. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 81885. madsravn added a comment. Small changes made by suggestions. strCompare is now with uppercase: StrCompare Checking for str.compare(str) == {-1,1} as well. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 81610. madsravn added a comment. Updated the matcher to find suggested occurences. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 81260. madsravn added a comment. Updated matcher. Made fixits for some cases Updated the documentation. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 80177. madsravn added a comment. Did as comments suggested: Fixed the description about compare returning -1, 0 or 1. Fixed the ast matcher to only find compare with one argument. Clang-formatted everything. Added a new test (str.compare("foo")) and wrote

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79961. madsravn added a comment. Fixed broken tests. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp clang-tidy/misc/StringCompareCheck.h

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79958. madsravn marked 5 inline comments as done. madsravn added a comment. Updated according to comments. Still missing fixit. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79788. madsravn added a comment. Trimmed down the ast matcher a little. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79747. madsravn marked 2 inline comments as done. madsravn added a comment. Added integerLiteral on both sides of the == operator. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79729. madsravn marked 3 inline comments as done. madsravn added a comment. Diff reflecting changes suggested by comments. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79624. madsravn added a comment. Updated per comments https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp clang-tidy/misc/StringCompareCheck.h

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn removed rL LLVM as the repository for this revision. madsravn updated this revision to Diff 79610. madsravn added a comment. Updated the patch to include changes suggested by comments. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt