[PATCH] D54405: Record whether a AST Matcher constructs a Node

cfe-commits added a subscriber: aaron.ballman. cfe-commits added a comment. I don’t really have much more to add here except to refer you to the style guide: https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable Specifically this line: “Use auto if and

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

cfe-commits added a comment. - F7238787: msg-7222-125.txt Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51847: Print correctly dependency paths on Windows

cfe-commits added a comment. Lgtm - F7184192: msg-6991-166.txt https://reviews.llvm.org/D51847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

cfe-commits added a subscriber: junbuml. cfe-commits added a comment. I think you and Richard agreed that you weren’t going to synthesize a whole expression tree at every use of the operator, and I agree with that decision. That’s very different from what I’m asking you to do, which is to

[PATCH] D44462: [clangd] Don't use DraftMgr in implementation of forceReparse.

cfe-commits added a comment. - F5892491: msg-4647-88.txt Repository: rL LLVM https://reviews.llvm.org/D44462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44218: Correct the alignment for the PS4 target

cfe-commits added a subscriber: erichkeane. cfe-commits added a comment. LGTM. - F5880823: msg-22334-27.txt Repository: rC Clang https://reviews.llvm.org/D44218 ___ cfe-commits mailing list