-if (!Compilations)
- llvm::report_fatal_error(ErrorMessage);
+if (!Compilations) {
+ errs() << "Compilation database not found - using default options\n";
+ int argc = 1;
+ const char *argv[] = {"--"};
+ Compilations.reset(
+ FixedCompilationDatabase::load
klimek added a reviewer: bkramer.
Comment at: clang-tidy/misc/StdSwapCheck.cpp:25
@@ +24,3 @@
+static SourceLocation findSemiAfterLocation(SourceLocation loc,
+ASTContext &Ctx,
+bool IsDecl) {
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D15149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:443
@@ -439,2 +442,3 @@
}
+ const StringRef Line = Lines[LineIndex];
For posterity, from in-person chat:
Currently, this does the same as before when we're in DryRun mode, and only
wrap
+Val FYI
On Wed, Nov 18, 2015 at 6:59 PM Douglas Gregor wrote:
> On Nov 18, 2015, at 9:36 AM, Manuel Klimek wrote:
>
>
>
> On Wed, Nov 18, 2015 at 6:19 PM Douglas Gregor wrote:
>
>>
>>
>> Sent from my iPhone
>>
>> On Nov 18, 2015, at 8:19 AM, Manuel Klimek wrote:
>>
>> (now with the right lis
On Wed, Nov 18, 2015 at 6:19 PM Douglas Gregor wrote:
>
>
> Sent from my iPhone
>
> On Nov 18, 2015, at 8:19 AM, Manuel Klimek wrote:
>
> (now with the right list)
>
> On Tue, Nov 16, 2010 at 12:03 AM Douglas Gregor wrote:
>
>> Author: dgregor
>> Date: Mon Nov 15 17:00:34 2010
>> New Revision:
(now with the right list)
On Tue, Nov 16, 2010 at 12:03 AM Douglas Gregor wrote:
> Author: dgregor
> Date: Mon Nov 15 17:00:34 2010
> New Revision: 119285
>
> URL: http://llvm.org/viewvc/llvm-project?rev=119285&view=rev
> Log:
> Tweak libclang's heuristics for building precompiled preambles and
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D14695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Reverted in r253337. Failing test case in commit message.
On Tue, Nov 17, 2015 at 4:39 PM Manuel Klimek wrote:
> Repro:
> float foo(float U, float base, float cell) { return (U = 2 * base) - cell;
> }
> Preparing rollback of the CL.
>
> On Tue, Nov 17, 2015 at 2:46 PM Manuel Klimek wrote:
>
>>
Repro:
float foo(float U, float base, float cell) { return (U = 2 * base) - cell; }
Preparing rollback of the CL.
On Tue, Nov 17, 2015 at 2:46 PM Manuel Klimek wrote:
> Note that due to this change we're hitting an assert at
> lib/CodeGen/CGExprScalar.cpp:2570 in llvm::Value *tryEmitFMulAdd(cons
Author: klimek
Date: Tue Nov 17 09:40:10 2015
New Revision: 253337
URL: http://llvm.org/viewvc/llvm-project?rev=253337&view=rev
Log:
Revert "Make FP_CONTRACT ON the default."
This reverts commit r253269.
This leads to assert / segfault triggering on the following reduced example:
float foo(float
Note that due to this change we're hitting an assert at
lib/CodeGen/CGExprScalar.cpp:2570 in llvm::Value *tryEmitFMulAdd(const
(anonymous namespace)::BinOpInfo &, const clang::CodeGen::CodeGenFunction
&, clang::CodeGen::CGBuilderTy &, bool): LHSBinOp->getNumUses(
) == 0 && "Operations with multiple
On Tue, Nov 17, 2015 at 10:14 AM Richard Smith
wrote:
> LOn Nov 17, 2015 12:49 AM, "Manuel Klimek" wrote:
> > Richard, this is still optional, right? (the AST matchers need to
> control visitation)
>
> This doesn't change RAV semantics at all (or if it does, it's a bug). If
> any of the extensio
Richard, this is still optional, right? (the AST matchers need to control
visitation)
On Tue, Nov 17, 2015 at 2:26 AM Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> W00t! That’s awesome Richard!
>
> On Nov 16, 2015, at 5:10 PM, Richard Smith wrote:
>
> Attached patch m
klimek added inline comments.
Comment at: include/clang-c/Index.h:5694-5695
@@ -5683,1 +5693,4 @@
/**
+ * \brief Same as clang_indexSourceFile but requires a full command line
+ * for \c command_line_args including argv[0].
+ */
We should probably expand on why u
klimek added a comment.
Jordan, your call :)
http://reviews.llvm.org/D13973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Ok, this patch LG. I'd really like to get rid of the current-file-dependent
stuff in ClangTidyOptions though :)
http://reviews.llvm.org/D14192
_
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
alexfh wrote:
> klim
klimek added a comment.
Can you add a test with an overloaded conversion operator?
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
alexfh wrote:
> klim
klimek added a comment.
Does this still do it for types with a user-provided implicit constructor?
http://reviews.llvm.org/D14442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
> I currently see the following ways forward:
>
> 1. Extend this patch to cover also "throw", fixing case B)
> 2. Do 1) plus loop over the whole body to also fix case C)
> 3. Drop this patch and instead remove unreachable blocks after the whole CFG
> has been generate
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:382
@@ +381,3 @@
+ const CommandLineArguments &Args, StringRef Filename) {
+Context.setCurrentFile(Filename);
+const ClangTidyOptions &Opts = Context.getOptions();
My concern is still
Author: klimek
Date: Thu Nov 5 09:24:47 2015
New Revision: 252170
URL: http://llvm.org/viewvc/llvm-project?rev=252170&view=rev
Log:
Allow use of private headers in different sub-modules.
Added:
cfe/trunk/test/Modules/Inputs/private3/
cfe/trunk/test/Modules/Inputs/private3/private.h
c
klimek marked 2 inline comments as done.
klimek added a comment.
Addressed comments.
http://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek updated this revision to Diff 39287.
klimek added a comment.
Remove unnecessary if and fix segfault.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: tes
klimek created this revision.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
http://reviews.llvm.org/D14353
Files:
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/private3/private.h
test/Modules/Inputs/private3/public.h
test/Modules/private.modulemap
Index: test/Modul
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Much better, thanks!
http://reviews.llvm.org/D14198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
klimek added a comment.
Ok, just let me know when you have an updated patch out for review for
submission, so I can make sure we'll get the reviews done in a timely fashion.
I really want to see this go in :)
http://reviews.llvm.org/D5767
___
cfe-
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:371-374
@@ -370,1 +370,6 @@
+/// \brief Returns false when it can be guaranteed that no element of the
+/// container we are iterating over is going to be modified due to this
+/// expression.
+s
klimek added a reviewer: bkramer.
klimek added a comment.
+Benjamin to share another yak :D
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a reviewer: jordan_rose.
klimek added a comment.
+jordan for an opinion on whether we want to fix the more general case.
My main problem is that while we're at it we need to fully understand the
change anyway, and if somebody runs into this later, they'll need a long time
debuggin
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva
>> wrote:
>>
>>> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek
>>> wrote:
>>>
On Tue, Oct 20, 2015 at 5:52 AM Sean Silva
wrote:
klimek added a subscriber: klimek.
klimek added a comment.
Is this still the most current patch out there?
http://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
Sergey, I think you raised concerns whether this is necessary. What are your
thoughts?
http://reviews.llvm.org/D13388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:371-373
@@ -370,1 +370,5 @@
+/// \brief Returns false when it can be guaranteed that no container element
+/// is going to be modified due to this expression.
+static bool canBeModified(ASTContex
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
In http://reviews.llvm.org/D14145#277222, @angelgarcia wrote:
> You can initialize an indirect base if it's virtual.
Cool, those cases would be useful to have as comment, for example:
// Make sure there are no additional initializations going on (for example, of
indirec
klimek added a comment.
In http://reviews.llvm.org/D14145#277202, @angelgarcia wrote:
> > In which cases can this be false? (I assume if not all are copied?)
>
>
> This can be false is there is we do anything else than initializing the
> bases and members. So the previous code is there to ensure
klimek added inline comments.
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:83-91
@@ +82,11 @@
+ const CXXMethodDecl *Method) {
+ if (Method->getNumParams() != 1)
+return false;
+ QualType ArgType = Method->getParamDecl(0)->getType();
+
+
klimek added a comment.
Please add unit tests :)
http://reviews.llvm.org/D14152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks!
On Wed, Oct 28, 2015 at 4:51 AM Angel Garcia wrote:
> angelgarcia added a comment.
>
> OK, thanks! I will try to refactor some of the parts into AST matchers
> then. It will probably take some time, though.
>
>
> http://reviews.llvm.org/D14145
>
>
>
>
klimek added a comment.
Generally, I feel like a lot of the code would be written better as ast
matchers (by adding new matchers if necessary). You can use
tooling::ast_matchers::matches if you want to do a match inside a callback.
Comment at: clang-tidy/modernize/UseDefaultCh
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D14105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
klimek added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:334
@@ +333,3 @@
+ if (Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak &&
+ Previous.is(tok::l_paren) && State.Column > getNewLineColumn(State) &&
+ (!Previous.Previous ||
LG. Thanks, totally missed this.
On Sun, Oct 25, 2015, 7:46 PM Matthias Gehre via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> mgehre created this revision.
> mgehre added reviewers: alexfh, sbenza, bkramer, aaron.ballman.
> mgehre added a subscriber: cfe-commits.
>
> Adapt clang-tidy/add_n
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
Author: klimek
Date: Fri Oct 23 05:00:50 2015
New Revision: 251103
URL: http://llvm.org/viewvc/llvm-project?rev=251103&view=rev
Log:
Make isExpensiveToCopy() tri-state.
This allows returning "don't know" for dependent types.
Modified:
clang-tools-extra/trunk/clang-tidy/utils/Matchers.h
c
klimek added inline comments.
Comment at: lib/Analysis/CFG.cpp:1949-1952
@@ +1948,6 @@
+ }
+ if(!C->body_empty() && !dyn_cast(*C->body_rbegin())) {
+// If the body ends with a ReturnStmt, the dtors will be added in
VisitReturnStmt
+addAutomaticObjDtors(ScopePos, scopeBe
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg; let's see whether it sticks this time :)
Comment at: include/clang/AST/ASTContext.h:456
@@ -455,1 +455,3 @@
+ /// pointer identity only, which are more common and we can
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: klimek
Date: Thu Oct 22 09:54:50 2015
New Revision: 251021
URL: http://llvm.org/viewvc/llvm-project?rev=251021&view=rev
Log:
Switch check_clang_tidy to argparse and add a -resource-dir argument.
-resource-dir can be used to inject non-standard resource dirs via the
lit site config.
Modif
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Lookup.h:37-38
@@ +36,4 @@
+/// \param FromDecl The declaration to which the nested name points.
+/// \param ReplacementString The replacement nested name. Should be qualified,
+/// leadi
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: klimek
Date: Thu Oct 22 06:31:44 2015
New Revision: 251010
URL: http://llvm.org/viewvc/llvm-project?rev=251010&view=rev
Log:
Add %check_clang_tidy and %clang_tidy_diff.
With this, site specific lit configs can inject parameters into the
test scripts if they need site specific parameters.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include/clang/AST/ASTContext.h:463
@@ +462,3 @@
+ class DynTypedNodeList {
+typedef ast_type_traits::DynTypedNode DynTypedNode;
+typedef ArrayRef ARef;
klimek added a subscriber: klimek.
klimek added a comment.
A test that fails before this patch and passes afterwards is needed :) If you
need help writing that test, let me know.
http://reviews.llvm.org/D13973
___
cfe-commits mailing list
cfe-commi
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Lookup.h:37-38
@@ +36,4 @@
+/// \param FromDecl The declaration to which the nested name points.
+/// \param ReplacementString The replacement nested name. Should be fully
+/// qualified.
On Tue, Oct 20, 2015 at 11:11 PM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 6:45 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote:
>>
>>> On 10/20/2015 04:38 AM, Manuel Klimek wrote:
>>> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>>> >> get cmake to genera
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Yay, another yak shaved \o/
http://reviews.llvm.org/D13897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote:
> On 10/20/2015 04:38 AM, Manuel Klimek wrote:
> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
> >> get cmake to generate clang module map files and add explicit module
> build steps?
> >
> > I have some experience hacking on cmake, and from
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D13889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin, who has been doing those changes lately...
http://reviews.llvm.org/D13891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek added a reviewer: bkramer.
klimek added a comment.
+benjamin, who has been doing those changes lately...
http://reviews.llvm.org/D13890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. Yay!
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:59-60
@@ +58,4 @@
+ "= default;");
+ // FIXME: this can generate a -Wpedantic warning if there is a sem
On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote:
> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote:
>
>> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
>>
>>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek
>>> wrote:
>>>
On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-comm
On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote:
> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote:
>
>> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oct
klimek added a comment.
+1 to "not tested before" not implying "doesn't need tests" :)
http://reviews.llvm.org/D13001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Thx Milinan; this also looks fine from a binary compatibility perspective ...
http://reviews.llvm.org/D13000
___
cfe-commits mailing list
cfe-com
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
I'd slightly prefer if the commands were still on their own line (via escaped
newlines if that's possible), but lg.
http://reviews.llvm.org/D13852
On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote:
>
>> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oc
Author: klimek
Date: Mon Oct 19 03:43:46 2015
New Revision: 250691
URL: http://llvm.org/viewvc/llvm-project?rev=250691&view=rev
Log:
Fix 'will be initialized after' warning.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vi
Author: klimek
Date: Mon Oct 19 03:27:51 2015
New Revision: 250690
URL: http://llvm.org/viewvc/llvm-project?rev=250690&view=rev
Log:
Make test not rely on %T ending on /Output.
Modified:
cfe/trunk/test/Driver/ps4-linker-non-win.c
Modified: cfe/trunk/test/Driver/ps4-linker-non-win.c
URL:
htt
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:489
@@ +488,3 @@
+ std::vector Apply(Errors.size(), true);
+ int Count = 0;
+ for (const auto &Event : Events) {
-
klimek added a comment.
We're waiting for Reid to find somebody who is good at reviewing this in detail.
Sorry it takes a while, so far we don't have enough trusted Windows experts in
the community :(
http://reviews.llvm.org/D13549
___
cfe-commits
klimek added a comment.
LG in general now, looks to me like we have very few tests though.
My favorite strategy to make sure I have enough tests is to comment out code
(or do mutations) as long as the tests still pass. Then write tests that fail
with the mutation, then undo the mutation.
=
klimek added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:495-496
@@ +494,4 @@
+ std::vector Apply(NumErrors, true);
+ for (int I = 0; I < NumErrors; ++I) {
+for (int J = I + 1; J < NumErrors; ++J) {
+ OverlappingKind Kind =
I
klimek added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:444-448
@@ +443,7 @@
+ };
+ // Keep track of the different coverage situations that have been spotted
+ // during the process: Coverage[Covered][Empty] will tell if there exists any
+ // range
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:438-440
@@ +437,5 @@
+ int Count[2] = {0, 0};
+ // Sit[1][0] will tell if there exists any range that is covered by the
+ // first set but not by the second one, Sit[1][1] will tell if there is
klimek added a comment.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:438-440
@@ +437,5 @@
+ int Count[2] = {0, 0};
+ // Sit[1][0] will tell if there exists any range that is covered by the
+ // first set but not by the second one, Sit[1][1] will tell if there is a
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added inline comments.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:40
@@ +39,3 @@
+
+ diag(MatchedCast->getExprLoc(), "do not (implicitly) convert an array to a
pointer");
+}
aaron.ballman wrote:
> klimek wrote:
> > Can
klimek added reviewers: aaron.ballman, rnk.
klimek added a comment.
+aaron for windows specific knowledge
+rnk to see whether we can get a reviewer with more MS VS experience (perhaps
somebody from MS :)
My main concern is that this adds a lot of things that I have no idea whether
they are need
301 - 400 of 588 matches
Mail list logo
