Ok, looked at the original patch again, and if we're fixing the
FixedCompilationDatabase to only insert the file when it actually produces
a CompileCommand it seems to be fine.
On Fri, Sep 11, 2015 at 6:32 PM Argyrios Kyrtzidis
wrote:
> On Sep 11, 2015, at 12:21 AM, Manuel Klimek wrote:
>
> On
Richard! We need an informed opinion :D
On Fri, Sep 11, 2015 at 3:07 PM Aaron Ballman
wrote:
> Ping?
>
> On Tue, Sep 8, 2015 at 9:26 AM, Manuel Klimek wrote:
> > On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman
> wrote:
> >>
> >> On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek
> wrote:
> >> > On Tu
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D12734#243157, @angelgarcia wrote:
> Comment the enumerators.
>
> > Do we need default?
>
>
> I think so. We need to set the cases that do not fall in any of these
>
On Thu, Sep 10, 2015 at 8:36 PM Argyrios Kyrtzidis
wrote:
> On Sep 10, 2015, at 1:48 AM, Manuel Klimek wrote:
>
> @@ -179,11 +185,13 @@ public:
>/// \param Directory The base directory used in the
> FixedCompilationDatabase.
>static FixedCompilationDatabase *loadFromCommandLine(int &Argc
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. This is great, thanks!
http://reviews.llvm.org/D12736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:468-470
@@ +467,5 @@
+// are VarDecl). If the index is captured by value, add '&' to capture
+// by reference instead.
+ReplaceText =
+Usage.Kind == Usage::UK_Ca
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:765-766
@@ -764,2 +764,4 @@
// exactly one usage.
- addUsage(Usage(nullptr, false, C->getLocation()));
+ // We are using the 'IsArrow' field of Usage to store if we have to add
+
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:458
@@ -438,2 +457,3 @@
// variable.
for (const auto &I : Usages) {
+ std::string ReplaceText;
I'd call that 'Usage' here, as it's not an iterator.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D12732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
klimek added a comment.
Ok, so just for my understanding: the nested name specifier in the changed
tests canonicaltype is *not* the user-written type (thus, what the elaborated
type would get us), but the full nested name specifier of the canonical type?
http://reviews.llvm.org/D11797
_
@@ -179,11 +185,13 @@ public:
/// \param Directory The base directory used in the
FixedCompilationDatabase.
static FixedCompilationDatabase *loadFromCommandLine(int &Argc,
const char *const
*Argv,
-
In r247018 I get a ~8x speedup on a synthetic benchmark I tried. Can you
validate this fixes the regression?
On Sat, Sep 5, 2015 at 12:56 AM Hans Wennborg wrote:
> On Fri, Aug 14, 2015 at 2:55 AM, Manuel Klimek via cfe-commits
> wrote:
> > Author: klimek
> > Date: Fri Au
Author: klimek
Date: Tue Sep 8 10:14:06 2015
New Revision: 247018
URL: http://llvm.org/viewvc/llvm-project?rev=247018&view=rev
Log:
Fix performance regression when running clang tools.
Brings tool start time for a large synthetic test case down from (on my
machine) 4 seconds to 0.5 seconds.
Mod
On Tue, Sep 8, 2015 at 3:23 PM Aaron Ballman wrote:
> On Tue, Sep 8, 2015 at 9:18 AM, Manuel Klimek wrote:
> > On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman
> wrote:
> >>
> >> On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek
> wrote:
> >> > Yea, we had that discussion a few times, and I can never
On Tue, Sep 8, 2015 at 2:23 PM Aaron Ballman wrote:
> On Tue, Sep 8, 2015 at 5:40 AM, Manuel Klimek wrote:
> > Yea, we had that discussion a few times, and I can never remember why we
> > ended up in the state we're in.
> > We definitely had a time where we switched to just using the exact same
Author: klimek
Date: Tue Sep 8 05:31:09 2015
New Revision: 247001
URL: http://llvm.org/viewvc/llvm-project?rev=247001&view=rev
Log:
Update code owners for AST matchers / libtooling.
Modified:
cfe/trunk/CODE_OWNERS.TXT
Modified: cfe/trunk/CODE_OWNERS.TXT
URL:
http://llvm.org/viewvc/llvm-pro
klimek closed this revision.
klimek added a comment.
Committed as r246998.
http://reviews.llvm.org/D12471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
LG, as this is a documentation change that looks about right, and comes with
tests, and the original author doesn't jump in.
http://reviews.llvm.org/D12471
Author: klimek
Date: Tue Sep 8 05:11:26 2015
New Revision: 246998
URL: http://llvm.org/viewvc/llvm-project?rev=246998&view=rev
Log:
Fix documentation of numSelectorArgs.
Currently, the documentation for numSelectorArgs includes an incorrect
example. It shows a case where an argument of 1 will ma
Yea, we had that discussion a few times, and I can never remember why we
ended up in the state we're in.
We definitely had a time where we switched to just using the exact same
name as the node's class name for the matchers.
I *think* we didn't do it for cxxRecordDecl, because Richard said that's a
klimek accepted this revision.
klimek added a comment.
LG
http://reviews.llvm.org/D12675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:659-664
@@ -646,7 +658,8 @@
+ BeginPointeeType.isTriviallyCopyableType(*Context);
} else {
// Check for qualified types to avoid conversions from non-const to const
// i
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:555-564
@@ +554,12 @@
+Descriptor.DerefByValue = true;
+// Try to find the type of the elements on the container from the
+// usages. We can assume that we have at least one
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:658-663
@@ -646,7 +657,8 @@
+ IsTriviallyCopyable = BeginPointeeType.isTriviallyCopyableType(*Context);
} else {
// Check for qualified types to avoid conversions from non-const to
klimek added a comment.
Ok, so looking over the new patch:
It seems like attributed types and decayed types are somewhat different from
elaborated types:
- decayed types don't lose any information if we look through to the original
type
- attributed types lose only information that can be consi
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:556-557
@@ -555,1 +555,4 @@
DerefByValue = true;
+// We can assume that we have at least one Usage, because
+// usagesAreConst() returned false.
+QualType Type = Us
klimek added a subscriber: klimek.
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
Wow, that goes a long while back into:
http://reviews.llvm.org/rL111858
where the current case was handled somewhere else, and
klimek added a comment.
Note that I think we should add a regression test that will work with the
spelling loc but not with the expansion loc.
Something like:
#define A \
\
A
http://reviews.llvm.org/D12631
___
cfe-commits mailing list
cfe-c
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:463-470
@@ -462,1 +462,10 @@
+void ForLoopIndexUseVisitor::addUsage(const Usage &U) {
+ SourceLocation Begin = U.Range.getBegin();
+ if (Begin.isMacroID())
+Begin = Context->getSourceManage
klimek added inline comments.
Comment at: clang-tidy/modernize/LoopConvertUtils.cpp:465
@@ +464,3 @@
+ SourceLocation Begin = U.Range.getBegin();
+ while (Begin.isMacroID())
+Begin = Context->getSourceManager().getExpansionLoc(Begin);
There should be no need
klimek added a subscriber: klimek.
klimek added a comment.
Is this still ready for submission or do you want to change something (not
clear after your last comment :)
http://reviews.llvm.org/D11797
___
cfe-commits mailing list
cfe-commits@lists.llv
klimek closed this revision.
klimek added a comment.
Submitted as r246778.
http://reviews.llvm.org/D11976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: klimek
Date: Thu Sep 3 11:11:10 2015
New Revision: 246778
URL: http://llvm.org/viewvc/llvm-project?rev=246778&view=rev
Log:
[libclang] Return deduced type for auto type, not the one written in the source.
It used to work, but was accidentally broken by r179769.
The issue with decayed typ
On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote:
> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote:
> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits <
> >
> > cfe-commits@lists.llvm.org> wrote:
> > > Hi,
> > >
> > > Please review the attached patch.
> > >
> > > In
klimek added a comment.
Oh, and you'll want to add tests :) unittests/Format/FormatTest.cpp
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
In the future, please add cfe-commits as subscriber on the initial post,
otherwise the initial email will not go to the mailing list. Thx!
http://reviews.llvm.org/D12489
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
klimek added a reviewer: dfsuther.
klimek added a comment.
+Dean, as I really don't know Obj-C (sorry for the delay in reply, was on
vacation)
http://reviews.llvm.org/D12471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D12597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
After Aaron updated the clang-tools-extra owners, I looked at the clang
owners and noticed that I'm not in there for libtooling and ast matchers.
Doug suggested 3 years back that I should be in there, but apparently I
forgot to update it. Anybody raising objections to me putting myself in for
libto
Thanks for the cleanup!
On Wed, Sep 2, 2015 at 10:02 PM Aaron Ballman
wrote:
> I've updated the code owners list in r246698. Thanks!
>
> ~Aaron
>
> On Wed, Sep 2, 2015 at 3:33 PM, Peter Collingbourne
> wrote:
> > SGTM.
> >
> > Peter
> >
> > On Wed, Sep 02, 2015 at 12:38:41PM -0400, Aaron Ballma
I think that basically encodes what the current state is, and we should
have kept that file in a better shape. +Edwin in case he still has a stake
in clang-modernize, or knows who might have.
On Wed, Sep 2, 2015 at 6:38 PM Aaron Ballman wrote:
> I happened to notice that CODE_OWNERS.TXT for clan
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D12555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Learned that I need to learn to read, because the deleted comment was just
duplicated.
Looks good, great first step towards making this significantly more useful :)
http://reviews.llvm.org/D1
klimek added inline comments.
Comment at: test/clang-tidy/modernize-loop-convert-basic.cpp:448
@@ +447,3 @@
+ret = it;
+ }
+}
angelgarcia wrote:
> klimek wrote:
> > This test seems to be missing the it.insert(0) case that was removed from
> > the "unsupporte
klimek added a comment.
Nice!
Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:378
@@ +377,3 @@
+ for (const auto &U : Usages) {
+if (!U.E->isRValue())
+ return false;
(not necessarily in this CL) please rename E to Expression or similar; I'm fine
klimek added a subscriber: klimek.
klimek added a comment.
I'll need to try to build / install it. I'll take a couple of days, I'm
currently swamped. Hope that's ok.
http://reviews.llvm.org/D12407
___
cfe-commits mailing list
cfe-commits@lists.llvm.
I'll need to try to build / install it. I'll take a couple of days, I'm
currently swamped. Hope that's ok.
On Mon, Aug 31, 2015 at 6:25 PM Hans Wennborg wrote:
> hans added a comment.
>
> I also don't know anything about how this plugin works, I just build it :)
> I'm hoping Manuel can take a lo
klimek added inline comments.
Comment at: test/clang-tidy/misc-static-assert-c99.c:1
@@ +1,2 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
alexfh wrote:
> Instead of duplicating the test, you could add a second run line in the o
klimek added a subscriber: klimek.
Comment at: test/clang-tidy/misc-static-assert-c99.c:2
@@ +1,3 @@
+// RUN: %python %S/check_clang_tidy.py %s misc-static-assert %t -- -std=c99
+
+void abort() {}
aaron.ballman wrote:
> I am not certain how to accomplish this with
On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> Please review the attached patch.
>
> In Sema::BuildCXXFunctionalCastExpr, if the class has a destructor, the
> Op.SrcExpr might be a CXXBindTemporaryExpr which we need to unwrap.
>
> In
klimek added a subscriber: klimek.
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
As this doesn't break any old tests, and fixes a significant number of issues,
LG.
Do you need me to submit?
http://reviews
klimek added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2140-2153
@@ -2139,16 +2139,16 @@
/// \brief Matches when the selector has the specified number of arguments
///
-/// matcher = objCMessageExpr(numSelectorArgs(1));
+/// matcher = objCMessageEx
Author: klimek
Date: Fri Aug 14 06:47:51 2015
New Revision: 245040
URL: http://llvm.org/viewvc/llvm-project?rev=245040&view=rev
Log:
Fix AST matcher documentation.
Fix a bug in the matcher docs where callExpr(on(...)) was in the examples,
but didn't work (on() only works for memberCallExpr).
Fix
klimek added inline comments.
Comment at: clang-tidy/IncludeSorter.cpp:144
@@ -138,3 +143,3 @@
IncludeKinds NonEmptyKind = IK_InvalidInclude;
- for (int i = IncludeKind - 1; i >= 0; --i) {
+ for (int i = IK_InvalidInclude - 1; i >= 0; --i) {
if (!IncludeBucket[i].empty()
klimek closed this revision.
klimek added a comment.
Submitted as r245036. Thanks!
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: klimek
Date: Fri Aug 14 04:55:36 2015
New Revision: 245036
URL: http://llvm.org/viewvc/llvm-project?rev=245036&view=rev
Log:
Add structed way to express command line options in the compilation database.
Currently, arguments are passed via the string attribute 'command',
assuming a shell-e
klimek added a comment.
Solved the line ending problem.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Unfortunately I can't get the patch to apply cleanly due to different line
endings.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek added a comment.
Cool, looks good! If you need me to land it let me know.
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Please add a regression test.
http://reviews.llvm.org/D12017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
LG with a happy path test.
Comment at: ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp:45
@@ -41,1 +44,3 @@
+ expectFailure
klimek added a comment.
In http://reviews.llvm.org/D11944#223597, @chapuni wrote:
> I wish, in clang/llvm, internal path separator would be slash.
> It'd be better to use backslash where it'd be really required, for example
> interface to cmd.exe or MS toolchain.
>
> For me, native-ization is n
Author: klimek
Date: Thu Aug 13 04:09:28 2015
New Revision: 244876
URL: http://llvm.org/viewvc/llvm-project?rev=244876&view=rev
Log:
Fix formatting.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
Modified: clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
U
klimek added a comment.
In http://reviews.llvm.org/D11944#222975, @rsmith wrote:
> In principle, normalizing slashes on Windows makes sense here. But we
> shouldn't use `llvm::sys::path::native`, because it's just too broken.
Ok, so if I understand you correctly it would make sense to create a
klimek added inline comments.
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:295
@@ +294,3 @@
+if (CommandFound) {
+ ErrorMessage = "Multiple command and arguments found";
+ return false;
You're probably right. I
klimek added a comment.
Ok, we're very close now :) Thanks for taking the time to work through this!
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299
@@ +298,3 @@
+if (CommandFound) {
+ ErrorMessage = "Multiple command and arguments fo
klimek added a subscriber: klimek.
klimek added a comment.
Minor nits; I'll want Alex to also take a look, as I had reviewed the original
code before, so he probably has more insightful things to say :)
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:1
@@ +1,2 @@
+//==
Author: klimek
Date: Wed Aug 12 02:57:16 2015
New Revision: 244722
URL: http://llvm.org/viewvc/llvm-project?rev=244722&view=rev
Log:
Reinstantiate better diagnostic, this time with a fatal error so we don't add a
dependency onto gtest from the header.
Modified:
clang-tools-extra/trunk/unitte
Back in the day I'm pretty sure you agreed with the general concept :)
http://reviews.llvm.org/D8378
I remember that we had problems with absolute paths ending up in the .d
file (which should not happen if none of the paths provided are absolute),
but I don't remember why we went for not writing th
On Tue, Aug 11, 2015 at 8:38 PM Richard Smith wrote:
> Those files were parsed as part of building the output, and are legitimate
> dependencies of the compilation process; why do you want to suppress them
> from the .d file? (I think adding a whole bunch of -fno-*-deps flags is
> going in the wr
Ah, so we need a flag -fno-module-map-file-deps, I assume...
On Tue, Aug 11, 2015 at 8:12 PM Richard Smith wrote:
> On Tue, Aug 11, 2015 at 4:57 AM, Manuel Klimek wrote:
>
>> I believe this breaks -fno-module-file-deps.
>>
>
> I don't think so; this affects which module map files end up in the
MSVC 2013
On Tue, Aug 11, 2015 at 5:02 PM David Blaikie wrote:
> Unsupported (which compiler(s)?) or just not preferred?
> On Aug 11, 2015 6:00 AM, "Manuel Klimek via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: klimek
>> Date:
klimek added a comment.
The case sensitivity stuff is related, but a much larger problem - while the
native paths are system dependent, the case sensitivity is file system
dependent - I can have case insensitive file systems on any OS.
http://reviews.llvm.org/D11944
nitializer lists like this...
> On Aug 11, 2015 5:13 AM, "Manuel Klimek via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: klimek
>> Date: Tue Aug 11 07:13:15 2015
>> New Revision: 244596
>>
>> URL: http://llvm.org/viewvc/ll
klimek created this revision.
klimek added reviewers: rsmith, chapuni.
klimek added a subscriber: cfe-commits.
For virtual files to work correctly on Windows, we need to canonicalize
the paths before looking into the caches.
This is basically a request for comments - if we want to go this route,
Author: klimek
Date: Tue Aug 11 09:21:26 2015
New Revision: 244602
URL: http://llvm.org/viewvc/llvm-project?rev=244602&view=rev
Log:
1. Disable tests that currently cannot work on windows due to missing path
canonicalization in the file manager.
2. Add better output when a clang-tidy unit test fa
Author: klimek
Date: Tue Aug 11 08:11:29 2015
New Revision: 244598
URL: http://llvm.org/viewvc/llvm-project?rev=244598&view=rev
Log:
Fix strict dependency uncovered by windows bot.
Modified:
clang-tools-extra/trunk/clang-tidy/CMakeLists.txt
Modified: clang-tools-extra/trunk/clang-tidy/CMakeL
Author: klimek
Date: Tue Aug 11 07:59:22 2015
New Revision: 244597
URL: http://llvm.org/viewvc/llvm-project?rev=244597&view=rev
Log:
Do not use inheriting constructors.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
Modified: clang-tools-extra/trunk/unittests/
Author: klimek
Date: Tue Aug 11 07:13:15 2015
New Revision: 244596
URL: http://llvm.org/viewvc/llvm-project?rev=244596&view=rev
Log:
Default initialize from explicitly constructed object.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
Modified: clang-tools-extra/trunk
Author: klimek
Date: Tue Aug 11 07:02:28 2015
New Revision: 244587
URL: http://llvm.org/viewvc/llvm-project?rev=244587&view=rev
Log:
Fix shadowing of type with variable.
Modified:
clang-tools-extra/trunk/clang-tidy/IncludeInserter.cpp
Modified: clang-tools-extra/trunk/clang-tidy/IncludeInser
I believe this breaks -fno-module-file-deps.
On Sun, Aug 9, 2015 at 6:47 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Sat Aug 8 23:46:57 2015
> New Revision: 244413
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244413&view=rev
> Log:
> [module
Author: klimek
Date: Tue Aug 11 06:37:48 2015
New Revision: 244586
URL: http://llvm.org/viewvc/llvm-project?rev=244586&view=rev
Log:
Add an IncludeInserter to clang-tidy.
Will be used to allow checks to insert includes at the right position.
Added:
clang-tools-extra/trunk/clang-tidy/IncludeI
Instead of forwarding this patch, which kills mail threading, I'd just
abandon the patch and create a new one where you directly add llvm-commits
when you upload it.
(we know this is a problem, and we know how to fix it, but we'd need some
php hackers to help)
On Mon, Aug 10, 2015 at 6:14 PM Tere
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
Ah, awesome, looks good then. Do you have commit access or need one of us to
land it?
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@li
klimek added a comment.
Can you also fix the current code in getWebKitStyle?
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Ah, ok. Interestingly, our current Webkit style uses BS_Stroustrup, which is
incorrect for } else {. So yep, implementing BS_Webkit sounds like a win.
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@
klimek added a comment.
Webkit doesn't break for classes:
class MyClass {
...
};
http://reviews.llvm.org/D11837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a comment.
Hm, the referenced style guide doesn't say anything about namespaces. I also
couldn't find anything in the qt source repo (just took a quick look though).
Do you have an example of why Qt projects shouldn't just use BS_Linux?
http://reviews.llvm.org/D11837
__
501 - 588 of 588 matches
Mail list logo
