Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-13 Thread Marek Kurdej via cfe-commits
curdeius marked 7 inline comments as done. curdeius added a comment. Applied comments and done some minor clean up. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37081. curdeius added a comment. Fix description formatting. http://reviews.llvm.org/D13549 Files: lib/Driver/Tools.cpp tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius added inline comments. Comment at: lib/Driver/Tools.cpp:2356 @@ -2355,3 +2355,3 @@ CmdArgs.push_back( -Args.MakeArgString("-dwarf-version=" + llvm::itostr(DwarfVersion))); +Args.MakeArgString("-dwarf-version=" + Twine(DwarfVersion))); }

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37086. curdeius added a comment. Escape only '<' and '&'. Remove unrelated changes from the revision. http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37087. curdeius marked 2 inline comments as done. curdeius added a comment. Add FIXME comment. http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ +if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius marked 3 inline comments as done. curdeius added a comment. Applied suggestions from comments. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius added inline comments. Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:186 @@ -145,1 +185,3 @@ +if (!string.IsNullOrEmpty(assumeFilename)) + process.StartInfo.Arguments += " -assume-filename \"" + assumeFilename + "\"";

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius marked 5 inline comments as done. curdeius added a comment. Assume-Filename option will now give an error when there are quotes in the filename. http://reviews.llvm.org/D13549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-12 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 37115. curdeius added a comment. Add option converters for filenames (prohibiting quotes) and styles (giving a list of predefined styles). http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

2015-10-08 Thread Marek Kurdej via cfe-commits
curdeius updated this revision to Diff 36849. curdeius added a comment. Escape XML-reserved characters. http://reviews.llvm.org/D13549 Files: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs

[clang-tools-extra] r247536 - Test commit.

2015-09-14 Thread Marek Kurdej via cfe-commits
Author: mkurdej Date: Mon Sep 14 03:05:12 2015 New Revision: 247536 URL: http://llvm.org/viewvc/llvm-project?rev=247536=rev Log: Test commit. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified:

<    1   2   3