Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-21 Thread Marek via cfe-commits
edyp87 added a comment. Yes, please apply this patch for me. As for macro cases - I also thought about this but check's author has taken care of macros in `check()` method : void RawStringLiteralCheck::check(const MatchFinder::MatchResult ) { [...] if

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Marek via cfe-commits
edyp87 marked an inline comment as done. edyp87 added a comment. 1. Extended diff has been generated - sorry, I am new to Phabricator. 2. AST for this case looks like this: > AST for crashing case: > > -VarDecl 0x2b27370 col:19 function 'const char *const' > callinit >

Re: [PATCH] D19331: [Clang-tidy] Fix for crash in modernize-raw-string-literal check

2016-04-20 Thread Marek via cfe-commits
edyp87 removed rL LLVM as the repository for this revision. edyp87 updated this revision to Diff 54401. edyp87 added a comment. Extended diff range + removed unnecessary variable. http://reviews.llvm.org/D19331 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp