[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

Fznamznon added a comment. Hi there, This change seems to be causing assertion failure in clang when a struct contains a _BitInt with length longer than 128 - https://godbolt.org/z/4jTrW4fcP . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. In D157879#4655321 , @rsmith wrote: > This change has introduced a false positive for anonymous union members: > > struct A { > int m; > union { int n = 0; }; > }; > > A a = A{.m = 0}; > > now produces a

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e56f91df6a: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Fznamznon updated this revision to Diff 555289. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159279/new/ https://reviews.llvm.org/D159279 Files: clang/docs/ReleaseNotes.rst

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/64987 Repository: rG LLVM Github Monorepo

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc881161aeb: [clang] Emit an error if variable ends up with incomplete array type (authored by Fznamznon). Repository: rG LLVM Github Monorepo

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon added a comment. The failures in CI are unrelated and caused by another patch - https://reviews.llvm.org/D112921. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon updated this revision to Diff 554220. Fznamznon added a comment. Apply suggestion, rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 Files:

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ade434a7e74: [clang] Fix assertion fail when function has cleanups and fatal errors (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D158827?vs=553420=553872#toc Repository:

[PATCH] D158827: [clang] Fix assertion fail when function has cleanups and fatal errors

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/48974 Repository: rG LLVM Github Monorepo

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c886b6aaea: [clang] Properly print unnamed members in diagnostics (authored by Fznamznon). Changed prior to commit:

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

Fznamznon added inline comments. Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:610-612 if (isa(Method)) { Name = Method->getNameAsString(); +if (cast(Method)->isExplicit()) Maybe we can just do this, so we don't `isa` two times.

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13460 + // initializer. + Diag(VDecl->getLocation(), diag::err_typecheck_decl_incomplete_type) + << VDeclType; Not sure about the error message though, maybe

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds an error if variable with incomplete type has initializer with incomplete type, so it is not possible to

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

Fznamznon added inline comments. Comment at: clang/include/clang/AST/Decl.h:3186 + + void printName(raw_ostream , const PrintingPolicy ) const override; }; shafik wrote: > So it looks like w/o this we would end up using `NamedDecl::printName(...)` > is that

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use member's type when printing. This also fixes a bug in warning diagnostic for out of order initialization with

[PATCH] D157879: [clang] Report missing designated initializers in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91088978d712: [clang] Report missing designated initializers in C++ (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. The failure is unrelated, since the patch doesn't touch modules and I've seen the test failing for other patches as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551924. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 Files: clang/docs/ReleaseNotes.rst

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551460. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaInit.cpp

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. In D157879#4594790 , @tbaeder wrote: > Tangentially related: Now that we have this `InitializedFields` set, would it > be easy to add a warning for double-initialization of fields (that would also > trigger in C)? Isn't a

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon marked 3 inline comments as done. Fznamznon added a comment. > Thank you for working on this! The changes should come with a release note. Thanks for feedback, I added a release note. > Can we silence the diagnostic in these cases? And this is done. Repository: rG LLVM Github

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551051. Fznamznon added a comment. Add a release note, apply feedback: - Do not report invalid initializers as missing - Fix wrong warning if record has bitfields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this change clang didn't emit missing-field-initializers warning for designated initializers. The comments say

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG38cf47f037b2: [clang] Error on substitution failure within lambda body inside a requires… (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

Fznamznon added inline comments. Comment at: clang/test/Sema/offsetof.c:79 +int x2[__builtin_offsetof(struct X2, X2::a) == 0 ? 1 : -1]; +int x3[__builtin_offsetof(struct X2, X2::X2) == 0 ? 1 : -1]; // expected-error{{no member named 'X2'}} + It probably makes

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf91092c449d: [clang] Do not crash on use of a variadic overloaded operator (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added a comment. Hmm, clang-format reports failure, but applying git-clang-format to the commit doesn't give me anything. It seems the whole SemaOverload.cpp file has broken formatting, maybe that is the reason for the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG25d6f9ddc191: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156975/new/

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGf887cb10acc9: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156896/new/

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon added a comment. > Can you add a test in dr26xx ? Sure, done. Hope I updated cxx_dr_status in the right way. The script wasn't happy until I added "open" to the test comment. > maybe we need a test like Because I think the intent is for that to work Seems to be working if I got it

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon updated this revision to Diff 546837. Fznamznon added a comment. Rebase, apply feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156993/new/ https://reviews.llvm.org/D156993 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156993: [clang] Error on substitution failure within lambda body inside a requires-expression

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per CWG 2672 substitution failure within the body of a lambda inside a requires-expression should be a hard error.

[PATCH] D156975: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A bunch

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4bb3e073548: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156900/new/

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG962deded6c30: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156904/new/

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); }

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon updated this revision to Diff 546445. Fznamznon added a comment. Rebase, add more test cases, fix assertion on variadic functions inside of `haveSameParameterTypes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156244/new/

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } cor3ntin wrote: > aaron.ballman

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > I agree this is a bug in libc++ and we should fix it. As mentioned I'm not > too familiar with ranges. Thanks! I submitted https://github.com/llvm/llvm-project/issues/64250 so we don't forget about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } aaron.ballman wrote: > I think it

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa457067d2c6b: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fe23fbb2318: [NFC][analyzer] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa623f4c78498: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156415: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545082. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 Files:

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545080. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406 Files:

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545079. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405 Files: clang/lib/Frontend/FrontendAction.cpp

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

Fznamznon added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:422 + // There's nothing to suggest in here as we parsed a full expression. + // Instead fail and propogate the error since caller might have something + // the suggest, e.g. signature help

[PATCH] D156415: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

Fznamznon added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1906-1908 + if (D.isConstexpr()) +// Note: constexpr already initializes everything correctly. +trivialAutoVarInit = LangOptions::TrivialAutoVarInitKind::Uninitialized; Should we

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb63fa00d1f7: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156222/new/

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > What do you mean with libstdc++ is fine? What I mean is when I do (current patch is applied to clang): source/llvm-project/build/bin/clang++ -std=c++20 t.cpp -c // compilation succeeds But when I do (libc++ is built together with clang)

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 544262. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156222/new/ https://reviews.llvm.org/D156222 Files: clang/lib/Sema/TypeLocBuilder.h Index:

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); Fznamznon wrote: > shafik wrote: > > Fznamznon wrote: > > > shafik wrote: > > > > shafik wrote: > > > > > It

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > Fznamznon wrote: > > shafik wrote: > > > shafik wrote: > > > > It feels a bit weird that we

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14001 + +if (FnDecl->isInvalidDecl()) + return ExprError(); shafik wrote: > It feels a bit weird that we are succeeding in finding the best viable > function and what

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Just exit instead. Fixes https://github.com/llvm/llvm-project/issues/42535 Repository: rG LLVM Github Monorepo

[PATCH] D156222: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D156133: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5a13e2c7e4c: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156133/new/

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. > should we try to land that today? I'm not sure. It causes failures in libc++ testing: Failed Tests (3): llvm-libc++-shared.cfg.in :: std/ranges/range.access/end.pass.cpp llvm-libc++-shared.cfg.in :: std/ranges/range.access/rbegin.pass.cpp

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb8911316be: [clang] Fix specialization of non-templated member classes of class templates (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D155705?vs=543478=543598#toc

[PATCH] D156133: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb2906cdfb3: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155842/new/

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc928c683058: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155849/new/

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon added a comment. > Maybe we should think about tests that might exercise this code a bit more. I tried adding more checks, but the patch fixes a specific case. Do you have some examples in mind? Please note that in order to test new change there should be an instantiation of nested

[PATCH] D156108: Rebase, extend the test a bit

Fznamznon abandoned this revision. Fznamznon added a comment. Miss click! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156108/new/ https://reviews.llvm.org/D156108 ___ cfe-commits mailing list

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon updated this revision to Diff 543478. Fznamznon added a comment. Rebase, extend the test a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155705/new/ https://reviews.llvm.org/D155705 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156108: Rebase, extend the test a bit

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156108 Files: clang/test/SemaTemplate/gh61159.cpp

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval-default-params.cpp:48 -struct InitWithLambda { -int b = [](int error = undefined()) { // expected-error {{cannot take address of consteval function 'undefined' outside of an immediate

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added a comment. Just a couple of NITs otherwise LGTM Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2506 + + for (auto A : E->arguments()) +if (!getDerived().TraverseStmt(A)) Comment at:

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 543420. Fznamznon added a comment. Rebase to maybe fix precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155842/new/ https://reviews.llvm.org/D155842 Files: clang/lib/Frontend/HeaderIncludeGen.cpp

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 543417. Fznamznon added a comment. Rebase, fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155849/new/ https://reviews.llvm.org/D155849 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp Index:

[PATCH] D155846: [NFC][clang] Fix static analyzer concerns

Fznamznon abandoned this revision. Fznamznon added a comment. Oh shoot, I trusted the tool too much to not double check that the copy ctor is already deleted. Thank you for the catch and for the bug report. I'll abandon this change then. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D155849: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D155846: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D155842: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon added a comment. > Can you explain why the fix fixes the bug? Sure, let me try. To be honest, I'm not very familiar with the code either, so I'll describe how I came to the fix. I'll be using added test `clang/test/SemaTemplate/gh61159.cpp` as example of failing code. The issue

[PATCH] D155705: [clang] Fix specialization of non-templated member classes of class templates

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Explicit specialization doesn't increase depth of template parameters, so need to be careful when gathering template

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 541915. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18441 SemaRef.Diag(ND->getLocation(), diag::note_declared_at); + if (auto Context = + SemaRef.InnermostDeclarationWithDelayedImmediateInvocations()) { cor3ntin

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2441 bool Sema::CheckImmediateEscalatingFunctionDefinition( -FunctionDecl *FD, bool HasImmediateEscalatingExpression) { - if (!FD->hasBody() || !getLangOpts().CPlusPlus20 || -

[PATCH] D155164: [clangd][NFC] Remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4a27f410ba: [clangd][NFC] Remove dead code (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155164/new/

[PATCH] D155164: [clangd][NFC] Remove dead code

Fznamznon created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. Fznamznon requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. refactor/tweaks/ExtractVariable.cpp:

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 539502. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0130fc51cbc: [clang] Correct calculation of MemberExprs dependence (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon updated this revision to Diff 538531. Fznamznon added a comment. Rebase, add tests for dependent NameInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154689/new/ https://reviews.llvm.org/D154689 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon updated this revision to Diff 538165. Fznamznon added a comment. Rebase, move the logic, modify c-style casts as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152003/new/ https://reviews.llvm.org/D152003 Files:

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added a comment. In D154689#4480249 , @cor3ntin wrote: > I think this makes sense and it implements richard's suggestion. > However, it's missing a release note, can you add that before landing? > Thanks Thank you for the review. I think I

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/Expr.cpp:1760 + // FIXME: remove remaining dependence computation to computeDependence(). + auto Deps = E->getDependence(); cor3ntin wrote: > Maybe we should do that now, by passing `TemplateArgs` to

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:625 auto D = E->getBase()->getDependence(); + D |= getDependenceInExpr(E->getMemberNameInfo()); + While implementing this patch I was following Richard's guide from

[PATCH] D154689: [clang] Correct calculation of MemberExpr's dependence

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to incorrect calculation false positive diagnostics were emitted. Fixes

  1   2   3   4   5   >