[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

2020-12-01 Thread Mark Nauwelaerts via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4d6d1c1ff3: [clang-format] Add new option PenaltyIndentedWhitespace (authored by mnauw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-11-15 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw abandoned this revision. mnauw added a comment. Looks like PenaltyBreakBeforeFirstCallParameter not being considered so well has been addressed somewhat differently in D90246 , and so that does the job as well. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

2020-11-10 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added a comment. Thanks. However, I do not have commit access, so someone may have to arrange for that ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90534/new/ https://reviews.llvm.org/D90534 __

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

2020-11-01 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw updated this revision to Diff 302144. mnauw added a comment. Patch updated to include unit test and documentation changes (and to use full diff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90534/new/ https://reviews.llvm.org/D90534 Files

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-11-01 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4481 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; + Style.PenaltyBreakBeforeFirstCallParameter = 0; Style.AlignOperands = FormatStyle::OAS_DontAlign; MyDeveloperDay

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

2020-10-31 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. mnauw requested review of this revision. As the example in the comment within the patch shows, the intention of yet-another-p

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

2020-10-31 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. mnauw requested review of this revision. If AlignAfterOpenBracket is set to BAS_DontAlign, then it turns out that PenaltyBrea

[PATCH] D77938: [clangd] Extend YAML Serialization

2020-04-18 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added a comment. I do not have commit access, so it would be helpful that you land this (and the other) ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 ___ cfe-commits mailing list cfe-com

[PATCH] D77938: [clangd] Extend YAML Serialization

2020-04-17 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw updated this revision to Diff 258292. mnauw added a comment. As suggested, existing (YAML) Serialization test has been extended. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77938/new/ https://reviews.llvm.org/D77938 Files: clang-tools-extra/clangd/index/YAMLSerialization.cpp

[PATCH] D77938: [clangd] Extend YAML Serialization

2020-04-11 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. mnauw added a comment. This was previously part o

[PATCH] D77938: [clangd] Extend YAML Serialization

2020-04-11 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added a comment. This was previously part of D77385 . Rather than a separate file (which seems a bit tricky), the test YAML has simply been included in the unit test itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D77385: [clangd] Add index export to dexp

2020-04-10 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added a comment. As suggested, I will provide the YAMLSerialization changes in a separate patch. Regarding test for that, I was thinking of some running some "simple/mock YAML data" through some load and save cycle(s). I presume a separate YAML file (in e.g. test/Inputs) is best for tha

[PATCH] D77385: [clangd] Add index export to dexp

2020-04-10 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw updated this revision to Diff 256557. mnauw edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77385/new/ https://reviews.llvm.org/D77385 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp Index: clang-tools-extra/clangd/index/dex/dexp/Dexp.

[PATCH] D77385: [clangd] Add index export to dexp

2020-04-04 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw updated this revision to Diff 255019. mnauw retitled this revision from "[clangd] Add index inspection helper tool" to "[clangd] Add index export to dexp". mnauw edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77385/new/ https://reviews.llvm.org/D

[PATCH] D77385: [clangd] Add index inspection helper tool

2020-04-03 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw added a comment. Thanks for having a look at this patch. My use-case/goal would be to have a way to run/do a command that reads some index and dumps it (in e.g. YAML) to (e.g.) stdout. That way it can be inspected/viewed all at once by plain viewer. And not only symbols, refs, but also

[PATCH] D77385: [clangd] Add index inspection helper tool

2020-04-03 Thread Mark Nauwelaerts via Phabricator via cfe-commits
mnauw created this revision. mnauw added a reviewer: sammccall. mnauw added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Add a standalone executable that can read indexed data and out