[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

mizvekov added a comment. This broke a buildbot, as a user reported on discord: https://buildkite.com/llvm-project/github-pull-requests/builds/5171#018aec0c-75ba-431a-a5c8-6a5cba51de28 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

mizvekov added a comment. This was never mentioned in the review, but I have a late question: Why did we need to implement a new flag, instead of using `getFullyQualifiedName` from `QualTypeNames.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150212/new/ https://reviews.llvm.org/D150212 ___ cfe-commits mailing list

[PATCH] D147263: Fix an assertion failure in unwrapSugar

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147263/new/ https://reviews.llvm.org/D147263

[PATCH] D147263: Fix an assertion failure in unwrapSugar

mizvekov added inline comments. Comment at: clang/test/SemaObjCXX/arc-objc-lifetime.mm:69-79 +// See https://github.com/llvm/llvm-project/issues/61419 + +template struct pair { + T0 first; + T1 second; +}; + I think the fix looks good, although this test may

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3984855 , @arphaman wrote: > Ping @mizvekov. > > Unfortunately I'm unable to revert this commit now so we won't be able to get > the bot back to green until it's fixed. Hello, sorry for the long time to respond.

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. @alexfh Thanks! While there is a huge increase in the amount of UsingTypes, it seems the total amount is still reasonable and does not explain the perf hit. Perhaps this is a case of bad hashing and they are all falling into the same bucket? cc @sam.mcall for

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. In D136565#3911884 , @alexfh wrote: > Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d > causes > compilation timeout on some of our internal files. Hi

[PATCH] D137200: [clang] Template Specialization Resugaring - Expressions

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 472886. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. FYI just another data point, I haven't taken a closer look yet, but with the resugaring patches applied on top of this, we start diagnosing some deprecated uses of `std::experimental::pmr::polymorphic_allocator` on current libc++ linux CI:

[PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov added a comment. In D127695#3860316 , @rjmccall wrote: > I see, thank you. I know you've marked this a WIP, but it's always good to > describe these things in the patch description; that's what it's for. Done! I have also removed the WIP.

[PATCH] D137200: [clang] Template Specialization Resugaring - Expressions

mizvekov created this revision. Herald added subscribers: ChuanqiXu, jdoerfert, arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WIP Signed-off-by:

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov updated this revision to Diff 472422. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaType.cpp

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov updated this revision to Diff 472421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D137199: [clang] Template Specialization Resugaring - Template Type Alias

mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, ChuanqiXu. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements resugaring of the pattern of template type

[PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov retitled this revision from "[clang] Implement Template Specialization Resugaring" to "[clang] Template Specialization Resugaring - TypeDecl". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 472416. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134113: [clang] store sugared converted arguments on TemplateSpecializationType

mizvekov updated this revision to Diff 472415. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134113/new/ https://reviews.llvm.org/D134113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 472414. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3899628 , @ldionne wrote: > It might be a problem, but I would argue we should still do it after fixing > any problematic cases. It seems like Clang's current behavior is broken, as > it basically ignores the

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added a comment. I'll need to have another look at this, apparently the synthesized `std` namespace breaks some tests on arm platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG279fe6281d2c: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1140874fc6: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f820c0f55cd: [clang] ASTImporter: Fix importing of va_list types and declarations (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf1a2e89340: [clang] Fix handling of unexpanded packs in template argument expressions. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2492c52a05bc: [clang] Improve error recovery for pack expansion of expressions (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov updated this revision to Diff 472021. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/ https://reviews.llvm.org/D136565 Files: clang-tools-extra/clangd/unittests/HoverTests.cpp clang/lib/Sema/SemaTemplate.cpp

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov updated this revision to Diff 472020. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136564/new/ https://reviews.llvm.org/D136564 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaTemplate.cpp

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov updated this revision to Diff 472018. mizvekov marked 12 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files:

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 472016. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

mizvekov updated this revision to Diff 472017. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136977/new/ https://reviews.llvm.org/D136977 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3896313 , @ldionne wrote: > Looking at that commit, which had nothing to do with fixing availability > markup, I think this Clang patch might still be missing some diagnostics? > Should it diagnose when the typename

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(, DC); +PushOnScopeChains(ND, ); aaron.ballman wrote: > erichkeane wrote: > > mizvekov

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/lib/Sema/Sema.cpp:460-462 +Scope S(TUScope, Scope::DeclScope, getDiagnostics()); +PushDeclContext(, DC); +PushOnScopeChains(ND, ); aaron.ballman wrote: > Is it valid to use a local

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:27 // CHECK-NEXT: | `-ParmVarDecl {{.*}} col:19{{( imported)?}} 'E' -// CHECK-NEXT: `-FunctionDecl {{.*}} line:14:6{{( imported)?}} test 'void ()' +// CHECK-NEXT: -FunctionDecl

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 471809. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 Files:

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov retitled this revision from "[clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types" to "[clang] ASTImporter: Fix importing of va_list types and declarations". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 471808. Herald added a

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 471807. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136977/new/ https://reviews.llvm.org/D136977 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 471806. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

mizvekov added a comment. It's not clear to me there is anything wrong besides our not importing of `va_list_tag`. The imported TypedefType should have the same underlying type as the original one, and I did not find anything different is happening on that test case. I will post a patch fixing

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. @rtrieu @hokein I just proposed a fix for this at https://reviews.llvm.org/D136977 At least for the repro posted above, this was a pre-existing bug with unexpanded packs appearing within sugar, which the present patch potentialized by preserving the type alias when

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes #58679. Signed-off-by: Matheus Izvekov Depends on D136962 Repository: rG

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov updated this revision to Diff 471638. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136962/new/ https://reviews.llvm.org/D136962 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence.cpp

[PATCH] D136962: [clang] Improve error recovery for pack expansion of expressions

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes #58673. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136962

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

mizvekov added a comment. I agree having two different val_list types is suspect, it might not have been imported and is simply referring to the va_list of the original context. One other note, is that if a problem exists for TypedefType, it probably exists for UsingType as well, as they are

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3891905 , @ldionne wrote: > Is it possible that it would be one of those two bugs? > https://github.com/llvm/llvm-project/issues?q=is%3Aopen+is%3Aissue+author%3Aldionne+availability+ I don't think so. It does look

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27f9b0c619c6: [clang] Include the type of a pointer or reference non-type template parameter… (authored by rsmith, committed by mizvekov). Changed

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks for confirming. I have pushed a patch at: https://reviews.llvm.org/D136803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We already did this for all the other kinds of non-type template argument. We're still missing the type from the

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. I think there is a high chance that the bug that caused richard's patch to be reverted, was actually fixed afterwards by https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c So I will try to land that one again, and then I will try to

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. This is surprisingly not from a bug in this patch. So `getCanonicalTemplateArgument` is broken for the types of declarations. This bug was supposedly fixed by zygoloid (https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207) But then was

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#388 , @glandium wrote: > It's the opposite of deprecated, it's (optionally) using something that is > only available in newer versions of macos. Right, I mis-typed, but this is probably using the 'availability'

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks. Reduced to: void foo(); template void bar() {} template void bar<>(); template void bar(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3885423 , @aaron.ballman wrote: > I can live with this approach if folks think it's the better way to go. But > my concern still remains that the user has no idea what's being constructed > by `{3}` or `{4}`

[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

mizvekov accepted this revision. mizvekov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039 + + if (!Context.getTargetInfo().isTLSSupported()) +return; + Is this needed? It seems

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a subscriber: ldionne. mizvekov added a comment. In D136533#3884364 , @glandium wrote: > (And specifically, FuzzerFork.cpp doesn't use any of those declared things. > Its only sin is to `#include `, which happens to have /some/ methods >

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884904 , @glandium wrote: > I'm running it through creduce (as well as the one for D136564 > . It's going to take a little while. Thank > you for the revert. That's very helpful,

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3884468 , @glandium wrote: > This broke building Firefox with: Thanks for reporting. Do you have preprocessed source + cc1 flags to reproduce it, so I can have a look? Repository: rG LLVM Github Monorepo

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov added a comment. In D136564#3884470 , @glandium wrote: > This broke building Firefox with: > > In file included from Unified_cpp_dom_canvas0.cpp:65: > /tmp/gecko/dom/canvas/ClientWebGLContext.cpp:355:19: error: call to deleted > function

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a6de59c780: [clang] Instantiate concepts with sugared template arguments (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D136566?vs=470013=470671#toc Repository: rG LLVM

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c44c91ad980: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136565/new/

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2560c1266993: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c2a3c65684: [clang] Implement sugared substitution changes to infrastructure (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470660. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5d9e802e50d: [clang] Perform sugared substitution of builtin templates (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG11ce78940b4c: [clang] Changes to produce sugared converted template arguments (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470645. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3883116 , @erichkeane wrote: > I don't believe that the libc++ CI does 'self build with libcxx as the host > library', so it would not have caught this. That said, this could definitely > just be an issue in the

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3883048 , @erichkeane wrote: > One thing you might try is seeing if this is a libcxx-specific thing instead, > and try doing a self-build using libcxx. We tested this on the libc++ CI, as this patch touches a test

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101 +const TemplateArgument = +FunctorParentType->template_arguments()[ArgNum]; if (Arg.getKind() != TemplateArgument::Type)

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. I don't have access to a macOS machine, and I don't believe any of the pre-commit CI machines are running it either. So I don't have much to go on here. How do you think we shall proceed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. In D133874#3882350 , @erichkeane wrote: > The test changes are a little bizarre, are there any better tests you can > write that shows this behavior? > > Also, at the 'end' of this patch set, we should make sure we have a

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added inline comments. Comment at: clang/include/clang/Sema/Sema.h:8285 + TemplateArgument , + TemplateArgument , + CheckTemplateArgumentKind CTAK);

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a reviewer: erichkeane. mizvekov added a subscriber: erichkeane. mizvekov added a comment. @erichkeane since you reviewed and approved 5 patches that depend on this one, can you also have a look at this please? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a subscriber: kcc. mizvekov added a comment. pinging @kcc for LibFuzzer, I believe this needs to be fixed there, if we don't want to bump the MacOs minimum version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/ https://reviews.llvm.org/D136563 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470346. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc170433137a: [clang] Fix missing diagnostic of declaration use

[PATCH] D136602: NFC: [clang] Template argument cleanups.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1acffe81ee91: NFC: [clang] Template argument cleanups. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3880729 , @dblaikie wrote: > I think we should restrict the discussion in this review to being only about > the case where we have the canonical type (acknowledging that there's broader > work to reduce the number

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470294. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470289. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470278. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3880403 , @dblaikie wrote: > Could you describe this in more detail? I find that to be more verbose than > is necessary/helpful and probably the variable name based option to be more > informative than the type name

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470266. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov retitled this revision from "Fix missing diagnostic of declaration use when accessing TypeDecls through typename access" to "[clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access". mizvekov updated this revision to Diff 470264. Repository:

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:592 + llvm::ArrayRef arguments() const { return Arguments; } + llvm::MutableArrayRef arguments() { return Arguments; } erichkeane wrote: > Ooh, really? Are the use cases ones

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1079 MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( - CSE->getNamedConcept(), /*Final=*/false, , + CSE->getNamedConcept(), /*Final=*/true, ,

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

mizvekov accepted this revision. mizvekov added a comment. LGTM as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 ___ cfe-commits mailing list

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. @philnik it seems that didn't work. It seems those pipelines are already running clang-16, according to the cmake logs, they are just not bootstrapping with this patch. So gating this on clang version will not work. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we don't unique specializations for concepts, we can just instantiate them with the sugared template arguments, at

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, LLDB, clang-tools-extra. Herald added subscribers: cfe-commits, lldb-commits. This makes use of

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470011. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes use of the changes introduced in D134604 , in order to instantiate non-type

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3877974 , @philnik wrote: > Would it be possible to just add `#if TEST_CLANG_VER >= 1600` around the new > warnings? That works for me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   4   5   6   7   8   9   10   >