[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: All. Someone else ultimately fixed this (slightly differently) last month: https://reviews.llvm.org/D146875 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116137: [clang-tidy] Remove dead plugin code

mattbeardsley created this revision. mattbeardsley added reviewers: thakis, hans. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. mattbeardsley requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a comment. @dstenb Thanks for the confirmation! @kbobyrev Sorry about my mixup! Would you be able to help me commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114034/new/ https://reviews.llvm.org/D114034

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley updated this revision to Diff 388329. mattbeardsley edited the summary of this revision. mattbeardsley added a comment. Well, I've goofed. I was working in a shared fork where someone added a RenameFcn check locally (not sure we should be doing that, but that's besides the point).

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley added a subscriber: dstenb. mattbeardsley added a comment. @dstenb - wanted to check with you too to make sure that this change to pr37091.cpp seems like it won't interfere with the original intent of the test (https://reviews.llvm.org/D45686 ) The lingering file issue you'd

[PATCH] D114034: [clang-tidy] fix debug-only test failure

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. The

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley added a comment. Works for me!  I didn't realize you can pull the info automatically from arc. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley added a comment. Thanks! Could you help me commit again when you have time? (same info as here ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110600/new/ https://reviews.llvm.org/D110600

[PATCH] D110600: [clang-tidy] Fix add_new_check.py to generate correct list.rst autofix column from relative path

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously, the code in add_new_check.py that

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Thanks for your reply and sorry about my very sluggish reply! I am looking into updating the docs as you suggested, and that got me looking at this doc page . Interestingly,

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley added a comment. Thanks! I don't have commit access, I was just reading here what to do: > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. Ah, and to your direct question: > BTW, the test wasn't checking for the note's message at all?" Right, the generated test file does not ever do `// CHECK-MESSAGES: :Row:Col: note: insert 'awesome'` (nor does the LIT setup here enforce that notes need to be

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley added a comment. In D109210#2981912 , @whisperity wrote: > Uuuh.. I get the sentiment, but this change breaks the very essence of the > joke that the default generated code wants to pass on. It also does not > showcase that we can emit

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley created this revision. mattbeardsley added reviewers: njames93, aaron.ballman. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Per this commit, "Note"

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley added a comment. No worries! Figured I'd start the conversation with the easy fix, but was fully prepared to hear that we can't let go of python 2 just yet, as much as we may want to :). Let me know if this fix looks suitable. Thanks for your time! Repository: rG LLVM Github

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley updated this revision to Diff 370393. mattbeardsley retitled this revision from "Use python 3 in add_new_check.py and rename_check.py" to "Fix python 2-vs-3 issues in add_new_check.py and rename_check.py". mattbeardsley edited the summary of this revision. mattbeardsley added a

[PATCH] D109127: Use python 3 in add_new_check.py and rename_check.py

mattbeardsley created this revision. mattbeardsley added a reviewer: kbobyrev. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. As of this commit: https://github.com/llvm/llvm-project/commit/307b1fdd If either