[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris accepted this revision. ormris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154923/new/ https://reviews.llvm.org/D154923

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

ormris added a comment. This is a good way to resolve the inconsistencies I was looking at in my own review. > I think whether a bitcode input file contains 2 modules (internal > implementation strategy) should not be a criterion to require an additional > driver option Agreed. Most users

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. > You can be more specific that multi-module bitcode files are for > -fsanitize=cfi and -fwhole-program-vtables. And it will be more useful to > include an example in the summary. Fixed. > This is a bit odd as the -o file may no longer an output. This could be >

[PATCH] D123971: [clang][PS4] Enable SplitLTOUnits by default

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123971/new/ https://reviews.llvm.org/D123971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123971: [clang][PS4] Enable SplitLTOUnits by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG392b30680752: [clang][PS4] Enable SplitLTOUnits and Unified LTO by default (authored by ormris). Herald added a project: clang. Herald added a

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. Thanks! Pushed as 048a0c246908291c82d2f4531d3df45a4c4a8a18 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris updated this revision to Diff 538867. ormris added a comment. Attempt to fix pre-merge checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 Files: clang/include/clang/CodeGen/CodeGenAction.h clang/lib/CodeGen/CodeGenAction.cpp

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris added a comment. Yes, I'm working on a new test that's less target dependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 ___ cfe-commits mailing

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris updated this revision to Diff 535202. ormris added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153906/new/ https://reviews.llvm.org/D153906 Files: clang/include/clang/CodeGen/CodeGenAction.h

[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

ormris created this revision. ormris added reviewers: efriedma, rjmccall, MaskRay, aaron.ballman. Herald added subscribers: steven_wu, hiraditya. Herald added a project: All. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147660/new/ https://reviews.llvm.org/D147660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147660: [PS4][clang] Pass -flto-jobs argument to orbis-ld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393a1c3b4fcd: [PS4][clang] Pass -flto-jobs argument to orbis-ld (authored by ormris). Herald added a project: clang. Herald added a subscriber:

[PATCH] D147546: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147546/new/ https://reviews.llvm.org/D147546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147546: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc37b95b515a5: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld (authored by ormris). Herald added a project: clang. Herald

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ormris added a comment. Looks like there are some test failures associated with this commit: https://lab.llvm.org/buildbot/#/builders/123/builds/13698 The change list is a bit confusing, as it's only showing LLVM commits. But the change list includes the commit before and the commit after this

[PATCH] D134296: [SIE] Always enable the .debug_aranges section when using LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45c7da241f12: [PS4] Always enable the .debug_aranges section when using LTO (authored by ormris). Herald added a subscriber: cfe-commits.

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

ormris added a comment. Hi Shangwu, I've reverted this change to unblock the buildbots and our internal CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119207/new/ https://reviews.llvm.org/D119207

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c (authored by ormris). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. I think the test fix is all that's needed for now. This is somewhat urgent for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 ___

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris updated this revision to Diff 372839. ormris added a comment. - Downgrade to C11 and C++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109857/new/ https://reviews.llvm.org/D109857 Files: clang/test/Lexer/char-escapes-delimited.c

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris added a comment. We saw this failure for our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow. Repository: rG LLVM Github

[PATCH] D109857: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

ormris created this revision. ormris added reviewers: cor3ntin, aaron.ballman. ormris requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify the C and C++ standards explicitly for this test. This avoids failures for drivers that default

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ormris added a comment. This is also failing on several build bots: https://lab.llvm.org/buildbot/#/builders/139/builds/4812 Since it's been failing for a few hours, I'd like to revert this in the near future to unclog our internal CI and the buildbots. Repository: rG LLVM Github Monorepo

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. @hoyFB wrote: > @ormris I'd like to follow up on this. We had a similar change internally > which led up to some gains when combined with SPGO, and we'd like to help > move forward with this patch here. Would you mind sharing the plan or > progress on your side?

[PATCH] D98873: Document -fcrash-diagnostics-dir

ormris accepted this revision. ormris added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98873/new/ https://reviews.llvm.org/D98873 ___

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG0386f3d4f418: [NFC] Specify C11 in loop-opt-setup.c (authored by ormris). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/ https://reviews.llvm.org/D94327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

ormris created this revision. ormris added a reviewer: atmnpatel. ormris requested review of this revision. Herald added a project: clang. This test was failing in our internal CI, since our driver does not default to C11. Adding this switch fixes the issue. Repository: rG LLVM Github

[PATCH] D79961: [PGO] Fix computation of fuction Hash

ormris added a comment. There's a few test failures related to this change on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

ormris added a comment. Hi Zach, The tests in this patch are failing on this PS4 windows bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/30273/steps/test-check-all/logs/stdio Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. //Ping// @tejohnson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69732/new/ https://reviews.llvm.org/D69732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO

ormris added a comment. I've done testing with the following global parameters. - The base for the branch is llvmorg-10-init-8655-g94a4a2c97f8 - Used llvm, clang, lld, and llvm-ar from this branch. - The sqlite kvtest program was the test payload. This test compared an unmodified compiler from

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

ormris added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } sammccall wrote: > ormris wrote: > > Quick nit: This test won't work

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

ormris added inline comments. Comment at: clang-tools-extra/unittests/clangd/HeadersTests.cpp:220 + BarHeader = testPath("sub/bar.h"); + EXPECT_EQ(calculate(BarHeader), "\"sub/bar.h\""); } Quick nit: This test won't work on Windows as it only tests for

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

ormris added inline comments. Comment at: test/ClangScanDeps/regular_cdb.cpp:14 +// CHECK: regular_cdb.cpp +// CHECK-NEXT: Inputs/header.h Quick drive-by nit: This test won't work under Windows due to the path separator. To account for both platforms, you could

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ormris added a comment. Hi Ilya, This commit is causing a test failure on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/42251 Thanks, Matthew Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D52058: Add template type and value parameter metadata nodes to template variable specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rC343707: Add template type and value parameter metadata nodes to template variable… (authored by ormris, committed by ). Changed prior to commit: https://reviews.llvm.org/D52058?vs=167849=168152#toc

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. Thanks! I'll go ahead and commit this. Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. //Ping Ping// Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris updated this revision to Diff 167849. ormris added a comment. - Clarify CGDebugInfo::CollectVarTemplateParams Repository: rC Clang https://reviews.llvm.org/D52058 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-template-member.cpp Index:

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. //Ping// Repository: rC Clang https://reviews.llvm.org/D52058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. In https://reviews.llvm.org/D52058#1237868, @JDevlieghere wrote: > Generally this looks good, but I'd like for the other to have a look first > (at this and the other patch) before accepting. Sounds good. Thanks for your comments! Comment at:

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris updated this revision to Diff 165789. ormris added a comment. - Removed unneeded comment - Renamed variable Repository: rC Clang https://reviews.llvm.org/D52058 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-template-member.cpp Index:

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3126 + } else { +templateParameters = nullptr;//llvm::DINodeArray().get(); + } JDevlieghere wrote: > What's the meaning of this comment? Hmm... That should be removed.

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris created this revision. ormris added reviewers: dblaikie, aprantl, probinson, JDevlieghere, clayborg, jingham. This patch adds the associated template parameters to the DWARF name attribute of all template variable specializations, mirroring how they are referenced in the source code.

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. In https://reviews.llvm.org/D47044#1130339, @NoQ wrote: > I'm still curious whether this also works: > > void foo() { > const A = B(); > bar(); > } > > void bar() { > for (int i = 0; i < 10; ++i) {} > } > > > Though we can land this patch and deal

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. Thanks @george.karpenkov . I was wondering why it didn't close automatically. Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris closed this revision. ormris added a comment. This change has been committed, so I'm closing this review. https://reviews.llvm.org/rC334554 Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. Hmm... I'll take a look. Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris marked an inline comment as done. ormris added a comment. Sounds good. I'll go ahead and commit this. Thanks for the review! Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris updated this revision to Diff 151046. ormris added a comment. Remove unneeded header Repository: rC Clang https://reviews.llvm.org/D47044 Files: lib/StaticAnalyzer/Core/LoopWidening.cpp test/Analysis/loop-widening-preserve-reference-type.cpp Index:

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris updated this revision to Diff 151043. ormris added a comment. - Use match function iterators rather than a callback class - Update test Repository: rC Clang https://reviews.llvm.org/D47044 Files: lib/StaticAnalyzer/Core/LoopWidening.cpp

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 +new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + NoQ wrote: > ormris wrote: > > ormris wrote: > > > NoQ wrote: > > > > NoQ wrote: > > > >

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 +new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + ormris wrote: > NoQ wrote: > > NoQ wrote: > > > george.karpenkov wrote: > > > > ormris

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 +new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + NoQ wrote: > NoQ wrote: > > george.karpenkov wrote: > > > ormris wrote: > > > >

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added inline comments. Comment at: lib/StaticAnalyzer/Core/LoopWidening.cpp:89 +new Callback(LCtx, MRMgr, ITraits)); + Finder.matchAST(ASTCtx); + george.karpenkov wrote: > IMO using the iterator directly (e.g. like it was done in >

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris marked 2 inline comments as done. ormris added a comment. Thanks for the review @MTC! I'll wait for @NoQ's feedback. Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris marked 3 inline comments as done. ormris added a comment. Thanks for the comments so far. Comment at: test/Analysis/loop-widening-invalid-type.cpp:1 +// RUN: %clang_cc1 -analyze -analyzer-checker=core,unix.Malloc,debug.ExprInspection -analyzer-max-loop 4

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris updated this revision to Diff 150567. ormris added a comment. Herald added a subscriber: mikhail.ramalho. - Reformat with clang-format-diff.py - Rename test - Modify test to use clang_analyzer_eval Repository: rC Clang https://reviews.llvm.org/D47044 Files:

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris updated this revision to Diff 150377. ormris added a comment. Use AST matchers to select references for preservation Repository: rC Clang https://reviews.llvm.org/D47044 Files: include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h lib/StaticAnalyzer/Core/ExprEngine.cpp

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. Hmm... Thanks for these tips. I'll see what I can find. Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47044: [analyzer] Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. This is my first static analyzer fix, so it may take me some time to figure this out. Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47044: Ensure that we only visit a destructor for a reference if type information is available.

ormris added a comment. That could work. Is the implementation similar? Repository: rC Clang https://reviews.llvm.org/D47044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47044: Ensure that we only visit a destructor for a reference if type information is available.

ormris created this revision. ormris added reviewers: dcoughlin, NoQ, xazax.hun, george.karpenkov. Herald added a subscriber: rnkovacs. Loop widening can invalidate an object reference. If the analyzer attempts to visit the destructor to a non-existent object it will crash. This patch ensures

[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

ormris abandoned this revision. ormris added a comment. After some further inspection, support for the LLVM side of patch needs a few significant additions. Abandoning this revision. Repository: rC Clang https://reviews.llvm.org/D46139 ___

[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

ormris added a comment. Thanks for spotting that @probinson. Will update. Repository: rC Clang https://reviews.llvm.org/D46139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

ormris created this revision. ormris added reviewers: dblaikie, probinson, aprantl, JDevlieghere, clayborg. Depends on LLVM patch: https://reviews.llvm.org/D46138 Resolves PR22119 Repository: rC Clang https://reviews.llvm.org/D46139 Files: lib/CodeGen/CGDebugInfo.cpp

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris abandoned this revision. ormris added a comment. I'm abandoning this revision based on some internal feedback. Thanks for the review @JDevlieghere and @jingham! Repository: rC Clang https://reviews.llvm.org/D44842 ___ cfe-commits mailing

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. No such luck... Patch: Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp === --- source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp (revision 329079) +++

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. About to test with CPlusPlus14 enabled Here's the output from those two commands. (lldb) frame var -g crazy error: no variable named 'crazy' found in this frame (lldb) frame var -g crazy error: no variable named 'crazy' found in this frame (lldb)

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. @jingham Doesn't look like it works. $ cat repro.cpp template T crazy = T(); int main(void) { crazy = 5; return crazy; } $ clang++ -g repro.cpp $ lldb a.out ... (lldb) frame variable (lldb) expr crazy error: use of undeclared identifier

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. @jingham Will do. Repository: rC Clang https://reviews.llvm.org/D44842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a comment. //Ping// Repository: rC Clang https://reviews.llvm.org/D44842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2992 + std::string NameString = Name.str(); + llvm::raw_string_ostream ParameterizedName(NameString); + ParameterizedName << "<"; JDevlieghere wrote: > Why not use Name.str()

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris added a project: debug-info. ormris added a comment. Adding debug-info project tag. Repository: rC Clang https://reviews.llvm.org/D44842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris created this revision. ormris added reviewers: dblaikie, aprantl, probinson, JDevlieghere. This patch adds the associated template parameters to the DWARF name attribute of all template variable specializations, mirroring how they are referenced in the source code. Repository: rC Clang

[PATCH] D44218: Correct the alignment for the PS4 target

ormris abandoned this revision. ormris added a comment. @echristo accepted this revision via cfe-commits. As it's now commited, I'm abandoning this revision. Repository: rC Clang https://reviews.llvm.org/D44218 ___ cfe-commits mailing list

[PATCH] D44218: Correct the alignment for the PS4 target

ormris created this revision. ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. See above. Repository: rC Clang https://reviews.llvm.org/D44218 Files: lib/Basic/Targets/OSTargets.h test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

ormris added a comment. Great. Thanks for the review! I don't have commit access currently. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

ormris added a comment. An ABI change was introduced in r254596 that modified structure layouts when the 'packed' attribute was used on one-byte bitfields. Since the PS4 target needs to maintain backwards compatibility for all structure layouts, this change reintroduces the old behavior for