[PATCH] D117500: [clang] Mention MS on-demand TLS initialization in release notes

momo5502 added a comment. Seems like this can be merged, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117500/new/ https://reviews.llvm.org/D117500 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D115456: [MS] Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 added a comment. In D115456#3248313 , @hans wrote: > Looks great, thanks! Maurice, do you want to add a note about this to > docs/ReleaseNotes.rst? Good point. I created a new change: https://reviews.llvm.org/D117500 Repository: rG LLVM Git

[PATCH] D117500: [clang] Mention MS on-demand TLS initialization in release notes

momo5502 created this revision. momo5502 added reviewers: majnemer, hans. momo5502 added a project: clang. momo5502 requested review of this revision. Herald added a subscriber: cfe-commits. In change https://reviews.llvm.org/D115456 on-demand TLS initialization for Microsoft CXX ABI was added.

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 397107. momo5502 added a comment. In D115456#3217857 , @majnemer wrote: > In D115456#3217595 , @momo5502 > wrote: > >> In D115456#3216811

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 added a comment. In D115456#3216811 , @majnemer wrote: > This is looking great! Just a few more questions. > > What is the behavior with something like: > > thread_local int x = 2; > int f() { > return x; > } > > I'm wondering if we nee

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 396783. momo5502 marked 4 inline comments as done. momo5502 added a comment. Comments were addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456 Files: clang/include/clang/Basic/LangOptions.h clan

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 395856. momo5502 edited the summary of this revision. momo5502 added a comment. Herald added a subscriber: dexonsmith. A call to `isCompatibleWithMSVC` was added with the proper version that introduced the change (1925) and comments describing the intention

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 393247. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/ms-thread_local.cpp Index: clang/test/CodeGenCXX/ms-thread_local.cpp =

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 created this revision. momo5502 added reviewers: rnk, eugenis. momo5502 added a project: clang. momo5502 requested review of this revision. Herald added a subscriber: cfe-commits. TLS initializers, for example constructors of thread-local variables, don't necessarily get called. If for e