joker-eph wrote:
Reverted in 7d4a45d98275e669bda40410f064891beb3480ce ; test is failing like
this on Windows:
```
# RUN: at line 3
c:\ws\buildbot\premerge-monolithic-windows\build\bin\clang.exe -cc1
-internal-isystem
C:\ws\buildbot\premerge-monolithic-windows\build\lib\clang\19\include
Author: Mehdi Amini
Date: 2024-05-29T21:56:59-07:00
New Revision: 7d4a45d98275e669bda40410f064891beb3480ce
URL:
https://github.com/llvm/llvm-project/commit/7d4a45d98275e669bda40410f064891beb3480ce
DIFF:
https://github.com/llvm/llvm-project/commit/7d4a45d98275e669bda40410f064891beb3480ce.diff
joker-eph wrote:
Reverted in https://github.com/llvm/llvm-project/pull/93767
(maybe it's just a missing explicit triple in the test?)
https://github.com/llvm/llvm-project/pull/87018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/93767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/93767
Reverts llvm/llvm-project#87018
MacOS and Windows bots are broken.
>From a35c320e18ba2abad17eab0ed162c4115601a828 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Wed, 29 May 2024 22:47:35 -0600
Subject:
joker-eph wrote:
It also fails on Windows:
https://lab.llvm.org/buildbot/#/builders/271/builds/8095
https://github.com/llvm/llvm-project/pull/87018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joker-eph wrote:
There is a broken test in CI:
https://lab.llvm.org/buildbot/#/builders/272/builds/17864
https://github.com/llvm/llvm-project/pull/81545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joker-eph wrote:
What part of the "camelBack" is visible to the user of the API?
(and in general the method prototype in the header should likely use the same
parameter names as the implementation file)
https://github.com/llvm/llvm-project/pull/91007
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
>
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
>
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/92740
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
@@ -68,7 +68,7 @@ function compute-projects-to-test() {
done
;;
clang)
- for p in clang-tools-extra compiler-rt flang lldb cross-project-tests; do
+ for p in clang-tools-extra compiler-rt lldb cross-project-tests; do
joker-eph wrote:
joker-eph wrote:
> It's a sed s/== None/is None/g - what is there to review?
On my I'm not asking for more reviews, this is why I commented that this should
be **pushed** in multiple commits, I don't even need to see PRs.
Another thing also mentioned above was the problem of reverts.
If there
https://github.com/joker-eph approved this pull request.
If you can push this to main in separate commits (one per project as it was
mentioned?), that'd be great!
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
joker-eph wrote:
You're right, it's visible on the link I posted, the build was already broken!
Somehow I fat-fingered and didn't hit the first red build but the third one!
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
joker-eph wrote:
Great, thanks for the quick fix!
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
So are we reverting here or do you have quick fix available?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Seems like a bot is broken:
https://lab.llvm.org/buildbot/#/builders/271/builds/7701 ; can you check?
https://github.com/llvm/llvm-project/pull/90820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Mehdi Amini
Date: 2024-05-14T19:53:38-07:00
New Revision: eb103104ef08ebc2d0de63db0592e76b294cf8bb
URL:
https://github.com/llvm/llvm-project/commit/eb103104ef08ebc2d0de63db0592e76b294cf8bb
DIFF:
https://github.com/llvm/llvm-project/commit/eb103104ef08ebc2d0de63db0592e76b294cf8bb.diff
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/91007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -42,6 +47,14 @@ CreateFrontendBaseAction(CompilerInstance ) {
StringRef Action("unknown");
(void)Action;
+ auto UseCIR = CI.getFrontendOpts().UseClangIRPipeline;
joker-eph wrote:
MLIR isn't meant to differ from LLVM/Clang.
> Coding standard doesn't
joker-eph wrote:
Actually your premerge failure here was an infra issue, but the CI is still
broken after this PR somehow:
https://lab.llvm.org/buildbot/#/builders/271/builds/7420
https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits
joker-eph wrote:
CI failure wasn't unrelated actually: the CI is consistently broken after this
patch (you have got an email about it?), I'll revert for now.
https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits mailing list
joker-eph wrote:
PR should be named according to what they are actually achieving, I'm not sure
why the GitHub issue title is relevant?
https://github.com/llvm/llvm-project/pull/90391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
joker-eph wrote:
This seems to have broken the bot:
https://github.com/llvm/llvm-project/pull/89476 (you should have had an email?)
I reverted in https://github.com/llvm/llvm-project/pull/89476
https://github.com/llvm/llvm-project/pull/89378
___
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/89476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/89476
Reverts llvm/llvm-project#89378
Broke the windows premerge checks
https://lab.llvm.org/buildbot/#/builders/271/builds/6788
>From 7897826aa7931ffc854a88b20e5ab8bf976ad093 Mon Sep 17 00:00:00 2001
From: Mehdi
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/89294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -433,7 +433,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final
Value *foldAndOrOfICmpsOfAndWithPow2(ICmpInst *LHS, ICmpInst *RHS,
Instruction *CxtI, bool IsAnd,
bool IsLogical = false);
-
joker-eph wrote:
This broke a bot, I reverted and it's back green here:
https://lab.llvm.org/buildbot/#/builders/272/builds/14069
https://github.com/llvm/llvm-project/pull/87130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/88919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/88919
Reverts llvm/llvm-project#87130
Bot is broken with clang crash:
https://lab.llvm.org/buildbot/#/builders/272/builds/14063/steps/6/logs/stdio
>From 271a8c2e5c8f57ab5d37f6056713dab530424470 Mon Sep 17
joker-eph wrote:
LGTM overall, but the CI failure looks real.
https://github.com/llvm/llvm-project/pull/86318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/85354
Clang has a custom separate pipeline integrated with libc++ that only runs in
release mode. It means that changes which touches only clang won't run the
clang tests in the configuration used by LLVM premerge
@@ -104,7 +104,7 @@ static std::recursive_mutex *g_debugger_list_mutex_ptr =
nullptr; // NOTE: intentional leak to avoid issues with C++ destructor
chain
static Debugger::DebuggerList *g_debugger_list_ptr =
nullptr; // NOTE: intentional leak to avoid issues with C++
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/83702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From d1dc1dfb1bb601fe90289bf29176c74a38ac5697 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Tue, 5 Mar 2024 10:38:41 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From ea79b6037497230b23caf36024a9e6883d3cac04 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Tue, 5 Mar 2024 10:38:41 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From 1b407d9d5abc9a1cf58afaf7f32ed40446d55f52 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Tue, 5 Mar 2024 10:38:41 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/83702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
Actually no: the first patch landed already, so `ThreadPoolInterface` is now
the base class in the codebase. I have some mixup here in that when renaming
ThreadPool -> DefaultThreadPool, I used the base class ThreadPoolInterface when
updating some of the uses.
I will push
joker-eph wrote:
I did the first part of the renaming @dwblaikie : looks good?
https://github.com/llvm/llvm-project/pull/83702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From f961f22a3643673c1f3a040715dcfa2887ee1dca Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Mon, 4 Mar 2024 23:21:04 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From 41e5c286c29a4fea65f6116f6844b44a3847f9db Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Mon, 4 Mar 2024 23:21:04 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
Author: Mehdi Amini
Date: 2024-03-02T19:54:35-08:00
New Revision: c4621607245a5feed42cf9f748ff796728ef579a
URL:
https://github.com/llvm/llvm-project/commit/c4621607245a5feed42cf9f748ff796728ef579a
DIFF:
https://github.com/llvm/llvm-project/commit/c4621607245a5feed42cf9f748ff796728ef579a.diff
joker-eph wrote:
Fine with me if we want to land this as is, but per-top-level subproject may be
a better granularity.
https://github.com/llvm/llvm-project/pull/82838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/82296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/82296
>From 8c236920e5eb5703a64cd89a45f2cc89607b96fd Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Mon, 19 Feb 2024 17:34:33 -0800
Subject: [PATCH] Rename `ThreadPool::getThreadCount()` to
`getMaxConcurrency()`
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/82296
This is addressing a long-time TODO to rename this misleading API. The old one
is preserved for now but marked deprecated.
>From d381cf98345ff6a817958519a5aa456fbfdea1d2 Mon Sep 17 00:00:00 2001
From: Mehdi
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/80246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
> I think you are assuming guarantees here that doesn't exist.
I'm just going by you're writing :)
You wrote: "To be able to flag incompatible bytecode files rather than have it
fail later in mysterious ways"
But my take is that you're not actually providing the ability to
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/77820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -106,6 +106,12 @@ the LINK_COMPONENTS descriptor. This allows cmake
infrastructure to
generate new library targets with correct linkage, in particular, when
BUILD_SHARED_LIBS=on or LLVM_LINK_LLVM_DYLIB=on are specified.
+Registration of the dialect can be performed
joker-eph wrote:
> To be able to flag incompatible bytecode files rather than have it fail later
> in mysterious ways. E.g., allows for a more strict failure.
That would require some sort of principles and policy around the changes that
affect the serialization of this and the maintenance of
https://github.com/joker-eph requested changes to this pull request.
This lack some information to me:
- What is the purpose of this?
- What kind of compatibility is this supposed to provide?
- What is the versioning scheme?
https://github.com/llvm/llvm-project/pull/79514
joker-eph wrote:
- Reverting a change that way costs me 3 clicks: it is the lowest cost on me to
fix the CI.
- We likely want people to be able to use the pre-merge checks independently of
the reviews: you're way of tying "opening a PR" to some expectations (that
aren't clear to me) seems to
joker-eph wrote:
Sorry, had to revert because this broke a buildbot:
```
llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of
'llvm::Error'
return E;
^
```
https://lab.llvm.org/buildbot/#/builders/61/builds/53704
https://github.com/llvm/llvm-project/pull/78120
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/79976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/79976
Reverts llvm/llvm-project#78120
Buildbot is broken:
llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of
'llvm::Error'
return E;
^
>From
joker-eph wrote:
I had to revert because this broke a bot:
https://lab.llvm.org/buildbot/#/builders/264/builds/6131
```
# RUN: at line 1
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-opt
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/76292
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -897,7 +921,8 @@ struct TransferOpConversion : public
VectorToSCFPattern {
} else {
// It's safe to assume the mask buffer can be unpacked if the data
// buffer was unpacked.
-auto castedMaskType = *unpackOneDim(maskBufferType);
+auto
@@ -866,16 +866,41 @@ struct TransferOpConversion : public
VectorToSCFPattern {
this->setHasBoundedRewriteRecursion();
}
+ static void getMaskBufferLoadIndices(OpTy xferOp, Value castedMaskBuffer,
+ SmallVector ,
+
@@ -897,7 +921,8 @@ struct TransferOpConversion : public
VectorToSCFPattern {
} else {
// It's safe to assume the mask buffer can be unpacked if the data
// buffer was unpacked.
-auto castedMaskType = *unpackOneDim(maskBufferType);
+auto
@@ -866,16 +866,41 @@ struct TransferOpConversion : public
VectorToSCFPattern {
this->setHasBoundedRewriteRecursion();
}
+ static void getMaskBufferLoadIndices(OpTy xferOp, Value castedMaskBuffer,
+ SmallVector ,
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/74475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/71430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry )
{
registerLLVMDialectTranslation(registry);
registerNVVMDialectTranslation(registry);
registerROCDLDialectTranslation(registry);
+ registerSPIRVDialectTranslation(registry);
@@ -0,0 +1,31 @@
+//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/joker-eph approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/74200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/74340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joker-eph wrote:
> Is it possible to add the test case (or minimal similar example) with
> `--inline` option so that we can confirm the original issue is resolved.
>
> #73383
It is common that the person filing the issue does not reduce the IR or the
pipeline that causes the bug.
In
@@ -0,0 +1,14 @@
+// RUN: mlir-opt %s -inline -split-input-file | FileCheck %s
+
+// CHECK-LABEL: func @inline_negative_stride
+func.func @inline_negative_stride(%arg0 : memref<10xf32>) -> memref<1xf32,
strided<[?], offset: 1>> {
+ cf.br ^bb1(%arg0 : memref<10xf32>)
+^bb1(%m:
joker-eph wrote:
FYI the build is failing (maybe re-running would be enough though)
https://github.com/llvm/llvm-project/pull/72801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/72801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/71430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry )
{
registerLLVMDialectTranslation(registry);
registerNVVMDialectTranslation(registry);
registerROCDLDialectTranslation(registry);
+ registerSPIRVDialectTranslation(registry);
@@ -0,0 +1,31 @@
+//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry )
{
registerLLVMDialectTranslation(registry);
registerNVVMDialectTranslation(registry);
registerROCDLDialectTranslation(registry);
+ registerSPIRVDialectTranslation(registry);
https://github.com/joker-eph approved this pull request.
Nice, thanks!
https://github.com/llvm/llvm-project/pull/72059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -274,6 +278,23 @@ StringRef::size_type
StringRef::find_first_not_of(StringRef Chars,
/// Note: O(size() + Chars.size())
StringRef::size_type StringRef::find_last_of(StringRef Chars,
size_t From) const {
+#ifdef __SSE2__
+ if
https://github.com/joker-eph approved this pull request.
LG (with one edit)
https://github.com/llvm/llvm-project/pull/71726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18,31 +18,34 @@ def Tensor_Dialect : Dialect {
let description = [{
The `tensor` dialect is intended to hold core tensor creation and
manipulation ops, which are not strongly associated with any particular
-other dialect or domain abstraction. The primary
joker-eph wrote:
> > This looks like a good fix for the verifier, but we should also fix the
> > canonicalization to **not** create invalid IR!
>
> Then I think that I'll implement the suggestions from Matthias in this PR and
> leave the canonicalization for a future PR. For that future PR,
joker-eph wrote:
> tests will fail locally but pass everywhere else (for example, people
> working on slightly out-of-norm configurations will sometimes have persistent
> local failures that are unrelated to changes in the patch).
It never happened to me, in a way that can't be root caused
joker-eph wrote:
> I've seen those exact test failures locally, but since precommit CI was fine,
> I landed this PR and kept a close eye on the bots.
If you see failures locally, it's best to understand where they coming from:
even if it passes on bots it just means we have a hole in our test
@@ -95,7 +95,7 @@ class SerializeToHsacoPass
std::unique_ptr>
serializeISA(const std::string ) override;
- std::unique_ptr> assembleIsa(const std::string );
+ std::unique_ptr> assembleIsa(const std::string );
joker-eph wrote:
@krzysz00 can you change
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/71165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/71165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mehdi Amini
Date: 2023-11-03T03:23:43-07:00
New Revision: 3289ecff8e8f5022cb6a40777392c98f1bcf5780
URL:
https://github.com/llvm/llvm-project/commit/3289ecff8e8f5022cb6a40777392c98f1bcf5780
DIFF:
https://github.com/llvm/llvm-project/commit/3289ecff8e8f5022cb6a40777392c98f1bcf5780.diff
joker-eph wrote:
Need to iterate a bit more on framing the problem:
> MLIR is a general infrastructure and as far as possible no dialect is
> intended to be special or privileged
Yes, and you can use MLIR without PDL, it's not a mandatory component. I
believe that the minimal examples
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/70283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/70283
>From 0bdf7a0bc1c1e3b5fc3280e9ba5f5cacfeeb5f7f Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Wed, 25 Oct 2023 19:17:32 -0700
Subject: [PATCH 1/3] Update Bufferization.md
---
mlir/docs/Bufferization.md |
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/70283
>From 0bdf7a0bc1c1e3b5fc3280e9ba5f5cacfeeb5f7f Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Wed, 25 Oct 2023 19:17:32 -0700
Subject: [PATCH 1/2] Update Bufferization.md
---
mlir/docs/Bufferization.md |
joker-eph wrote:
Can you expand on the motivation? Why is it a problem that PDL is always
included? Your description isn’t very explicit on the impact.
https://github.com/llvm/llvm-project/pull/69927
___
cfe-commits mailing list
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/69878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 432 matches
Mail list logo
