[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a subscriber: kbsmith1. mibintc added a comment. There was a long discussion on cfe-dev about this issue approximately January-February 2020 including @scanon @andrew.w.kaylor and many others. While there wasn't 100% consensus to move to ffp-contract=on there are many reasons to

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#2917357 , @haowei wrote: > We are seeing float related unit tests failing in Fuchsia after this patch. > What flags should we add to our build to match llvm's previous float point > behavior? This option:

[PATCH] D102343: [clang][patch][FPEnv] Make Initialization of C++ globals strictfp aware

mibintc added a comment. @MaskRay Thanks a lot -- yes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc5b5ea037db: [clang][patch][FPEnv] Make initialization of C++ globals strictfp aware (authored by mibintc). Repository: rG LLVM Github Monorepo

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was automatically updated to reflect the committed changes. Closed by commit rG66ddac22e2a7: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D93769?vs=360247=362385#toc Repository:

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rG48ad446a0fb2: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

mibintc added a reviewer: zahiraam. mibintc added a subscriber: zahiraam. mibintc added a comment. Adding @zahiraam FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863

[PATCH] D106863: Allow #pragma float_control(push|pop) within a language linkage specification

mibintc accepted this revision. mibintc added a comment. Thanks for fixing this Aaron, just curious was there a bug report? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106863/new/ https://reviews.llvm.org/D106863

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. I tested this patch downstream on Windows with Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29334 for x64 I used c++20, x++latest default and c++17 with the stl header files

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. Whoops, shouldn't mess with the mkdir line diff --git a/clang/test/Index/preamble-reparse-changed-module.m b/clang/test/Index/preamble-reparse-changed-module.m index 1c63e802ce0c..349ed0db27d0 100644 - a/clang/test/Index/preamble-reparse-changed-module.m +++

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. @bnbarham I think you mean a patch like this, is it right? I'd like to fix the test in a pre-commit and then re-push my patch git diff diff --git a/clang/test/Index/preamble-reparse-changed-module.m b/clang/test/Index/preamble-reparse-changed-module.m index

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. @MaskRay I experience that the failing test clang/test/Index/preamble-reparse-changed-module.m is non-deterministic and currently I cannot reproduce the fail. I added details in D95159 . Are you able to reproduce if you clean your

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: MaskRay. mibintc added a comment. More info about the test failure I'm seeing for clang/test/Index/preamble-reparse-changed-module.m It appears it might be a non-deterministic failure, perhaps some test dependencies are missing? Yesterday before I pushed my clang

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. I had to revert again, it's still failing on Intel buildbots. Cannot reproduce on Intel-internal Broadwell server. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9b696bba670: [clang][fpenv][patch] Change clang option -ffp-model=precise to select ffp… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: aaron.ballman. mibintc added a comment. @aaron.ballman suggested I may have made a mistake adding the new option, I'll look there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. The newly added test case clang/test/Index/preamble-reparse-changed-module.m is failing on the patch that I'm trying to commit, https://reviews.llvm.org/D93769 Actually the result of the test is a bit flaky, when I build the Debug version on Linux, running ninja

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891552 , @MaskRay wrote: > In D93769#2891549 , @mibintc wrote: > >> In D93769#2891545 , @MaskRay wrote: >> >>> This breaks

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/test/Preprocessor/predefined-flteval-macro.c:332 +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64 -fsyntax-only %s +// RUN: %clang_cc1 -std=c11 -ffreestanding -triple=riscv64-unknown-linux -fsyntax-only %s +#ifndef

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added a comment. In D93769#2891545 , @MaskRay wrote: > This breaks `clang/test/Index/preamble-reparse-changed-module.m` > > http://45.33.8.238/linux/51638/step_7.txt I saw this fail on console when i do "ninja check-clang" but when I run each

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce8024e8ff76: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend… (authored by mibintc). Repository: rG LLVM Github

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360225. mibintc added a comment. Removed use of auto, and used different capitalization for local var name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/ https://reviews.llvm.org/D102343 Files:

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc marked an inline comment as done. mibintc added a comment. Question for Aaron Comment at: clang/include/clang/AST/Decl.h:1993 const DeclarationNameInfo , QualType T, - TypeSourceInfo *TInfo, StorageClass S, bool isInlineSpecified, -

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 360222. mibintc added a comment. Partially respond to @aaron.ballman 's review by refactoring a change into a separate commit, but I'll push back on another request, I'll add that reply inline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105997: Implement _ExtInt conversion rules

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 ___ cfe-commits mailing list

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 359847. mibintc marked 3 inline comments as done. mibintc added a reviewer: zahiraam. mibintc added a comment. I've rebased and applied clang-format. I'd like to push this, looking for your +1, thank you! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:395 MethodNameLoc), - MethodType, MethodTypeInfo, SC_None, + MethodType, MethodTypeInfo, SC_None, /*UsesFPIntrin*/ false,

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc updated this revision to Diff 359772. mibintc added a reviewer: zahiraam. mibintc added a comment. Respond to @aaron.ballman 's review, rebased & used clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102343/new/

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mibintc added a comment. Intel compiles VS2019 #include files regularly with clang, and the file compiled with -std:c++latest encounters this error report, which @aaron.ballman suggests is related to this effort. In file included from tst_incl_filesystem.cpp:2: c:/Program files

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was automatically updated to reflect the committed changes. Closed by commit rGe773216f4636: [clang][patch] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaba37187fda: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. More buildbot failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbe1c675fe9: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. buildbot fails in lldb, will submit updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/ https://reviews.llvm.org/D104729

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. buildbot fails on lldb need to update this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f1238e44d80: [clang][patch][fpenv] Add builtin __arithmetic_fence and option fprotect-parens (authored by mibintc). Repository: rG LLVM Github

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c02b0c3f454: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG931e95687d6d: [llvm][clang][fpenv] Create new intrinsic llvm.arith.fence to control FP… (authored by mibintc). Repository: rG LLVM Github

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354301. mibintc added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Builtins.def

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 354300. mibintc added a comment. Rebasing. Hope this clears lit fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files: llvm/docs/LangRef.rst

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 11 inline comments as done. mibintc added a comment. some inline replies. I think this is all set now. Comment at: clang/lib/Sema/SemaExpr.cpp:4026 + !E->isLValue() && + (ExprTy->isFloatingType() || (ExprTy->isComplexType( { +return

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354061. mibintc marked 2 inline comments as done. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/ https://reviews.llvm.org/D100118 Files:

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc marked 9 inline comments as done. mibintc added a comment. A couple inline replies to go along with the updated patch Comment at: clang/include/clang/Driver/Options.td:1757 + LangOpts<"ProtectParens">, DefaultFalse, + PosFlag Should this option also be exposed to

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 354009. mibintc added a comment. The patch I uploaded for review yesterday wasn't correct, not sure what happened. This one looks better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100118/new/

[PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc created this revision. mibintc added a reviewer: aaron.ballman. mibintc added a project: clang. Herald added subscribers: kerbowa, kbarton, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. mibintc requested review of this revision. Herald added a subscriber: aheejin. In

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 353719. mibintc added a comment. Herald added subscribers: jdoerfert, hiraditya. This patch addresses almost all the review comments, not yet sure about @aaron.ballman 's question about CoreOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. I’ve been trying to commit this patch. However, when I commit, the tests fail some 21 floating point tests in LNT. Also there is both performance improvement as well as regression which shouldn’t happen because the sum total of my clang patch + my LNT patch should

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. Reply to @joerg proposing new wording for the option description Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. The bot is showing a fail due to this patch, see https://lab.llvm.org/buildbot#builders/110/builds/4007 It looks like my updates to LNT earlier this week haven't been migrated to the bot, is that right? See

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added inline comments. Comment at: clang/docs/UsersManual.rst:1501 - * ``precise`` Disables optimizations that are not value-safe on floating-point data, although FP contraction (FMA) is enabled (``-ffp-contract=fast``). This is the default behavior. + *

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

This revision was automatically updated to reflect the committed changes. Closed by commit rG8daac3714083: [clang][FPEnv] Clang floatng point model ffp-model=precise enables ffp… (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/D74436?vs=345526=351156#toc Repository:

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350912. mibintc retitled this revision from "[llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level" to "[llvm][clang] Create new intrinsic llvm.arithmetic.fence to control FP optimization at expression level".

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350700. mibintc added a comment. I corrected error in LangRef documentation that @pengfei pointed out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99675/new/ https://reviews.llvm.org/D99675 Files:

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 350307. mibintc added a comment. This patch addresses all of @craig.topper comments and adds documentation for the new intrinsic to the language reference as requested by @LuoYuanke nke Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. question for @aaron.ballman Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated.

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 349644. mibintc added a comment. I made a change to ActOnParenExpr to check that the parenthesized expression is not an lvalue before inserting the call to builtin __arithmetic_fence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a subscriber: lebedev.ri. mibintc added a comment. In D74436#2785730 , @lebedev.ri wrote: > No real comments from me. > I assume, the errors are because `-ffp-contract=on` actually results in > *less* error? Yes, FMA improves accuracy,

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. Hoping @lebedev.ri will take a look since he requested changes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___ cfe-commits

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 348052. mibintc retitled this revision from "[clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens" to "[clang] Add support for new builtin __arithmetic_fence to control floating

[PATCH] D99675: [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 348046. mibintc retitled this revision from "RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level" to "[llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level".

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. I created https://reviews.llvm.org/D102861 to make changes to the failing LNT tests. Hoping to push this commit after the test changes in D102862 are approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#2190566 , @lebedev.ri wrote: > In D74436#2190492 , @lebedev.ri > wrote: > >> <...> > > And by codegen changes i mostly mean newly-set/now-unset fp fast-math > instruction flags.

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30dfa86760c: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer… (authored by mibintc). Repository: rG LLVM Github

[PATCH] D101192: Add support for #elifdef and #elifndef

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. let 'er rip CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. There are 3 clang settings for ffp-contract (on, off, fast) but the FMF bits have only "allow contract". Clang sets the "allow contract" bit in the IRBuilder only when ffp-contract=fast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc updated this revision to Diff 345526. mibintc added a comment. I rebased and enhanced the test case clang/test/CodeGen/ffp-contract-option.c to show the effect of various ffp-contract={on,fast,off} * ffast-math=on,off in response to the request from @lebedev.ri ; sorry for leaving

[PATCH] D94376: [MemCpyOpt] Enable MemorySSA by default

mibintc added a comment. In my premerge testing, I see this fail which looks like the check string is incorrect: command stderr: C:\ws\w16e2-2\llvm-project\premerge-checks\llvm\test\Other\new-pm-lto-defaults.ll:84:21: error: CHECK-O23SZ-NEXT: expected string not found in input ;

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345273. mibintc added a comment. Corrected the failing lit test and applied the clang-format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files:

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757316 , @aaron.ballman wrote: > In D101640#2757178 , @mibintc wrote: > >> In D101640#2757039 , >> @aaron.ballman wrote: >> >>>

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757039 , @aaron.ballman wrote: > Thanks! The last remaining question to me is whether this should be a > target-specific option or whether it makes sense to allow it as an option for > any target. I thought the

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345154. mibintc added a comment. I responded to most all @aaron.ballman 's review comments, may need a little more wordsmithing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + aaron.ballman wrote: > Can you also add a test for K C functions? e.g., `int knr();` `sum = > knr(sum, u32, s32, u16, s16, u8, s8);` > > Also, can you

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:700 CurCodeDecl = D; - if (const auto *FD = dyn_cast_or_null(D)) -if (FD->usesSEHTry()) - CurSEHParent = FD; + const FunctionDecl *FD = dyn_cast_or_null(D); + if (FD &&

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc created this revision. mibintc added reviewers: kpn, rjmccall, aaron.ballman, pcc. Herald added a subscriber: martong. Herald added a reviewer: shafik. mibintc requested review of this revision. Herald added a project: clang. In the proposed patch https://reviews.llvm.org/D81178 @kpn

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 9 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:181 IdentifierInfo *Ident__is_target_environment;// __is_target_environment + IdentifierInfo *Ident__FLT_EVAL_METHOD__;//

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 343666. mibintc added a comment. Respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/ https://reviews.llvm.org/D93769 Files: clang/docs/LanguageExtensions.rst

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc marked 5 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:234 +FEM_Extended, +/// Use the default float eval method specified by Target +FEM_TargetDefault mibintc wrote: >

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 342792. mibintc added a comment. I rebased the patch and responded to review comments from @aaron.ballman and @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93769/new/

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342750. mibintc added a comment. Responded to suggestions from @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files:

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342478. mibintc retitled this revision from "[clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls" to "[clang][patch] Add support for option -fextend-arguments={32,64}: widen integer

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. @erichkeane Can you suggest reviewers for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 ___ cfe-commits mailing list

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls

mibintc created this revision. mibintc added reviewers: kbsmith1, erichkeane. mibintc added a project: clang-c. Herald added subscribers: dexonsmith, dang, Anastasia. mibintc requested review of this revision. Herald added a project: clang. The Intel C++ and Fortran compilers support the option

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc abandoned this revision. mibintc added a comment. There was no resolution about what option name would be acceptable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. some inline comments for reviewers Comment at: clang/include/clang/Basic/TargetInfo.h:1162 /// the language based on the target options where applicable. - virtual void adjust(LangOptions ); + virtual void adjust(DiagnosticsEngine , LangOptions );

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 340598. mibintc added a reviewer: aaron.ballman. mibintc added a comment. Herald added subscribers: jansvoboda11, dexonsmith, lxfind, dang, kerbowa, kbarton, aheejin, jgravelle-google, sbc100, nhaehnle, jvesely, nemanjai, dschuff. I think this patch is

[PATCH] D101192: Add support for #elifdef and #elifndef

mibintc added a comment. Wow thanks for doing this! I worked on it a couple days a while ago but I abandoned the effort and went back to my day job. It seems like preprocessing ought to be something like a "state machine" but I couldn't figure out the mechanism. Would it make sense to add

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); mibintc wrote: > mibintc wrote: > > kpn

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); mibintc wrote: > kpn wrote: > > Does this say

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2844 + return RValue::get( + Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); +return RValue::get(ArgValue); kpn wrote: > Does this say that the fence

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

mibintc added a comment. The diff appears to be 2 separate commits, so on first glance this is only patching the test files. Usually if I am working on a patch and have responded to comments, I compress the patch+updates into a single commit (git rebase -i) before creating a diff to upload to

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc added a comment. In D99675#2695424 , @kpn wrote: > What changes are needed for a backend, and what happens if they aren't done? In the clang patch, I'm planning to add into TargetInfo a function like "does the target support __arithmetic_fence"?

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 338099. mibintc added a comment. I accidentally dropped the test case in previous commit. Just adding it back in -- under the llvm/test directory (previously it was in the wrong location). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100118: [clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc updated this revision to Diff 337881. mibintc retitled this revision from "[clang] RFC Support new builtin __arithmetic_fence to control floating point optiization" to "[clang] RFC Support new builtin __arithmetic_fence to control floating point optimization, and new clang option

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc updated this revision to Diff 337879. mibintc edited the summary of this revision. mibintc added a comment. This is a minor update from @pengfei which allows simple tests cases to run end-to-end with clang. Also I changed the "summary" to reflect the review discussion around the FMA

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

This revision was automatically updated to reflect the committed changes. Closed by commit rG938b863bb53f: [clang][patch] Modify diagnostic level from err to warn… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc updated this revision to Diff 337789. mibintc marked an inline comment as done. mibintc added a comment. I added the InGroup rule for the new warning diagnostic like Aaron requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:299 + " with attribute 'no_caller_saved_registers'">, + InGroup; def warn_arm_interrupt_calling_convention : Warning< rsmith

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc updated this revision to Diff 337731. mibintc added a comment. I removed the diagnostic from InGroup, that's the only change from previous revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/ https://reviews.llvm.org/D100511

[PATCH] D100511: [clang] Modify diagnostic level from err to warn: anyx86_interrupt_regsave

mibintc created this revision. mibintc added a reviewer: aaron.ballman. Herald added a subscriber: pengfei. mibintc requested review of this revision. Herald added a project: clang. I got a bug report that https://reviews.llvm.org/D97764 which introduced this diagnostic, was causing problems in

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

mibintc added a comment. In D97764#2685742 , @craig.topper wrote: > In D97764#2685655 , @mibintc wrote: > >> I received a bug report that this patch creates error diagnostics for calls >> to a builtin, like

  1   2   3   4   5   >