[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

2021-05-20 Thread Melvin Fox via Phabricator via cfe-commits
super_concat marked 3 inline comments as done. super_concat added a comment. @hans, could you land this for me? I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

2021-05-19 Thread Melvin Fox via Phabricator via cfe-commits
super_concat updated this revision to Diff 346595. super_concat added a comment. Correctly handle string literals and add more test cases. Also MSVC by default gives an error when trying to use `__identifier` with a string literal but disabling/surprising that

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

2021-05-18 Thread Melvin Fox via Phabricator via cfe-commits
super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

2021-05-07 Thread Melvin Fox via Phabricator via cfe-commits
super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

2021-04-29 Thread Melvin Fox via Phabricator via cfe-commits
super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D100252: Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

2021-04-10 Thread Melvin Fox via Phabricator via cfe-commits
super_concat created this revision. super_concat added a reviewer: rsmith. super_concat added a project: clang. super_concat requested review of this revision. this patch fixes Bug 27113 by adding support for string literals to the implementation of