[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. > Did Gentoo switch the default long double to IEEE 128-bit floating point? `LDBL_MANT_DIG` is 106, so I guess not yet on this system. > glibc provides 2 printf implementations on ppc64le (different symbols). The > headers control which implementation is used. Is that

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I've tested right now (as of 3398744a6106c83993611bd3c5e79ec6b94417dc ) and all

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I'm sorry, by "new" you mean the version with `uintptr_t` or the original as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Thank you both! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Changing the type from `unsigned long long` to `uintptr_t` fix the test for me. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:246 + EXPECT_FALSE(!Addr); + EXPECT_EQ((unsigned long long), Addr->getValue()); }

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. This change is causing test regressions on 32-bit architectures (I've reproduced with `-m32` on amd64 and in 32-bit nspawn container on arm64): FAIL: Clang-Unit :: Interpreter/./ClangReplInterpreterTests/1/13 (1 of 1584) TEST 'Clang-Unit ::

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added a comment. This is the final version that was pushed, correct? (the commits don't link the revision) I've raised some concerns about the resulting API in https://reviews.llvm.org/D156270#4557902. I'd appreciate if you could take a look. Repository: rG LLVM Github Monorepo

[PATCH] D155380: [clang] Fix delayed template parsing

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I can confirm that the tests pass for me with this applied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155380/new/

[PATCH] D153770: Fix test regression on 32-bit x86.

mgorny added a comment. In D153770#4449154 , @zahiraam wrote: > In D153770#4449078 , @mgorny wrote: > >> I think you also need to require `X86` target but I'm not 100% sure. > > I don't think so. That warning was

[PATCH] D153770: Fix test regression on 32-bit x86.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I can confirm that this fixes the test failures for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/

[PATCH] D153770: Fix test regression on 32-bit x86.

mgorny added a comment. I think you also need to require `X86` target but I'm not 100% sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 ___ cfe-commits

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

mgorny added a comment. This change causes test regressions on 32-bit x86: FAIL: Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c (14665 of 17845) TEST 'Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c' FAILED Script: -- : 'RUN: at

[PATCH] D152696: Prevent deadlocks in death tests.

mgorny added a comment. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152696: Prevent deadlocks in death tests.

mgorny added a comment. This change is causing a lot of unittests to fail on Gentoo. I've tested both on amd64 and arm64; on amd64 additionally the test suite seems to hang. Failed Tests (75): LLVM-Unit :: ADT/./ADTTests/APFloatTest/SemanticsDeath LLVM-Unit ::

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

mgorny added a comment. My educated guess would be that `clangIncludeCleaner` is being linked via `clang_target_link_libraries` while it's not part of `libclang-cpp`, so it should go into regular `target_link_libraries`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

mgorny added a comment. I'm getting completely incomprehensible build errors on Gentoo from this, as of aa7eace8431ba213c5431638b894b0e1b4b481c7 : samu: job failed: : && /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

This revision was automatically updated to reflect the committed changes. Closed by commit rG488a4b24817a: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37 (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

mgorny added a comment. In D148496#4274352 , @browneee wrote: > Issue appears to be with the program rather than the instrumentation. Did the > behavior of the the libc functions used in the test change? If the question was directed at me, then I'm

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

mgorny created this revision. mgorny added reviewers: browneee, vitalybuka, MaskRay, thesamesam, jianzhou.zh. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Mark the two dfsan tests that are known to be broken on glibc-2.37 as

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. WFM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://reviews.llvm.org/D146891

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

mgorny added a comment. Thank you. 16.x isn't affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146427/new/ https://reviews.llvm.org/D146427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bff90e7e84a: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp (authored by mgorny). Repository: rG LLVM Github Monorepo

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

mgorny added a comment. This commit broke building against `libclang-cpp.so` dylib. I've submitted a fix as D146427 but it haven't received any attention so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

mgorny added a reviewer: thesamesam. mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146427/new/ https://reviews.llvm.org/D146427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146427: [clang-tools-extra] Fix linking ClangdTests when using libclang-cpp

mgorny created this revision. mgorny added reviewers: DmitryPolukhin, kadircet, tstellar, MaskRay. Herald added subscribers: mikhail.ramalho, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project:

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added reviewers: MaskRay, thesamesam, tstellar. mgorny added a comment. Ok, this turned out to be surprisingly painless, at least within our packaging. However, I'd prefer if someone more experienced looked at the CMake changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added a comment. While the general direction seems sound, I suspect this may be a real PITA given that for us: -DCLANG_RESOURCE_DIR="../../../../lib/clang/${LLVM_MAJOR}" I'm going to try and see later throughout the week if it's possible to keep that working with this patch.

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. In D140315#4077193 , @yaxunl wrote: > @scchan the test expects CLANG_INSTALL_LIBDIR_BASENAME to be `lib`. Maybe in > the failed test it was not true. `CMAKE_INSTALL_LIBDIR=lib64`, so I guess `_BASENAME` is that as well.

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f8b995b6362: [clang] Fix linking to LLVMTestingAnnotations in standalone build (authored by mgorny). Herald added a project: clang. Repository:

[PATCH] D140315: [AMDGCN] Update search path for device libraries

mgorny added a comment. I'm sorry for reporting it this late (clang's been broken for over two weeks, so we couldn't periodically test it) but this change is causing test regressions on Gentoo/amd64: FAIL: Clang :: Driver/hip-device-libs.hip (9304 of 17486) TEST 'Clang

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

mgorny added a comment. Thanks for the superfast review! I'll push it later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142449/new/ https://reviews.llvm.org/D142449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142449: [clang] Fix linking to LLVMTestingAnnotations in standalone build

mgorny created this revision. mgorny added reviewers: rupprecht, tstellar, MaskRay, thesamesam. Herald added a project: All. mgorny requested review of this revision. The LLVMTestingAnnotations library that is now used by unittests is not installed as part of LLVM. In order to make it possible

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

mgorny added a comment. In D141581#4072692 , @kwk wrote: > In D141581#4071617 , @thesamesam > wrote: > >> This is currently holding back further testing on our end which is >> concerning me a bit, especially as

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

mgorny added reviewers: jbcoe, bkramer. mgorny added a comment. I'm wondering if we shouldn't just by setting `CLANG_NO_DEFAULT_CONFIG=1` like in clang's test suite rather than tying to predict how different config files will affect these tests. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny closed this revision. mgorny added a comment. I've pushed a fix in dab67c66932b9149842f7c8431e951f952125fc0 , based on @jhuber6's fix from the other diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

mgorny closed this revision. mgorny added a comment. Thank you. I'm going to try if the same solution helps with D139723 too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140155/new/

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. In D140155#4004505 , @doru1004 wrote: > Commit 658ed9547cdd6657895339a6c390c31aa77a5698 >

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny added a comment. Also, please link commits to diffs using `Differential Revision:` trailer in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. In D139723#4004536 , @doru1004 wrote: > Commit: 07ff3c5ccce68aed6c1a270b3f89ea14de7aa250 >

[PATCH] D138792: [AArch64] Improve TargetParser API

mgorny added a comment. In D138792#3966920 , @Hahnfeld wrote: > Hi, I bisected this change to lead to a couple of test failures when building > with `LLVM_LINK_LLVM_DYLIB`. In the past, this had to do with global variable > initialization order, but

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138255/new/ https://reviews.llvm.org/D138255

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

mgorny added a comment. Thanks a lot for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139107/new/ https://reviews.llvm.org/D139107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny abandoned this revision. mgorny added a comment. Closing in favor of D139107 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:129 +#if defined(CLANGD_DECISION_FOREST) +# define DEFAULT_RANKING_MODEL DecisionForest sammccall wrote: > this approach feels a bit heavy on the preprocessor, especially for a

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny added a comment. @thesamesam, could you test it on PPC32, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny created this revision. mgorny added reviewers: thesamesam, sammccall, thakis, MaskRay. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project:

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

mgorny added a comment. From Gentoo perspective, correct is better, correct and matching GCC is the best (we support mixing compilers to some degree). I think it'd be best to wait for confirmation on GCC end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

mgorny added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

mgorny resigned from this revision. mgorny added a reviewer: MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. I'm afraid this is above my skills. Maybe @MaskRay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Well, I'm certainly not opposed to making all the paths configurable. However, I'm not sure if having CMake file accessible one way or another wouldn't eventually be a necessity. For one thing, I would like to move more common code from standalone build codepaths of

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. In D137024#3931126 , @thetruestblue wrote: > This patch removes the logic that sets the binary tools dir using > llvm-config. We don't have llvmConfig.cmake in our toolchain or our build > tree and relied on llvm-config to >

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f94fe1c3c4: [clang][Driver] allow tilde in user config dir (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny added a comment. Ah, I'm sorry for the delay. I have time right now, so I'll test and push it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___

[PATCH] D138062: [clang] Don't include C++ Standard Library headers when -nostdinc is used

mgorny accepted this revision as: mgorny. mgorny added a comment. I'd say this is fine to land as 16.x. I'll be doing another snapshot for Gentoo next weekend, so if it lands by then, we're going to do some crash testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM (without testing, just eyeball review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1215-1222 +} else if (ArgStr == "--config") { + if (I + 1 == E) +return createStringError(std::errc::invalid_argument, + "Option '--config' requires an

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

mgorny added inline comments. Comment at: clang/CMakeLists.txt:14 set(CLANG_BUILT_STANDALONE TRUE) + if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0") +message(WARNING I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mgorny added a comment. I don't have a strong opinion. I'm happy as long as there is *anything* telling me "tests were disabled because ...". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/ https://reviews.llvm.org/D137669

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

mgorny added a comment. Could you issue a warning though? It's really annoying when targets disappear like that and you have to guess which of the checks failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137669/new/

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20132d8eaa68: Link libclangBasic against libatomic when necessary. (authored by thesamesam, committed by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

mgorny added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D125860: [clang] Only use major version in resource dir

mgorny added reviewers: serge-sans-paille, sylvestre.ledru, phosek, MaskRay. mgorny added a comment. Herald added subscribers: Michael137, StephenFan. To be honest, I've never seen much purpose in the x.y.z directory naming and I feel like it's making packaging unnecessarily more complex, at

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. > These workarounds are fine for me, but I wonder if it would be useful with a > more direct cmake option to tell it not look for these files at all. CMake has something like that built-in. I think it's `-DCMAKE_DISABLE_FIND_PACKAGE_LLVM=ON`. Repository: rG LLVM

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Thanks! Let's hope it works this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23c665371a98: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Hmm, I suppose it makes sense. At least at a first glance I don't see how it could yield different results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny updated this revision to Diff 472376. mgorny added a comment. Add an explanatory comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275 + "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead") +get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY) +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. @phosek, could you take another look? The only changes are on top of `load_llvm_config`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny updated this revision to Diff 472285. mgorny added a comment. Add a backwards compatibility path that uses `LLVM_CONFIG_PATH` to locate LLVM CMake files. I think it's sufficient to use path relative to the specified location, and we don't want to actually call it. Restore the explicit

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Ok, I think I know what the problem is — these buildbots rely on being able to override `LLVM_CONFIG_PATH`. I'm going to see if I can provide backwards compatibility with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. I'd really use some help with the buildbot failures because I can't even figure out how to reproduce them: https://lab.llvm.org/buildbot#builders/169/builds/13146 https://lab.llvm.org/buildbot#builders/70/builds/29330

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Gotta figure the buildbot regression out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG37acf9bdd468: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added inline comments. Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 +if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) +list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVM) + endif() +else() +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny created this revision. mgorny added reviewers: dberris, justinkb, tstellar, MaskRay, serge-sans-paille, Hahnfeld, mstorsjo, delcypher, phosek. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. mgorny requested review of this revision. Replace the use of the

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I haven't tested it but if it works for you and the test passes, LGTM. @MaskRay, would you be able to test and push it? I don't have a recent clang build tree handy. Repository:

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I think you should be able to test it via overriding `HOME` envvar. I suppose you can limit the test to Unix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136090: Handle errors in expansion of response files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/Driver/ToolChainTest.cpp:604-606 + char *StrBuff = (char *)Alloc.Allocate(6, 2); + std::memcpy(StrBuff, "\xFF\xFE\x00\xD8\x00\x00", 6); +

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:604-606 + char *StrBuff = (char *)Alloc.Allocate(6, 2); + std::memcpy(StrBuff, "\xFF\xFE\x00\xD8\x00\x00", 6); + StringRef BadUTF(StrBuff, 6); Wouldn't it be possible to use

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9dd01a5241dc: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Repository: rG LLVM Github Monorepo

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. In D136572#3889317 , @mstorsjo wrote: > Also for the record, I'd love to get rid of this symlink based setup, if I > could make cmake produce project files where caching works in the same way. > The main requirement for that

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a reviewer: mstorsjo. mgorny added a comment. @mstorsjo, could you check this version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ cfe-commits mailing list

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 471173. mgorny added a comment. Move `LLVM_COMMON_CMAKE_UTILS` earlier and use it for CMakePolicy path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 Files: clang/CMakeLists.txt

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. I've reverted it right now, and I'll update the patch later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ cfe-commits

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88d7508dc479: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Herald added projects: clang, LLDB, Flang.

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

mgorny added a comment. In D136660#3881617 , @MaskRay wrote: > In D136660#3881602 , @mgorny wrote: > >> I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see >> Flang has copied the same

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

mgorny added a comment. I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see Flang has copied the same logic too, so might be worthwhile to remove it there as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. Thanks. Since this is not urgent, I'll let it wait for others to chime in a while more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ cfe-commits mailing list

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470225. mgorny edited the summary of this revision. mgorny added a comment. Herald added a project: LLVM. Use a shared policy file via `include()` instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) nickdesaulniers wrote: > Seems error prone. Does cmake have

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470108. mgorny retitled this revision from "[lld] Copy cmake_policy() to silence CMake warnings in standalone builds" to "Harmonize cmake_policy() across standalone builds of all projects". mgorny edited the summary of this revision. mgorny added reviewers:

[PATCH] D136574: [clang] Copy cmake_policy() to silence CMake warnings in standalone builds

mgorny abandoned this revision. mgorny added a comment. I'll make one patch for all relevant projects instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136574/new/ https://reviews.llvm.org/D136574 ___ cfe-commits mailing list

[PATCH] D136574: [clang] Copy cmake_policy() to silence CMake warnings in standalone builds

mgorny created this revision. mgorny added reviewers: nickdesaulniers, kastiglione, compnerd, MaskRay, thesamesam, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. https://reviews.llvm.org/D136574 Files:

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1029 if (llvm::sys::path::is_relative(CfgFilePath)) { - if (getVFS().makeAbsolute(CfgFilePath)) -return true; - auto Status = getVFS().status(CfgFilePath); - if

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1205 +if (ArgStr[0] == '@') { + FileName = ArgStr.drop_front(1); + if (!llvm::sys::path::is_relative(FileName)) Also, I think you can use `consume_front()` here.

[PATCH] D136354: [Driver] Enable nested configuration files

mgorny added a comment. I like this more than the alternative solution. The code still has some complexity but the behavior is fairly logical and consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I suppose it comes indirectly then. I'd prefer that you tested it with git main, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

mgorny added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:114-117 +target_link_libraries(clangBasic + PRIVATE + ${LLVM_ATOMIC_LIB} +) Is this the right place? Grepping for `std::atomic`, I see lib/Frontend and a bunch of tools, plus a few

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

mgorny added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:48 gen_decision_forest(${CMAKE_CURRENT_SOURCE_DIR}/quality/model CompletionModel clang::clangd::Example) +file(GLOB CompletionModel_files

  1   2   3   4   5   6   7   8   9   >