[PATCH] D143325: [Driver] Add -mllvm= as an alias for -mllvm

Meinersbur added a comment. This patch broke the Flang buildbot, e.g. https://lab.llvm.org/buildbot/#/builders/172/builds/23305 The tests https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/driver-help.f90

[PATCH] D124823: [OpenMPIRBuilder] Introduce OMPRegionInfo managing the stack of OpenMP region constructs.

Meinersbur added a comment. Herald added a reviewer: nicolasvasilache. Herald added a reviewer: dcaballe. Herald added subscribers: Moerafaat, zero9178. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124823/new/

[PATCH] D137338: Fix dupe word typos

Meinersbur added a comment. Changes in `/polly/` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); std::string ClangLoopStr = (llvm::Twine("clang

[PATCH] D131919: Move googletest to the third-party directory

Meinersbur added a comment. Semi-OT: `polly\lib\External` has 3 more third-party libraries. Two of them have been heavily modified in-tree, the third has just a custom CMakeLists.txt. Should these eventually also be moved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3042 + + if (!(Simdlen == nullptr && Safelen == nullptr)) { +// If both simdlen and safelen clauses

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3029-3032 +addLoopMetadata( +CanonicalLoop, +MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.parallel_accesses"), + AccessGroup}));

[PATCH] D129131: Remove uses of llvm_shutdown

Meinersbur added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); This file is imported from the upstream project

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5207-5209 + if (T.clauses().size() > 0) +return false; + return true; simplification

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5209 + OMPLexicalScope Scope(*this, S, OMPD_unknown); + if (CGM.getLangOpts().OpenMPIRBuilder && S.clauses().size() == 0) { +llvm::OpenMPIRBuilder = CGM.getOpenMPRuntime().getOMPBuilder();

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur accepted this revision. Meinersbur added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

Meinersbur added a comment. Why not have `simdlen` an argument to `applySimd` (which can be null if not used)? In this case it happens to be just adding some metadata, but for others such as `unrollLoopPartial` it does not make sense to have the unroll factor set by a different method. It

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added a comment. I looked into Google Benchmark because it also has its main in a .lib library and how it handles it. Turns out it is using cmake which by default always adds `/subsystem:console` unless setting WIN32_EXECUTABLE

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added a comment. In D126291#3552573 , @rovka wrote://italic text// > I don't really know why `link.exe` doesn't work. According to the docs >

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added a comment. While the test passes now, I still get `LINK : fatal error LNK1561: entry point must be defined` when trying to actually link. Isn't it expected to not work yet? Linking with `lld-link.exe` does work. objdump says there is a `_QQmain` symbol, why does lld consider

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added inline comments. Comment at: flang/test/Driver/flang-linker-flags-windows.f90:16 +! Linker invocation to generate the executable +! CHECK-LABEL: lld-link.exe +! CHECK-NOT: libcmt This is failing for me. Instead of `lld-link.exe`, it is using

[PATCH] D124606: Use `-text` git attribute instead of `text eol=...'

Meinersbur added a comment. In D124606#3479793 , @ilya-biryukov wrote: > LGTM This and the commit (@MForster ) was too hasty. There should have been time for people discussing D124563 and D97625

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478627 , @smeenai wrote: > If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and >

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478625 , @smeenai wrote: > I *think* this would mean that if you're on Windows and have `core.autocrlf` > set to `input`, when you commit changes to this files, Git will convert them > back to LF line endings.

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. Regarding `crlf.cpp`(`.expected`), adding the modified changes to a commit indeed solved the problem I described in https://reviews.llvm.org/rGac5f7be6a8688955a282becf00eebc542238a86b#1080897 and I was working with that so far. Still don't know why Linux git doesn't

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. In D118409#3474131 , @kiranchandramohan wrote: > I think the CI is complaining about some clang-format issue in > clang/test/OpenMP/critical_codegen_attr.cpp clang-format should not be applied on Clang tests, many of them

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5571-5579 + { +OMPBuilderCBHelpers::InlinedRegionBodyRAII IRB(*this, AllocaIP, + *FiniBB); +

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118409/new/ https://reviews.llvm.org/D118409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ec501da76fc: [OpenMP] Refactor OMPScheduleType enum. (authored by Meinersbur). Changed prior to commit:

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur updated this revision to Diff 422862. Meinersbur added a comment. - address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123403/new/ https://reviews.llvm.org/D123403 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur marked 7 inline comments as done. Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:135 + UnorderedGuidedSimd = BaseGuidedSimd | ModifierUnordered, // (46) + UnorderedRuntimeSimd = BaseRuntimeSimd | ModifierUnordered,

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur created this revision. Meinersbur added reviewers: peixin, tianshilei1992, jdoerfert, sriharikrishna, Leporacanthicus, kiranchandramohan, clementval. Meinersbur added a project: OpenMP. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe,

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc082ca16f123: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections. (authored by Meinersbur). Repository: rG LLVM Github

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur updated this revision to Diff 420371. Meinersbur marked an inline comment as done. Meinersbur added a comment. - Rebase - Fix convertOmpAtomicUpdate, convertOmpAtomicCapture, and convertOmpOrdered Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:74-75 + // for the allocs. + // TODO: Create a dedicated alloca BasicBlock at function creation such that + // we do

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118409/new/ https://reviews.llvm.org/D118409 ___ cfe-commits mailing list

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117835/new/ https://reviews.llvm.org/D117835 ___ cfe-commits mailing list

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Herald added a project: All. `speculable` implies no undefined behavior (so it can even be speculatively executed with arguments when the source code would not, but its

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1505 + /// valid in the condition block (i.e., defined in the preheader) and is + /// interpreted as an unsigned integer. + void setTripCount(Value *TripCount);

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

Meinersbur added a comment. This patch also caused https://github.com/llvm/llvm-project/issues/54082. I noticed due to the revert making the openmp-offload-cuda-project bot green again (https://lab.llvm.org/staging/#/builders/155/builds/2482)

[PATCH] D118944: [OpenMP] Add Cuda path to linker wrapper tool

Meinersbur added a comment. Thanks for the fix Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8151-8152 const char *LinkingOutput) const { + const auto = getToolChain().getDriver(); + const auto TheTriple = getToolChain().getTriple(); +

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a9e4f245b66: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize. (authored by Meinersbur). Changed prior to commit:

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

Meinersbur added a comment. Pre-merge failures are unrelated. See https://github.com/llvm/llvm-project/issues/53467 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118542/new/ https://reviews.llvm.org/D118542

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. @peixin Thanks for testing edge cases. You hit multiple issues: 1. Chunksize was i32, combining it with a i64 induction variable caused an error. Fixed the latest update of this patch. 2. OpenMPIRBuilder currently doesn't work really with exceptions. See D115216

[PATCH] D118542: [Clang][OpenMPIRBuilder] Fix off-by-one error when dividing by stepsize.

Meinersbur created this revision. Meinersbur added reviewers: kiranchandramohan, ftynse, peixin, jdoerfert, clementval, Leporacanthicus, kiranktp, arnamoy10, bryanpkc, Chuanfeng, AMDChirag, anchu-rajendran, SouraVX, fghanim, jdenny, MatsPetersson, ABataev. Herald added subscribers: zzheng,

[PATCH] D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, kiranchandramohan, peixin, clementval, Leporacanthicus, kiranktp, AMDChirag, fghanim, jdenny, MatsPetersson, ftynse. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota,

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1691-1696 + bool Found = false; + if (llvm::any_of(*LoopBody, [](Instruction ) { +return I.getMetadata("llvm.access.group") != nullptr; + })) +Found = true; +

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the patch. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:1696 + } + EXPECT_EQ(Found, true); +} It would also be

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2587 + // Check for unsupported clauses + if (S.clauses().size() > 0) { +// Currently no clause is supported Comment at:

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added a comment. [testing] Could you add a test for `applySimd` into `OpenMPIRBuilderTests.cpp`, so we have a test that is independent of Clang? Comment at: clang/test/OpenMP/irbuilder_simd.cpp:3 +// expected-no-diagnostics +// RUN: %clang_cc1

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Meinersbur added a comment. ping? @erichkeane Since you are pushing for upgrade the gcc/clang requirement as well, would you take care of that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D115378: OpenMP: Avoid using SmallVector::set_size()

Meinersbur accepted this revision. Meinersbur added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115378/new/ https://reviews.llvm.org/D115378 ___ cfe-commits mailing list

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur requested changes to this revision. Meinersbur added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2588-2594 +if (isa(C) || isa(C) || +isa(C) || isa(C) || +isa(C) || isa(C) || +

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. In D114413#3160044 , @peixin wrote: > In D114413#3159095 , @Meinersbur > wrote: > >> In D114413#3154936 , @peixin wrote: >> >>> > >

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSimdDirective(const OMPSimdDirective ) { + + bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder; + if (UseOMPIRBuilder) { arnamoy10

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. In D114413#3154936 , @peixin wrote: > @Meinersbur Please rebase on main. The function "getPreheader()" was moved > into OMPIRBuilder.h. I rebased, but I am not sure what you are referring to. `getPreheader()` always was in

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. AllocaIP could be handled better, but as a fix LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Meinersbur added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. jhenderson wrote: > RKSimon wrote: > > aaron.ballman wrote: > > > jhenderson wrote:

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for helping to complete the OpenMPIRBuilder implementation! Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

Meinersbur added a comment. This change caused the Polly build to fail: https://lab.llvm.org/buildbot/#/builders/10/builds/7501 opt: /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.src/llvm/include/llvm/IR/PassManager.h:784: typename PassT::Result&

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#3105044 , @manmanren wrote: > It will fail the compilation on the preprocessed output with > error: expected unqualified-id > int test();#pragma clang assume_nonnull end The handler for assume_nonull passes an

[PATCH] D112181: [docs] Remove hard-coded version numbers from sphinx configs

Meinersbur added a comment. Changes in Polly LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112181/new/ https://reviews.llvm.org/D112181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur added a comment. Thanks, this fixed the errors introduced in D105191 : http://meinersbur.de:8011/#/builders/1/builds/1594 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111488/new/

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Some nitpicks, but it fixes the build, so LGTM. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for the path, but command line parsing should be done properly. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:50 +static

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2130117f92e5: [Clang][OpenMP] Allow loop-transformations with template parameters. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf37e8b0b831e: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdenny. Meinersbur added projects: OpenMP, clang. Herald added subscribers: zzheng, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clang

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

Meinersbur updated this revision to Diff 377099. Meinersbur added a comment. Re-sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdenny. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, arphaman, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber:

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. This fixed the builder: http://meinersbur.de:8011/#/builders/76/builds/803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3009377 , @pengfei wrote: > In D109607#3008486 , @Meinersbur > wrote: > >> However, my other one that is connected to lab.llvm.org has failed as well >> and should have

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. In D110037#3008292 , @pengfei wrote: > What do you think? The test-suite is an end-to-end/integration test while tests monorepository are unit/regression tests. They have different purposes. (Personally, I would prefer to

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3008290 , @pengfei wrote: > By the way, does this bot send notification to authors when it fails? I > didn't receive this fail, so I'm not aware of it at the first time. This is my personal staging buildbot server

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. This patch seem to have broken `GCC-C-execute-pr44575` from the llvm-test-suite. See http://meinersbur.de:8011/#/builders/76/builds/761 (this builder compiles with Polly, but it also crashes without Polly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

Meinersbur added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:178 // CHK-BCLIB-USER: clang{{.*}}-triple{{.*}}nvptx64-nvidia-cuda{{.*}}-mlink-builtin-bitcode{{.*}}libomptarget-nvptx-test.bc - +// CHK-BCLIB-USER-DIR:

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Accepting patch since no reaction from @fghanim CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

Meinersbur added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055 +/// Attach loop metadata \p Properties to the loop described by \p Loop. If the +/// loop already has metadata, the loop properties are appended. +static void

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

Meinersbur added a comment. Note that the `OpenMPIRBuilderTest.OrderedDirective` test is still crashing. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2156-2157 + + Value *EntryBBTI = EntryBB->getTerminator(); + EXPECT_EQ(EntryBBTI, nullptr); +

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

Meinersbur added a comment. While manually editing `ordered_codegen.cpp` gives nicer results, re-running `update_cc_test_checks.py` would be less work. Your manual changes would be also be dropped the next time somebody runs update_cc_test_checks.py and commits. The code seems derived from

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1de32d6ddd9: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107540/new/

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

Meinersbur updated this revision to Diff 366161. Meinersbur marked 7 inline comments as done. Meinersbur added a comment. - Address @ftynse's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107540/new/ https://reviews.llvm.org/D107540 Files:

[PATCH] D107540: [OMPBuilder] Clarify CanonicalLoopInfo. NFC.

Meinersbur created this revision. Herald added subscribers: wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, hiraditya. Herald

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:708 /// - /// \returns The insertion position *after* the master. + /// \returns The insertion position *after* the masked. InsertPointTy createMasked(const LocationDescription

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2919775 , @tstellar wrote: > Do we have all the issues fixed in trunk yet or do we need to revert in the > release/13.x branch. All known issues have been fixed on trunk. However, @alexfh said they are going to

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. @mstorsjo I've taken all steps required for the resolution suggested @aaron.ballman. llvm.org/PR51300 suberseedes llvm.org/PR51261 (release-13.x branch is under @tstellard's control). D107183 has been pushed to main to fix the

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2586779ca6: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions. (authored by Meinersbur).

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur updated this revision to Diff 363334. Meinersbur added a comment. - Use %clang_cc1 because %clang adds options according to it triple, i.e. -fms-extensions is added implicitly for Windows targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. > Correct -- that would be unfortunate as I believe you were hoping for this to > be in Clang 13 for ccache support. Yes, that would have been the ideal outcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur updated this revision to Diff 363146. Meinersbur added a comment. Refine test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107183/new/ https://reviews.llvm.org/D107183 Files: clang/lib/Frontend/PrintPreprocessedOutput.cpp

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Patch uploaded here: D107183 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, dblaikie, mstorsjo, romanovvlad, alexfh. Meinersbur added a project: clang. Meinersbur requested review of this revision. The -fms-extensions converts __pragma (and _Pragma) into a #pragma that has to occur at the

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2916897 , @aaron.ballman wrote: > In D104601#2916887 , @Meinersbur > wrote: > >> I am working on a fix, but I wouldn't mind reverting. > > I would be comfortable reverting

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. @romanovvlad This is due to -fms-extensions. It Expands `__Pragma` to `#pragma` instead of keeping it a `__Pragma`. This is a one-line fix. @alexfh This was fixed by D106924 I would suggest to not revert. Will upload a patch for

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. I am working on a fix, but I wouldn't mind reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur added a comment. In D106924#2911145 , @mstorsjo wrote: > @Meinersbur After landing this, can you coordinate with @tstellar to get an > ack for backporting this to the 13.x release branch, which also suffers from > the regression? Release

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6b0b16c0f55: [Preprocessor] -E -P: Ensure newline after 8 skipped lines. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur updated this revision to Diff 362612. Meinersbur added a comment. - Use correct base commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106924/new/ https://reviews.llvm.org/D106924 Files:

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur updated this revision to Diff 362611. Meinersbur added a comment. - Fix embrassing mistakes in skip-empty-lines test (misspelled "LINEMARKES", MINWS<->MINCOL, absolute path) - Skip-empty-lines now also checks leading whitespace behavior - Fix typos in comments Repository: rG LLVM

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Proposed fix here: D106924 The reproducer had another whitespace difference before and after D104601 : " typedef __builtin_va_list __gnuc_va_list;" instead of " typedef __builtin_va_list

[PATCH] D106924: [Preprocessor] -E -P: Ensure newline after 8 skipped lines.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, mstorsjo, dblaikie. Meinersbur added a project: clang. Meinersbur requested review of this revision. The implementation of -fminimize-whitespace (D104601 ) revised the logic when to

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Looking into it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae6b4238: [Preprocessor] Implement -fminimize-whitespace. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Because of how large the switch construct would have been, I created a new function `types::isDerivedFromC` together with the other functions. These commonly have default-cases so compilers would not warn when `Types.def` is amended, but `isDerivedFromC` can be

  1   2   3   4   5   >