[PATCH] D57896: Variable names rule

michaelplatings added a comment. Hi Sam, I won't be able to take this forward but you have my encouragement. To facilitate this change I got as far as changing Git [1], and GitHub has been updated accordingly [2], but I ran out of steam before getting to the change itself. I'd be happy to let

[PATCH] D156427: [clang] Improve hermeticity of clang header tests.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156427/new/ https://reviews.llvm.org/D156427

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

michaelplatings added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +//

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. > some nasty and repetitive regexes Yes, it's the same for Arm architecture extensions. Petr & I went back and forth on this for a long time. See discussion here to understand Petr's concerns: https://discourse.llvm.org/t/rfc-multilib/67494/23 CHANGES SINCE

[PATCH] D155776: [NFC] Add checks for self-assignment.

michaelplatings added a comment. I reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155776/new/ https://reviews.llvm.org/D155776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142702: [Clang][AArch64][SME] Generate target features from +(no)sme.* options

michaelplatings added inline comments. Comment at: clang/test/Driver/aarch64-implied-sme-features.c:49 +// RUN: %clang -target aarch64-linux-gnu -march=armv8-a+nosme+sme-i16i64 %s -### 2>&1 | FileCheck %s --check-prefix=SME-SUBFEATURE-CONFLICT-REV +//

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM but please allow a day for others to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154786/new/

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.h:77 bool isARMAProfile(const llvm::Triple ); +bool isArmBigEndian(const llvm::Triple , const llvm::opt::ArgList ); Arm the company has rebranded but for consistency with

[PATCH] D155294: [Driver][RISCV] Find baremetal multilibs using YAML for GNU toolchain

michaelplatings added a comment. Hi Joe, it's nice to see multilib.yaml getting some adoption :) > For the RISCVMultilibFlags, the mabi flag is used in combination with all the > march extension features (e.g +m). Notably, this doesn't align with the > current arm/aarch64 multilib flags, which

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

michaelplatings accepted this revision. michaelplatings added a comment. Hi @MaskRay, thanks for the add. Yes, we've been deleting a lot of `eabi` recently, but that's specific to AArch64. I have no particular insight into PowerPC but from @jroelofs' link, I agree `eabi` seems correct here.

[PATCH] D154736: [Driver][ARM] Warn about -mabi= for assembler input with -fno-integrated-as

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154736/new/ https://reviews.llvm.org/D154736

[PATCH] D154578: [ARM][Driver] Change float-abi warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79165735e11e: [ARM][Driver] Change float-abi warning (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings updated this revision to Diff 537673. michaelplatings added a comment. Fix duplicate implicit group warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154578/new/ https://reviews.llvm.org/D154578 Files:

[PATCH] D154578: [ARM][Driver] Change float-abi warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously the

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8cbbd55f80: [Clang][Driver] Change missing multilib error to warning (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153943: [test] Replace aarch64-*-eabi with aarch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54c79fa53c17: [test] Replace aarch64-*-eabi with aarch64 (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings added a comment. In D153430#4453908 , @MaskRay wrote: > Thank you for implementing this warning. Side note: it would be better to (a) > fix the tests separately from (b) implementing the warning and (c) adding > tests to demonstrate the

[PATCH] D153943: [test] Replace aarch64-*-eabi with aarch64

michaelplatings created this revision. michaelplatings added a reviewer: MaskRay. Herald added subscribers: kmitropoulou, asbirlea, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers:

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

michaelplatings updated this revision to Diff 535102. michaelplatings added a comment. Rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153885/new/ https://reviews.llvm.org/D153885 Files:

[PATCH] D153885: [Clang][Driver] Change missing multilib error to warning

michaelplatings created this revision. michaelplatings added a reviewer: simon_tatham. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The error could be awkward to work around when

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153691/new/ https://reviews.llvm.org/D153691

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

michaelplatings added a comment. The change seems OK to me in principle, but I'd appreciate the code being more self-descriptive. Thanks. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:528 + +// Accept but warn. +if (Arg *A =

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG041ffc155fd7: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings updated this revision to Diff 533904. michaelplatings added a comment. Tweak warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https://reviews.llvm.org/D153430 Files:

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings added a comment. >selects the fallback GCC toolchain driver; did you mean > This is a correct description of the current behaviour, but I want to keep the freedom to change the behaviour in future. Therefore I'd like to avoid defining what behaviour an invalid target

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings updated this revision to Diff 533566. michaelplatings added a comment. Apply @DavidSpickett's suggestions. @peter.smith since the warning is only emitted in specific cases that we can be say with a high degree of confidence are incorrect I think it's accurate to say "invalid".

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rG028c1033b1ed: [Driver][BareMetal] Error if no matching multilib (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153292/new/

[PATCH] D153430: Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings created this revision. michaelplatings added reviewers: peter.smith, DavidSpickett. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D153418: Adding iconv support to CharSetConverter class

michaelplatings added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:62 +if(Iconv_FOUND AND NOT Iconv_IS_BUILT_IN) + set(system_libs ${system_libs} ${Iconv_LIBRARIES}) +endif() This doesn't look like an idomatic way to link a library. Could you use

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @simon_tatham. I agree there's definitely scope to improve this. The behaviour is quite specific so I kept the code in the BareMetal toolchain rather than as part of the core Multilib class. Other

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously if no matching multilib was found then the

[PATCH] D143587: [Docs] Multilib design

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5aeba737694: [Docs] Multilib design (authored by michaelplatings). Changed prior to commit:

[PATCH] D143075: BareMetal ToolChain multilib layering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab2c80bb1256: [Driver] BareMetal ToolChain multilib layering (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedc1130c0ac0: [Driver] Enable selecting multiple multilibs (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4eebc8674e1: [Driver] Enable multilib.yaml in the BareMetal ToolChain (authored by michaelplatings). Repository: rG LLVM Github Monorepo

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa794ab92b41f: [Driver] Add -print-multi-flags-experimental option (authored by michaelplatings). Changed prior to commit:

[PATCH] D142932: Multilib YAML parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rG4794bdab7aed: [Driver] Multilib YAML parsing (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 529588. michaelplatings added a comment. FlagMap->Mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 529569. michaelplatings added a comment. Update docs to reflect recent changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files:

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529567. michaelplatings added a comment. Simplify code as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files:

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529566. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529565. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142933: [Driver] Add -print-multi-flags-experimental option

michaelplatings updated this revision to Diff 529564. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 529563. michaelplatings added a comment. FlagMap->Mappings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4507dcaeafc: [NFC][Driver] Change MultilibBuilder flags argument order (authored by michaelplatings). Repository: rG LLVM Github Monorepo

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

michaelplatings updated this revision to Diff 529530. michaelplatings marked an inline comment as done. michaelplatings added a comment. Negate->Disallow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152353/new/ https://reviews.llvm.org/D152353

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:242-246 + // No multilibs selected so return a single default multilib. + static llvm::SmallVector Default = {Multilib()}; + return llvm::iterator_range< +

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529318. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529316. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529315. michaelplatings marked an inline comment as done. michaelplatings added a comment. Change string literal as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 529313. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rename option and support fewer options as suggested by @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 529269. michaelplatings added a comment. @phosek thanks for your suggestion, that's now implemented. In practise for LLVM Embedded Toolchain for Arm we haven't yet needed `NoMatchFlags` so I've removed that feature. Repository: rG LLVM Github

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Flag must be a flag accepted by the driver. + MultilibBuilder (bool Required, StringRef Flag);

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

michaelplatings created this revision. michaelplatings added reviewers: phosek, simon_tatham. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Follow

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

This revision was automatically updated to reflect the committed changes. Closed by commit rGce8fa36e59e1: [NFC][Driver] Change Multilib flag representation (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b431d6617d: [NFC][Driver] Change MultilibBuilder interface (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151437/new/

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:228 + +llvm::SmallVector BareMetal::getOrderedMultilibs() const { + // Get multilibs in reverse order because they're ordered most-specific last. phosek wrote: > Can

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 529021. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files:

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 529017. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:183 - SmallString<128> SysRootDir; - llvm::sys::path::append(SysRootDir, getDriver().Dir, "../lib/clang-runtimes", - getDriver().getTargetTriple());

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 529016. michaelplatings marked an inline comment as done. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files:

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 529013. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 528955. michaelplatings marked an inline comment as done. michaelplatings added a comment. Update unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932

[PATCH] D142932: Multilib YAML parsing

michaelplatings marked 2 inline comments as done. michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:150-152 + bool parseYaml(llvm::MemoryBufferRef, + llvm::SourceMgr::DiagHandlerTy = nullptr, + void

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 528932. michaelplatings added a comment. Rebase on D151438 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files:

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings updated this revision to Diff 528826. michaelplatings added a comment. Herald added a subscriber: ormris. Update unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151438/new/ https://reviews.llvm.org/D151438 Files:

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Relanded with the warning in the "OptionIgnored" group which fixes the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Thanks Tom, I'll work on it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d511e1864f1: [ARM][Driver] Warn if -mhard-float is incompatible (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528465. michaelplatings marked an inline comment as done. michaelplatings added a comment. Restore tweak to tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector ) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return;

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528461. michaelplatings added a comment. Add variable specifically for the purpose of specifying whether or not FP regs are available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings added a comment. @phosek you made some alternative suggestions: 1. Have two separate lists of include and exclude flags. 2. Store flags as a tuple (or a struct?) of string and a tag (that is include or exclude). The reason for not doing that is to keep multilib selection method

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings abandoned this revision. michaelplatings added a comment. Abandoning this in favour of D151437 & D151438 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151438: [NFC][Driver] Change Multilib flag representation

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This new representation means that if a string is a valid

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Decouple the

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings accepted this revision. michaelplatings added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 ___ cfe-commits mailing list

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5380-5381 +Builder.CreatePtrToInt(CalleePtr, IntPtrTy); +llvm::Value *AlignedCalleeAddress = Builder.CreateAnd( +CalleeAddress, llvm::ConstantInt::get(IntPtrTy, -2));

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings added a comment. Funnily enough I had the same thought coming to work this morning that we don't need 2 syntaxes. I had an idea that we could only print flags beginning "-" but will consider the other options you suggested as well. Thanks. Repository: rG LLVM Github Monorepo

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 524302. michaelplatings added a comment. Tweak tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 Files:

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif()

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings created this revision. michaelplatings added reviewers: stuij, pratlucas. Herald added subscribers: dmgreen, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

michaelplatings added inline comments. Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() The [[ https://cmake.org/cmake/help/latest/variable/CMAKE_TOOLCHAIN_FILE.html | documentation

[PATCH] D146757: [Driver] Enable defining multilib flags verbatim

michaelplatings updated this revision to Diff 519005. michaelplatings added a comment. Re-run arc diff with clang-format in PATH Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 Files:

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 519004. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 519003. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 519002. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 519001. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D142933: Add -print-multi-selection-flags-experimental option

michaelplatings updated this revision to Diff 519000. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 518999. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings updated this revision to Diff 518997. michaelplatings added a comment. Chagne code to allow defining multilib flags verbatim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 Files:

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:58 + StringRef IncludeSuffix = {}, const flags_list = flags_list(), + PrintOptionsType PrintOptions = PrintOptionsType::PlusFlags, + const flags_list =

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings updated this revision to Diff 511073. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Expand constructor comment as suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings added a comment. It looks like the failing tests already go to some effort to set each of TMP, TEMP & TMPDIR so perhaps they should be simplified to just set CLANG_CRASH_DIAGNOSTICS_DIR instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. Looks useful, and matches the behaviour I would have expected anyway. The buildkite libcxx tests already rely on being able to pass this variable through, so the same seems

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings added a comment. @phosek ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146757/new/ https://reviews.llvm.org/D146757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 508041. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 508040. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 508039. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

  1   2   3   >