[PATCH] D93938: [clang-format] Fixed AfterEnum handling

2021-06-22 Thread Mike Weller via Phabricator via cfe-commits
Userbla added a comment. In D93938#2833045 , @Userbla wrote: > It fails in the second case because we don't respect the 'AfterEnum = true' > and collapse the brace. It appears there is buggy logic in the > `remainingLineCharCount` stuff which others

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

2021-06-22 Thread Mike Weller via Phabricator via cfe-commits
Userbla added a comment. In D93938#2832825 , @Userbla wrote: > I applied this fix locally to a branch based off llvm 11.x and the > `FormatTest.FormatsTypedefEnum` test now fails. So this test is failing: TEST_F(FormatTest, LongEnum) {

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

2021-06-22 Thread Mike Weller via Phabricator via cfe-commits
Userbla added a comment. I applied this fix locally to a branch based off llvm 11.x and the `FormatTest.FormatsTypedefEnum` test now fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2021-06-22 Thread Mike Weller via Phabricator via cfe-commits
Userbla added a comment. I applied this fix locally to a branch based off llvm 11.x and the `FormatTest.FormatsTypedefEnum` test now fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44609/new/ https://reviews.llvm.org/D44609