[clang] [alpha.webkit.UncountedLocalVarsChecker] Ignore local vars of JSC::VM& type (PR #91068)

mikhailramalho wrote: I opened this PR before we spoke offline, I'm closing it now https://github.com/llvm/llvm-project/pull/91068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedLocalVarsChecker] Ignore local vars of JSC::VM& type (PR #91068)

https://github.com/mikhailramalho closed https://github.com/llvm/llvm-project/pull/91068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedLocalVarsChecker] Ignore local vars of JSC::VM& type (PR #91068)

https://github.com/mikhailramalho updated https://github.com/llvm/llvm-project/pull/91068 >From a770060da101720ffddc033fd37db790eaa17710 Mon Sep 17 00:00:00 2001 From: "Mikhail R. Gadelha" Date: Sat, 4 May 2024 13:08:32 -0300 Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Ignore

[clang] [alpha.webkit.UncountedLocalVarsChecker] Ignore local vars of JSC::VM& type (PR #91068)

https://github.com/mikhailramalho updated https://github.com/llvm/llvm-project/pull/91068 >From dde31272c1599a699c49117c1612ae72d0491384 Mon Sep 17 00:00:00 2001 From: "Mikhail R. Gadelha" Date: Sat, 4 May 2024 13:08:32 -0300 Subject: [PATCH] [alpha.webkit.UncountedLocalVarsChecker] Ignore

[clang] [alpha.webkit.UncountedLocalVarsChecker] Ignore local vars of JSC::VM& type (PR #91068)

mikhailramalho wrote: Hey @rniwa, if you want I can send the `safeGetName` changes in a separate patch. I was planning to unify this with `isMethodOnWTFContainerType` so there is some duplicated code here. I'll update the PR next week with some tests.

[clang] [alpha.webkit.UncountedLocalVarsChecker] Ignore local vars of JSC::VM& type (PR #91068)

https://github.com/mikhailramalho created https://github.com/llvm/llvm-project/pull/91068 This patch also updates safeGetName to get names from operators without hitting an assertion >From 7f59654193385e78e1635c9bb2a627522f888b8d Mon Sep 17 00:00:00 2001 From: "Mikhail R. Gadelha" Date: Sat,

[clang] [alpha.webkit.UncountedLocalVarsChecker] Don't warning on inlined functions (PR #90733)

mikhailramalho wrote: Thanks for the feedback folks. I'll close the PR. https://github.com/llvm/llvm-project/pull/90733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedLocalVarsChecker] Don't warning on inlined functions (PR #90733)

https://github.com/mikhailramalho closed https://github.com/llvm/llvm-project/pull/90733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedLocalVarsChecker] Don't warning on inlined functions (PR #90733)

mikhailramalho wrote: @rniwa we noticed quite a drop in the warnings when using this patch, but we understand that there is another approach to handle inline functions: to add the `SUPPRESS_UNCOUNTED_LOCAL` to local variables inside these functions, like it was done here:

[clang] [alpha.webkit.UncountedLocalVarsChecker] Don't warning on inlined functions (PR #90733)

https://github.com/mikhailramalho created https://github.com/llvm/llvm-project/pull/90733 As per the guidelines, trivial inline functions shouldn't be changed to adopt smart pointers. >From a8c7e012a576fd01d6a6bdcb23a43e6669b005e8 Mon Sep 17 00:00:00 2001 From: "Mikhail R. Gadelha" Date:

[clang] 0f6fd1b - [libc] Add support for setjmp and longjmp in riscv

Author: Mikhail R. Gadelha Date: 2023-03-24T16:16:31-03:00 New Revision: 0f6fd1b704c014089f94271e08417a8179ee2b1c URL: https://github.com/llvm/llvm-project/commit/0f6fd1b704c014089f94271e08417a8179ee2b1c DIFF:

r356929 - Moved everything SMT-related to LLVM and updated the cmake scripts.

Author: mramalho Date: Mon Mar 25 10:47:45 2019 New Revision: 356929 URL: http://llvm.org/viewvc/llvm-project?rev=356929=rev Log: Moved everything SMT-related to LLVM and updated the cmake scripts. Differential Revision: https://reviews.llvm.org/D54978 Added:

r353590 - This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.

Author: mramalho Date: Fri Feb 8 16:46:12 2019 New Revision: 353590 URL: http://llvm.org/viewvc/llvm-project?rev=353590=rev Log: This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b. and commit a1853e834c65751f92521f7481b15cf0365e796b. They broke arm and aarch64 Added:

r353373 - Move the SMT API to LLVM

Author: mramalho Date: Wed Feb 6 19:19:45 2019 New Revision: 353373 URL: http://llvm.org/viewvc/llvm-project?rev=353373=rev Log: Move the SMT API to LLVM Moved everything SMT-related to LLVM and updated the cmake scripts. Differential Revision: https://reviews.llvm.org/D54978 Added:

r353372 - Moved the whole SMT API to a single file. NFC.

Author: mramalho Date: Wed Feb 6 19:18:21 2019 New Revision: 353372 URL: http://llvm.org/viewvc/llvm-project?rev=353372=rev Log: Moved the whole SMT API to a single file. NFC. There is no advantage in having them in separate files, I doubt some will ever use them separately. This also makes

r353371 - Got rid of the `Z3ConstraintManager` class

Author: mramalho Date: Wed Feb 6 19:18:10 2019 New Revision: 353371 URL: http://llvm.org/viewvc/llvm-project?rev=353371=rev Log: Got rid of the `Z3ConstraintManager` class Now, instead of passing the reference to a shared_ptr, we pass the shared_ptr instead. I've also removed the check if Z3

r353370 - Generalised the SMT state constraints

Author: mramalho Date: Wed Feb 6 19:17:36 2019 New Revision: 353370 URL: http://llvm.org/viewvc/llvm-project?rev=353370=rev Log: Generalised the SMT state constraints This patch moves the ConstraintSMT definition to the SMTConstraintManager header to make it easier to move the Z3 backend

r347777 - [analyzer] Cleanup constructors in the Z3 backend

Author: mramalho Date: Wed Nov 28 09:22:49 2018 New Revision: 34 URL: http://llvm.org/viewvc/llvm-project?rev=34=rev Log: [analyzer] Cleanup constructors in the Z3 backend Summary: Left only the constructors that are actually required, and marked the move constructors as deleted. They

r345283 - [analyzer] Fixed bitvector from model always being unsigned

Author: mramalho Date: Thu Oct 25 10:27:36 2018 New Revision: 345283 URL: http://llvm.org/viewvc/llvm-project?rev=345283=rev Log: [analyzer] Fixed bitvector from model always being unsigned Summary: Getting an `APSInt` from the model always returned an unsigned integer because of the unused

r345284 - [analyzer] Move canReasonAbout from Z3ConstraintManager to SMTConstraintManager

Author: mramalho Date: Thu Oct 25 10:27:42 2018 New Revision: 345284 URL: http://llvm.org/viewvc/llvm-project?rev=345284=rev Log: [analyzer] Move canReasonAbout from Z3ConstraintManager to SMTConstraintManager Summary: This patch moves the last method in `Z3ConstraintManager` to

r343581 - [analyzer] Improvements to the SMT API

Author: mramalho Date: Tue Oct 2 05:55:48 2018 New Revision: 343581 URL: http://llvm.org/viewvc/llvm-project?rev=343581=rev Log: [analyzer] Improvements to the SMT API Summary: Several improvements in preparation for the new backends. Refactoring: - Removed duplicated methods `fromBoolean`,

r340535 - [analyzer] added cache for SMT queries in the SMTConstraintManager

Author: mramalho Date: Thu Aug 23 06:21:35 2018 New Revision: 340535 URL: http://llvm.org/viewvc/llvm-project?rev=340535=rev Log: [analyzer] added cache for SMT queries in the SMTConstraintManager Summary: This patch implements a new cache for the result of SMT queries; with this patch the

r340534 - [analyzer] Moved all CSA code from the SMT API to a new header, `SMTConv.h`. NFC.

Author: mramalho Date: Thu Aug 23 06:21:31 2018 New Revision: 340534 URL: http://llvm.org/viewvc/llvm-project?rev=340534=rev Log: [analyzer] Moved all CSA code from the SMT API to a new header, `SMTConv.h`. NFC. Summary: With this patch, the SMT backend is almost completely detached from the

r340533 - [analyzer] Templatefy SMTConstraintManager so more generic code can be moved from solver specific implementations. NFC.

Author: mramalho Date: Thu Aug 23 06:21:00 2018 New Revision: 340533 URL: http://llvm.org/viewvc/llvm-project?rev=340533=rev Log: [analyzer] Templatefy SMTConstraintManager so more generic code can be moved from solver specific implementations. NFC. Summary: By making SMTConstraintManager a

r340532 - [analyzer] Delete SMTContext. NFC.

Author: mramalho Date: Thu Aug 23 06:20:18 2018 New Revision: 340532 URL: http://llvm.org/viewvc/llvm-project?rev=340532=rev Log: [analyzer] Delete SMTContext. NFC. Summary: There is no reason to have a base class for a context anymore as each SMT object carries a reference to the specific

r338020 - [analyzer] Fixed method to get APSInt model

Author: mramalho Date: Thu Jul 26 04:17:13 2018 New Revision: 338020 URL: http://llvm.org/viewvc/llvm-project?rev=338020=rev Log: [analyzer] Fixed method to get APSInt model Summary: This patch replaces the current method of getting an `APSInt` from Z3's model by calling generic API method

r337954 - [analyzer] Update SMT API documentation and methods

Author: mramalho Date: Wed Jul 25 12:34:48 2018 New Revision: 337954 URL: http://llvm.org/viewvc/llvm-project?rev=337954=rev Log: [analyzer] Update SMT API documentation and methods Summary: Update the documentation of all the classes introduced with the new generic SMT API, most of them were

r337948 - [analyzer] Fix compilation when LLVM_ENABLE_MODULES=ON

Author: mramalho Date: Wed Jul 25 11:26:50 2018 New Revision: 337948 URL: http://llvm.org/viewvc/llvm-project?rev=337948=rev Log: [analyzer] Fix compilation when LLVM_ENABLE_MODULES=ON Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SMTExpr.h

r337923 - [analyzer] Use the macro REGISTER_TRAIT_WITH_PROGRAMSTATE in the Z3 backend

Author: mramalho Date: Wed Jul 25 05:49:47 2018 New Revision: 337923 URL: http://llvm.org/viewvc/llvm-project?rev=337923=rev Log: [analyzer] Use the macro REGISTER_TRAIT_WITH_PROGRAMSTATE in the Z3 backend Summary: The macro was manually expanded in the Z3 backend and this patch adds it back.

r337922 - [analyzer] Removed API used by the Refutation Manager from SMTConstraintManager and replace by proper calls to SMTSolver

Author: mramalho Date: Wed Jul 25 05:49:43 2018 New Revision: 337922 URL: http://llvm.org/viewvc/llvm-project?rev=337922=rev Log: [analyzer] Removed API used by the Refutation Manager from SMTConstraintManager and replace by proper calls to SMTSolver Summary: Third patch in the refactoring

r337920 - [analyzer] Try to minimize the number of equivalent bug reports evaluated by the refutation manager

Author: mramalho Date: Wed Jul 25 05:49:32 2018 New Revision: 337920 URL: http://llvm.org/viewvc/llvm-project?rev=337920=rev Log: [analyzer] Try to minimize the number of equivalent bug reports evaluated by the refutation manager Summary: This patch changes how the SMT bug refutation runs in an

r337921 - [analyzer] Moved code from SMTConstraintManager to SMTSolver

Author: mramalho Date: Wed Jul 25 05:49:37 2018 New Revision: 337921 URL: http://llvm.org/viewvc/llvm-project?rev=337921=rev Log: [analyzer] Moved code from SMTConstraintManager to SMTSolver Summary: This is the second part of D49668, and moves all the code that's not specific to a

r337919 - [analyzer] Moved non solver specific code from Z3ConstraintManager to SMTConstraintManager

Author: mramalho Date: Wed Jul 25 05:49:29 2018 New Revision: 337919 URL: http://llvm.org/viewvc/llvm-project?rev=337919=rev Log: [analyzer] Moved non solver specific code from Z3ConstraintManager to SMTConstraintManager Summary: This patch moves a lot of code from `Z3ConstraintManager` to

r337914 - [analyzer] Create generic SMT Context class

Author: mramalho Date: Wed Jul 25 05:49:07 2018 New Revision: 337914 URL: http://llvm.org/viewvc/llvm-project?rev=337914=rev Log: [analyzer] Create generic SMT Context class Summary: This patch creates `SMTContext` which will wrap a specific SMT context, through `SMTSolverContext`. The

r337918 - [analyzer] Implemented SMT generic API

Author: mramalho Date: Wed Jul 25 05:49:23 2018 New Revision: 337918 URL: http://llvm.org/viewvc/llvm-project?rev=337918=rev Log: [analyzer] Implemented SMT generic API Summary: Created new SMT generic API. Small changes to `Z3ConstraintManager` because of the new generic objects (`SMTSort`

r337917 - [analyzer] Create generic SMT Expr class

Author: mramalho Date: Wed Jul 25 05:49:19 2018 New Revision: 337917 URL: http://llvm.org/viewvc/llvm-project?rev=337917=rev Log: [analyzer] Create generic SMT Expr class Summary: New base class for all future SMT Exprs. No major changes except moving `areEquivalent` and `getFloatSemantics`

r337915 - [analyzer] Moved static Context to class member

Author: mramalho Date: Wed Jul 25 05:49:11 2018 New Revision: 337915 URL: http://llvm.org/viewvc/llvm-project?rev=337915=rev Log: [analyzer] Moved static Context to class member Summary: Although it is a big patch, the changes are simple: 1. There is one `Z3_Context` now, member of the

r337916 - [analyzer] Create generic SMT Sort Class

Author: mramalho Date: Wed Jul 25 05:49:15 2018 New Revision: 337916 URL: http://llvm.org/viewvc/llvm-project?rev=337916=rev Log: [analyzer] Create generic SMT Sort Class Summary: New base class for all future SMT sorts. The only change is that the class implements methods `isBooleanSort()`,

r337472 - [analyzer] Memoize complexity of SymExpr

Author: mramalho Date: Thu Jul 19 10:03:12 2018 New Revision: 337472 URL: http://llvm.org/viewvc/llvm-project?rev=337472=rev Log: [analyzer] Memoize complexity of SymExpr Summary: This patch introduces a new member to SymExpr, which stores the symbol complexity, avoiding recalculating it every

r337304 - [analyzer] Fix Z3 backend after D48205

Author: mramalho Date: Tue Jul 17 10:40:34 2018 New Revision: 337304 URL: http://llvm.org/viewvc/llvm-project?rev=337304=rev Log: [analyzer] Fix Z3 backend after D48205 Summary: An assertion was added in D48205 to catch places where a `nonloc::SymbolVal` was wrapping a `loc` object. This patch

r337169 - [analyzer] Fix the Z3 backend always generating unsigned APSInt

Author: mramalho Date: Mon Jul 16 06:32:22 2018 New Revision: 337169 URL: http://llvm.org/viewvc/llvm-project?rev=337169=rev Log: [analyzer] Fix the Z3 backend always generating unsigned APSInt Summary: In `toAPSInt`, the Z3 backend was not checking the variable `Int`'s type and was always

r337167 - [analyzer] Fix constraint being dropped when analyzing a program without taint tracking enabled

Author: mramalho Date: Mon Jul 16 06:14:46 2018 New Revision: 337167 URL: http://llvm.org/viewvc/llvm-project?rev=337167=rev Log: [analyzer] Fix constraint being dropped when analyzing a program without taint tracking enabled Summary: This patch removes the constraint dropping when taint

r336671 - [analyzer] Add option to set maximum symbol complexity threshold

Author: mramalho Date: Tue Jul 10 06:46:05 2018 New Revision: 336671 URL: http://llvm.org/viewvc/llvm-project?rev=336671=rev Log: [analyzer] Add option to set maximum symbol complexity threshold Summary: This adds an option, max-symbol-complexity, so an user can set the maximum symbol

r336002 - [analyzer] Replace the vector of ConstraintSets by a single ConstraintSet and a function to merge ConstraintSets

Author: mramalho Date: Fri Jun 29 11:11:43 2018 New Revision: 336002 URL: http://llvm.org/viewvc/llvm-project?rev=336002=rev Log: [analyzer] Replace the vector of ConstraintSets by a single ConstraintSet and a function to merge ConstraintSets Now, instead of adding the constraints when they are

r335932 - [analyzer] fix test case expected warning

Author: mramalho Date: Thu Jun 28 15:08:44 2018 New Revision: 335932 URL: http://llvm.org/viewvc/llvm-project?rev=335932=rev Log: [analyzer] fix test case expected warning After r335814, the constraint manager is no longer generating a false bug report about the division by zero in the test

r335929 - [analyzer] Move test to the correct directory

Author: mramalho Date: Thu Jun 28 14:39:41 2018 New Revision: 335929 URL: http://llvm.org/viewvc/llvm-project?rev=335929=rev Log: [analyzer] Move test to the correct directory It was accidentaly pushed in r335926 Added: cfe/trunk/test/Analysis/PR37855.c - copied, changed from r335927,

r335926 - [analyzer] Fix wrong comparison generation of the ranges generated by the refutation manager

Author: mramalho Date: Thu Jun 28 14:26:52 2018 New Revision: 335926 URL: http://llvm.org/viewvc/llvm-project?rev=335926=rev Log: [analyzer] Fix wrong comparison generation of the ranges generated by the refutation manager The refutation manager is removing a true bug from the test in this

r335752 - Revert "[Analyzer] Moved RangeConstraintManager to header. NFC."

Author: mramalho Date: Wed Jun 27 09:45:58 2018 New Revision: 335752 URL: http://llvm.org/viewvc/llvm-project?rev=335752=rev Log: Revert "[Analyzer] Moved RangeConstraintManager to header. NFC." This broke a number of bots. This reverts commit 5e1a89912d37a21c3b49ccf30600d7f498dffa9c.

r335739 - [analyzer] Fix string not being formatted with extra arguments

Author: mramalho Date: Wed Jun 27 07:39:41 2018 New Revision: 335739 URL: http://llvm.org/viewvc/llvm-project?rev=335739=rev Log: [analyzer] Fix string not being formatted with extra arguments Signed-off-by: Mikhail Ramalho Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified:

r335726 - [Analyzer] Moved RangeConstraintManager to header. NFC.

Author: mramalho Date: Wed Jun 27 05:42:48 2018 New Revision: 335726 URL: http://llvm.org/viewvc/llvm-project?rev=335726=rev Log: [Analyzer] Moved RangeConstraintManager to header. NFC. Summary: While at it, added a dump method to RangeSet. Reviewers: george.karpenkov, NoQ Reviewed By:

r335116 - [analyzer] Optimize constraint generation when the range is a concrete value

Author: mramalho Date: Wed Jun 20 04:42:12 2018 New Revision: 335116 URL: http://llvm.org/viewvc/llvm-project?rev=335116=rev Log: [analyzer] Optimize constraint generation when the range is a concrete value Summary: If a constraint is something like: ``` $0 = [1,1] ``` it'll now be created as:

r334891 - [analyzer] Add method to the generic SMT API to dump the SMT formula

Author: mramalho Date: Sat Jun 16 07:36:17 2018 New Revision: 334891 URL: http://llvm.org/viewvc/llvm-project?rev=334891=rev Log: [analyzer] Add method to the generic SMT API to dump the SMT formula Summary: New method dump the SMT formula and the Z3 implementation. There is no test because I

r333899 - Created a tiny SMT interface and make Z3ConstraintManager implement it

Author: mramalho Date: Mon Jun 4 07:25:58 2018 New Revision: 333899 URL: http://llvm.org/viewvc/llvm-project?rev=333899=rev Log: Created a tiny SMT interface and make Z3ConstraintManager implement it Summary: This patch implements a simple SMTConstraintManager API, and requires the

r333903 - [analyzer] False positive refutation with Z3

Author: mramalho Date: Mon Jun 4 07:40:44 2018 New Revision: 333903 URL: http://llvm.org/viewvc/llvm-project?rev=333903=rev Log: [analyzer] False positive refutation with Z3 Summary: This is a prototype of a bug reporter visitor that invalidates bug reports by re-checking constraints of

r333862 - Moved RangedConstraintManager header to the StaticAnalyser include dir

Author: mramalho Date: Sun Jun 3 17:23:01 2018 New Revision: 333862 URL: http://llvm.org/viewvc/llvm-project?rev=333862=rev Log: Moved RangedConstraintManager header to the StaticAnalyser include dir Summary: Moved `RangedConstraintManager` header from `lib/StaticAnalyzer/Core/` to

r333529 - Fix a (possible) division by zero check in the CmpRuns script

Author: mramalho Date: Wed May 30 04:17:55 2018 New Revision: 333529 URL: http://llvm.org/viewvc/llvm-project?rev=333529=rev Log: Fix a (possible) division by zero check in the CmpRuns script I missed updating the check in r75 Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified:

r333375 - Introduces --stats-only option to only show changes in statistics.

Author: mramalho Date: Mon May 28 08:40:39 2018 New Revision: 75 URL: http://llvm.org/viewvc/llvm-project?rev=75=rev Log: Introduces --stats-only option to only show changes in statistics. Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified: cfe/trunk/utils/analyzer/CmpRuns.py

r333179 - [analyzer] Move RangeSet related declarations into the RangedConstraintManager header.

Author: mramalho Date: Thu May 24 05:16:35 2018 New Revision: 333179 URL: http://llvm.org/viewvc/llvm-project?rev=333179=rev Log: [analyzer] Move RangeSet related declarations into the RangedConstraintManager header. Summary: I could also move `RangedConstraintManager.h` under `include/` if you

r333094 - Test Commit. Fix namespace comment

Author: mramalho Date: Wed May 23 08:49:12 2018 New Revision: 333094 URL: http://llvm.org/viewvc/llvm-project?rev=333094=rev Log: Test Commit. Fix namespace comment Signed-off-by: Mikhail Ramalho Modified: